test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "usurekha@marvell.com" <usurekha@marvell.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "pvukkisala@marvell.com" <pvukkisala@marvell.com>
Subject: Re: [dts] [PATCH] TestSuite_tso.py:Modified csum set commands and	testpmd command for cavium_a063 and cavium_a064
Date: Fri, 10 Jan 2020 07:29:51 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBA54E8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1578635113-6314-1-git-send-email-usurekha@marvell.com>

applied

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of
> usurekha@marvell.com
> Sent: Friday, January 10, 2020 1:45 PM
> To: dts@dpdk.org
> Cc: pvukkisala@marvell.com; usurekha <usurekha@marvell.com>
> Subject: [dts] [PATCH] TestSuite_tso.py:Modified csum set commands and
> testpmd command for cavium_a063 and cavium_a064
> 
> From: usurekha <usurekha@marvell.com>
> 
> Added required tx-offload field in testpmd command.
> Modified csum set commands as SCTP and outer-ip packet checksum is
> unsupported by cavium_a063.
> 
> Signed-off-by: usurekha <usurekha@marvell.com>
> ---
>  tests/TestSuite_tso.py | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/TestSuite_tso.py b/tests/TestSuite_tso.py index
> c53f392..e1b912b 100644
> --- a/tests/TestSuite_tso.py
> +++ b/tests/TestSuite_tso.py
> @@ -208,22 +208,27 @@ class TestTSO(TestCase):
>          self.tester.send_expect("ethtool -K %s rx off tx off tso off gso off gro off
> lro off" % tx_interface, "# ")
>          self.tester.send_expect("ip l set %s up" % tx_interface, "# ")
> 
> -        cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512 --txd=512 --
> burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --
> txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 " % (self.target,
> self.coreMask, self.dut.get_memory_channels(), self.blacklist, self.portMask,
> TSO_MTU)
> +        if (self.nic in ["cavium_a063","cavium_a064"]):
> +            cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512 --txd=512 --
> burst=32 --rxfreet=64 --mbcache=128 --portmask=%s --max-pkt-len=%s --
> txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 --tx-offloads=0x8000" %
> (self.target, self.coreMask, self.dut.get_memory_channels(), self.blacklist,
> self.portMask, TSO_MTU)
> +        else:
> +            cmd = "./%s/app/testpmd -c %s -n %d %s -- -i --rxd=512
> + --txd=512 --burst=32 --rxfreet=64 --mbcache=128 --portmask=%s
> + --max-pkt-len=%s --txpt=36 --txht=0 --txwt=0 --txfreet=32 --txrst=32 "
> + % (self.target, self.coreMask, self.dut.get_memory_channels(),
> + self.blacklist, self.portMask, TSO_MTU)
>          self.dut.send_expect(cmd, "testpmd> ", 120)
>          self.dut.send_expect("set verbose 1", "testpmd> ", 120)
>          self.dut.send_expect("port stop all", "testpmd> ", 120)
>          self.dut.send_expect("csum set ip hw %d" % self.dut_ports[0], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set udp hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
>          self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> +        if (self.nic not in ["cavium_a063", "cavium_a064"]):
> +            self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[0],
> "testpmd> ", 120)
> +            self.dut.send_expect("csum set outer-ip hw %d" %
> + self.dut_ports[0], "testpmd> ", 120)
>          self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[0],
> "testpmd> ", 120)
> 
>          self.dut.send_expect("csum set ip hw %d" % self.dut_ports[1], "testpmd>
> ", 120)
>          self.dut.send_expect("csum set udp hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
>          self.dut.send_expect("csum set tcp hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> -        self.dut.send_expect("csum set outer-ip hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> +        if (self.nic not in ["cavium_a063", "cavium_a064"]):
> +            self.dut.send_expect("csum set sctp hw %d" % self.dut_ports[1],
> "testpmd> ", 120)
> +            self.dut.send_expect("csum set outer-ip hw %d" %
> + self.dut_ports[1], "testpmd> ", 120)
>          self.dut.send_expect("csum parse-tunnel on %d" % self.dut_ports[1],
> "testpmd> ", 120)
> 
>          self.dut.send_expect("tso set 800 %d" % self.dut_ports[1], "testpmd> ",
> 120)
> --
> 2.7.4


      reply	other threads:[~2020-01-10  7:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  5:45 usurekha
2020-01-10  7:29 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBA54E8@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=pvukkisala@marvell.com \
    --cc=usurekha@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).