test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1]framework/qemu_kvm: fix add multiple e1000 nic can't connect vm
@ 2020-01-15  9:48 Xiao Qimai
  2020-01-16  6:19 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Xiao Qimai @ 2020-01-15  9:48 UTC (permalink / raw)
  To: dts; +Cc: Xiao Qimai

fix can't connect vm when add more than one e1000 devices to vm

Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
---
 framework/qemu_kvm.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py
index 849a4a7..7076d35 100644
--- a/framework/qemu_kvm.py
+++ b/framework/qemu_kvm.py
@@ -620,7 +620,8 @@ class QEMUKvm(VirtBase):
         # init the redirect incoming TCP or UDP connections
         # just combine host address and host port, it is enough
         # for using ssh to connect with VM
-        self.hostfwd_addr = host_addr + separator + host_port
+        if not hasattr(self, 'hostfwd_addr'):
+            self.hostfwd_addr = host_addr + separator + host_port
 
         return hostfwd_line
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH V1]framework/qemu_kvm: fix add multiple e1000 nic can't connect vm
  2020-01-15  9:48 [dts] [PATCH V1]framework/qemu_kvm: fix add multiple e1000 nic can't connect vm Xiao Qimai
@ 2020-01-16  6:19 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-01-16  6:19 UTC (permalink / raw)
  To: Xiao, QimaiX, dts; +Cc: Xiao, QimaiX

applied

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Wednesday, January 15, 2020 5:48 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]framework/qemu_kvm: fix add multiple e1000 nic
> can't connect vm
> 
> fix can't connect vm when add more than one e1000 devices to vm
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  framework/qemu_kvm.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py index
> 849a4a7..7076d35 100644
> --- a/framework/qemu_kvm.py
> +++ b/framework/qemu_kvm.py
> @@ -620,7 +620,8 @@ class QEMUKvm(VirtBase):
>          # init the redirect incoming TCP or UDP connections
>          # just combine host address and host port, it is enough
>          # for using ssh to connect with VM
> -        self.hostfwd_addr = host_addr + separator + host_port
> +        if not hasattr(self, 'hostfwd_addr'):
> +            self.hostfwd_addr = host_addr + separator + host_port
> 
>          return hostfwd_line
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15  9:48 [dts] [PATCH V1]framework/qemu_kvm: fix add multiple e1000 nic can't connect vm Xiao Qimai
2020-01-16  6:19 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox