From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B543A051A; Fri, 17 Jan 2020 07:52:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19A891C436; Fri, 17 Jan 2020 07:52:20 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DB1191C435 for ; Fri, 17 Jan 2020 07:52:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2020 22:52:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,329,1574150400"; d="scan'208";a="257691813" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 16 Jan 2020 22:52:16 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 22:52:16 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by shsmsx102.ccr.corp.intel.com ([169.254.2.202]) with mapi id 14.03.0439.000; Fri, 17 Jan 2020 14:52:14 +0800 From: "Tu, Lijuan" To: "Zeng, XiaoxiaoX" , "dts@dpdk.org" CC: "Zeng, XiaoxiaoX" Thread-Topic: [dts] [PATCH V2] tests/cvl_advanced_rss:remove_useless_scripts Thread-Index: AQHVzPs/4q7rJC6EhE+xnEjxnCHR06fua0/Q Date: Fri, 17 Jan 2020 06:52:13 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBAC911@SHSMSX101.ccr.corp.intel.com> References: <1579240693-153791-1-git-send-email-xiaoxiaox.zeng@intel.com> In-Reply-To: <1579240693-153791-1-git-send-email-xiaoxiaox.zeng@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/cvl_advanced_rss:remove_useless_scripts X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" applied > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao > Sent: Friday, January 17, 2020 1:58 PM > To: dts@dpdk.org > Cc: Zeng, XiaoxiaoX > Subject: [dts] [PATCH V2] tests/cvl_advanced_rss:remove_useless_scripts >=20 > *.remove useless import. > *.remove useless parameter. > *.use space replace tab. >=20 > Signed-off-by: Zeng Xiaoxiao > --- > tests/TestSuite_cvl_advanced_rss.py | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) >=20 > diff --git a/tests/TestSuite_cvl_advanced_rss.py > b/tests/TestSuite_cvl_advanced_rss.py > index b38fb8d..8faee33 100644 > --- a/tests/TestSuite_cvl_advanced_rss.py > +++ b/tests/TestSuite_cvl_advanced_rss.py > @@ -11,14 +11,6 @@ from collections import OrderedDict from packet > import IncreaseIP, IncreaseIPv6 import rte_flow_common as rfc >=20 > -from socket import AF_INET6 > -from scapy.utils import struct, socket, wrpcap, rdpcap -from > scapy.layers.inet import Ether, IP, TCP, UDP -from scapy.layers.inet6 imp= ort > IPv6 -from scapy.layers.l2 import Dot1Q -from scapy.layers.sctp import SC= TP, > SCTPChunkData -from nvgre import NVGRE > - > out =3D os.popen("pip list|grep scapy ") > version_result =3Dout.read() > p=3Dre.compile('scapy\s+2\.3\.\d+') > @@ -192,7 +184,6 @@ tv_mac_ipv4_udp_all_frag =3D > { tv_mac_ipv4_udp_nvgre =3D { > "name":"tv_mac_ipv4_udp_nvgre", > "rte_flow_pattern":"flow create 0 ingress pattern eth / ipv4 / udp /= end > actions rss types ipv4-udp end key_len 0 queues end / end", > - > "scapy_str":'Ether(dst=3D"68:05:ca:a3:28:94")/IP()/NVGRE()/Ether()/IP(src= =3DRan > dIP(),dst=3DRandIP())/UDP(sport=3DRandShort(),dport=3DRandShort())/("X"*4= 80)', >=20 > "scapy_str":['Ether(dst=3D"68:05:ca:a3:28:94")/IP()/NVGRE()/Ether()/IP(sr= c=3D"19 > 2.168.0.%d", dst=3D"192.168.0.%d")/UDP(sport=3D%d, dport=3D%d)/("X"*480)'= %(i, > i+10, i+50,i+55) for i in range(0,100)], > "check_func": rfc.check_packets_of_each_queue, > "check_func_param": {"expect_port":0} @@ -796,7 +787,7 @@ > tvs_mac_rss_ipv6_symmetric_toeplitz_nvgre =3D [ > ] >=20 > tvs_mac_rss_symmetric_toeplitz_vxlan =3D [ > - tv_mac_ipv4_vxlan_symmetric_toeplitz, > + tv_mac_ipv4_vxlan_symmetric_toeplitz, > tv_mac_ipv6_vxlan_udp_symmetric_toeplitz, > tv_mac_ipv6_vxlan_symmetric_toeplitz, > tv_mac_ipv6_vxlan_tcp_symmetric_toeplitz, > @@ -874,7 +865,6 @@ class AdvancedRSSTest(TestCase): > self.dut.send_expect("set fwd rxonly", "testpmd> ", 15) > self.dut.send_expect("set verbose 1", "testpmd> ", 15) >=20 > - overall_result =3D True > test_results.clear() > self.count =3D 1 > self.mac_count=3D100 > @@ -907,10 +897,7 @@ class AdvancedRSSTest(TestCase): > self.dut.send_expect("flow flush %d" % self.dut_ports[0], "testp= md> ") > self.dut.send_expect("quit", "#") >=20 > - self.verify(overall_result =3D=3D True, "Some test case failed."= ) > - > - > - def test_advance_rss_ipv4(self): > + def test_advance_rss_ipv4(self): > command =3D self.create_testpmd_command() > self._rte_flow_validate_pattern(tvs_mac_rss_ipv4, command, is_vx= lan =3D > True) >=20 > -- > 1.8.3.1