From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30962A0524; Mon, 20 Jan 2020 06:46:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26F4F2904; Mon, 20 Jan 2020 06:46:18 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7D4F911A4 for ; Mon, 20 Jan 2020 06:46:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jan 2020 21:46:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,340,1574150400"; d="scan'208";a="219551856" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga008.jf.intel.com with ESMTP; 19 Jan 2020 21:46:14 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Jan 2020 21:46:13 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Jan 2020 21:46:13 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.203]) with mapi id 14.03.0439.000; Mon, 20 Jan 2020 13:46:11 +0800 From: "Tu, Lijuan" To: "Ma, LihongX" , "dts@dpdk.org" CC: "Ma, LihongX" Thread-Topic: [dts] [PATCH V1] tests/userspace_ethtool: fix issue about ethtool Thread-Index: AQHVz0lOgMu0zo8+3kecrG8YFZR5OKfzCzyQ Date: Mon, 20 Jan 2020 05:46:10 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBADB1E@SHSMSX101.ccr.corp.intel.com> References: <1579467330-29533-1-git-send-email-lihongx.ma@intel.com> In-Reply-To: <1579467330-29533-1-git-send-email-lihongx.ma@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/userspace_ethtool: fix issue about ethtool X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" applied > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong > Sent: Monday, January 20, 2020 4:56 AM > To: dts@dpdk.org > Cc: Ma, LihongX > Subject: [dts] [PATCH V1] tests/userspace_ethtool: fix issue about ethtoo= l >=20 > 1. skip the step of link status check in case test_port_config because of= kernel > driver issue 2. according to ICE_ETH_OVERHEAD length to set the pkt size >=20 > Signed-off-by: lihong > --- > tests/TestSuite_userspace_ethtool.py | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) >=20 > diff --git a/tests/TestSuite_userspace_ethtool.py > b/tests/TestSuite_userspace_ethtool.py > index 44135cd..8f87ac2 100644 > --- a/tests/TestSuite_userspace_ethtool.py > +++ b/tests/TestSuite_userspace_ethtool.py > @@ -512,7 +512,7 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > # send and sniff packet > inst =3D self.tester.tcpdump_sniff_packets(intf) > pkt.send_pkt(self.tester, tx_port=3Dintf, count=3D4) > - pkts =3D self.tester.load_tcpdump_sniff_packets(inst) > + pkts =3D self.tester.load_tcpdump_sniff_packets(inst, > + timeout=3D3) > self.verify(len(pkts) =3D=3D 4, "Packet not forwarded as exp= ected") > src_mac =3D pkts.strip_layer_element("layer2", "src", p_inde= x=3D0) > self.verify(src_mac =3D=3D valid_mac, "Forwarded packet not = match > default mac") @@ -540,7 +540,11 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > time.sleep(10) > # stop port > self.dut.send_expect("stop %d" % index, "EthApp>") > - self.verify(self.ethapp_check_link_status(index, 'Down') =3D= =3D True, > + # about columbiaville_25g(8086:1593),there have a kernel dri= ver link > status issue > + # about Sageville(8086:1563),driver do not write register to= set link- > down > + # so skip this step of verify status > + if self.nic not in ['columbiaville_25g', 'sageville']: > + self.verify(self.ethapp_check_link_status(index, > + 'Down') =3D=3D True, > 'Fail to stop port{}'.format(index)) > # check packet not forwarded when port is stop > pkt =3D Packet(pkt_type=3D'UDP') @@ -573,6 +577,9 @@ class > TestUserspaceEthtool(TestCase, IxiaPacketGenerator): > if self.nic in ['powerville', 'springville']: > mtu_threshold =3D 2026 > offset =3D 4 > + # RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE > * 2 > + if self.nic in ["columbiaville_25g"]: > + offset =3D 8 > for index in range(len(self.ports)): > port =3D self.ports[index] > # change mtu > @@ -581,6 +588,10 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > ori_mtu =3D self.strip_mtu(intf) > self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# = ") > for mtu in mtus: > + # cvl should stop port before set mtu > + if self.nic in ["columbiaville_25g"]: > + self.dut.send_expect("stop %s" % index, "EthApp>") > + > # The mtu threshold is 2022,When it is greater than 2022= , the > open/stop port is required. > if mtu > mtu_threshold: > if self.nic in ['powerville', 'springville']: > @@ -589,6 +600,10 @@ class TestUserspaceEthtool(TestCase, > IxiaPacketGenerator): > self.dut.send_expect("mtu %d %d" % (index, mtu), "Et= hApp>") > self.dut.send_expect("open %s" % index, "EthApp>") > self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp= >") > + > + if self.nic in ["columbiaville_25g"]: > + self.dut.send_expect("open %s" % index, "EthApp>") > + > time.sleep(5) > ori_rx_pkts, _ =3D self.strip_portstats(index) > pkt_size =3D mtu + HEADER_SIZE['eth'] + offset > -- > 2.7.4