test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, HaiyangX" <haiyangx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, HaiyangX" <haiyangx.zhao@intel.com>
Subject: Re: [dts] [PATCH V1 1/2] tests/l2fwd:add create_eal_parameters func
Date: Tue, 21 Jan 2020 02:08:31 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBAF2D4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1579509545-132564-1-git-send-email-haiyangx.zhao@intel.com>

Applied the series, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Monday, January 20, 2020 4:39 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1 1/2] tests/l2fwd:add create_eal_parameters func
> 
> *.call create_eal_parameters before start l2fwd for ABI test.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  tests/TestSuite_l2fwd.py | 26 ++++++++++++++------------
>  1 file changed, 14 insertions(+), 12 deletions(-)
> 
> diff --git a/tests/TestSuite_l2fwd.py b/tests/TestSuite_l2fwd.py index
> 92f49d1..459b9c9 100644
> --- a/tests/TestSuite_l2fwd.py
> +++ b/tests/TestSuite_l2fwd.py
> @@ -106,8 +106,10 @@ class TestL2fwd(TestCase):
>          """
>          # the cases use the first two ports
>          port_mask = utils.create_mask([self.dut_ports[0], self.dut_ports[1]])
> +        eal_params = self.dut.create_eal_parameters()
> 
> -        self.dut.send_expect("./examples/l2fwd/build/app/l2fwd -n 1 -c f -- -q
> 8 -p %s  &" % port_mask, "L2FWD: entering main loop", 60)
> +        self.dut.send_expect("./examples/l2fwd/build/app/l2fwd %s -- -q 8 -
> p %s  &" % (eal_params, port_mask),
> +                             "L2FWD: entering main loop", 60)
> 
>          for i in [0, 1]:
>              tx_port = self.tester.get_local_port(self.dut_ports[i])
> @@ -136,14 +138,14 @@ class TestL2fwd(TestCase):
>          """
>          # the cases use the first two ports
>          port_mask = utils.create_mask([self.dut_ports[0], self.dut_ports[1]])
> -
> +        cores = self.dut.get_core_list(self.core_config,
> + socket=self.ports_socket)
>          core_mask = utils.create_mask(self.dut.get_core_list(self.core_config,
> -                                                           socket=self.ports_socket))
> +                                                             socket=self.ports_socket))
> +        eal_params = self.dut.create_eal_parameters(cores=cores)
>          for queues in self.test_queues:
> 
> -            command_line = "./examples/l2fwd/build/app/l2fwd -n %d -c %s -- -
> q %s -p %s &" % \
> -                (self.dut.get_memory_channels(), core_mask,
> -                 str(queues['queues']), port_mask)
> +            command_line = "./examples/l2fwd/build/app/l2fwd  %s -- -q %s -
> p %s &" % \
> +                           (eal_params, str(queues['queues']),
> + port_mask)
> 
>              self.dut.send_expect(command_line, "L2FWD: entering main loop",
> 60)
> 
> @@ -167,8 +169,9 @@ class TestL2fwd(TestCase):
>              ports.append(self.dut_ports[port])
> 
>          port_mask = utils.create_mask(ports)
> -        core_mask = utils.create_mask(self.dut.get_core_list(self.core_config,
> -                                                           socket=self.ports_socket))
> +        cores = self.dut.get_core_list(self.core_config,
> + socket=self.ports_socket)
> +
> +        eal_params = self.dut.create_eal_parameters(cores=cores)
> 
>          for frame_size in self.frame_sizes:
> 
> @@ -188,11 +191,10 @@ class TestL2fwd(TestCase):
>                  self.tester.scapy_execute()
>                  cnt += 1
> 
> -            for queues in self.test_queues:
> +            for queues in self.test_queues[0:2]:
> 
> -                command_line = "./examples/l2fwd/build/app/l2fwd -n %d -c %s --
> -q %s -p %s &" % \
> -                    (self.dut.get_memory_channels(), core_mask,
> -                     str(queues['queues']), port_mask)
> +                command_line = "./examples/l2fwd/build/app/l2fwd %s -- -q %s -
> p %s &" % \
> +                    (eal_params, str(queues['queues']), port_mask)
> 
>  #                self.dut.send_expect(command_line, "memory mapped", 60)
>                  self.dut.send_expect(command_line, "L2FWD: entering main loop",
> 60)
> --
> 1.8.3.1


      parent reply	other threads:[~2020-01-21  2:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  8:39 Haiyang Zhao
2020-01-20  8:39 ` [dts] [PATCH V1 2/2] tests/unit_tests_cmdline: add " Haiyang Zhao
2020-01-21  2:08 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBAF2D4@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=haiyangx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).