test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xu, HailinX" <hailinx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, HailinX" <hailinx.xu@intel.com>
Subject: Re: [dts] [PATCH V1 1/2] tests/flow_classify:add create_eal_parameters
Date: Tue, 21 Jan 2020 07:51:42 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBB04D5@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1579575721-138854-1-git-send-email-hailinx.xu@intel.com>

Applied the series.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,hailin
> Sent: Tuesday, January 21, 2020 11:02 AM
> To: dts@dpdk.org
> Cc: Xu, HailinX <hailinx.xu@intel.com>
> Subject: [dts] [PATCH V1 1/2] tests/flow_classify:add create_eal_parameters
> 
> Signed-off-by: xu,hailin <hailinx.xu@intel.com>
> ---
>  tests/TestSuite_flow_classify.py | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_flow_classify.py b/tests/TestSuite_flow_classify.py
> index 7f6eba5..2853f5d 100644
> --- a/tests/TestSuite_flow_classify.py
> +++ b/tests/TestSuite_flow_classify.py
> @@ -247,7 +247,6 @@ class TestFlowClassify(TestCase):
>                  pkt.config_layer(layer, pkt_layers[layer])
>              pkt.pktgen.pkt.show()
>              streams.append(pkt.pktgen.pkt)
> -
>          return streams
> 
>      def send_packet_by_scapy(self, config):
> @@ -304,8 +303,9 @@ class TestFlowClassify(TestCase):
>          if not self.is_existed_on_crb(rule_config):
>              raise VerifyFailure("rules file doesn't existed")
>          core = "1S/1C/1T"
> -        option = r" -c {0} -n 4 --file-prefix=test -- --rule_ipv4={1}".format(
> -            self.get_cores_mask(core), rule_config)
> +        eal_params = self.dut.create_eal_parameters()
> +        #option = r" -c {0} - n 4  --file-prefix=test {1} -- --
> rule_ipv4={2}".format(self.get_cores_mask(core),eal_params,rule_config)
> +        option = r" {0} --
> + --rule_ipv4={1}".format(eal_params,rule_config)
>          prompt = 'table_entry_delete succeeded'
>          cmd = [' '.join([self.flow_classify, option]), prompt, 30]
>          output = self.d_console(cmd)
> @@ -355,6 +355,7 @@ class TestFlowClassify(TestCase):
>          # begin traffic checking
>          self.logger.info("begin traffic ... ")
>          method_name = 'send_packet_by_' + pktgen_name
> +        print('pktname is %s'% pktgen_name)
>          pkt_gen_func = getattr(self, 'send_packet_by_' + pktgen_name)
>          if pkt_gen_func:
>              result = pkt_gen_func(ports_topo) @@ -435,6 +436,7 @@ class
> TestFlowClassify(TestCase):
>              # close flow_classify
>              self.close_flow_classify()
>          except Exception as e:
> +            print(e)
>              # close flow_classify
>              self.close_flow_classify()
>              msg = 'failed to run traffic'
> --
> 1.8.3.1


      parent reply	other threads:[~2020-01-21  7:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  3:02 xu,hailin
2020-01-21  3:02 ` [dts] [PATCH V1 2/2] tests/flow_classify_softnic:add create_eal_parameters xu,hailin
2020-01-21  7:51 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBB04D5@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=hailinx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).