test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V1] framework/dut:optimize code
@ 2020-01-22  3:41 Haiyang Zhao
  2020-02-10  8:54 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Haiyang Zhao @ 2020-01-22  3:41 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.add a blank for eal_str if
 need to add shared lib patch.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/dut.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index 8af5bed..4f376f5 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -224,7 +224,7 @@ class Dut(Crb):
         use_shared_lib = settings.load_global_setting(settings.HOST_SHARED_LIB_SETTING)
         shared_lib_path = settings.load_global_setting(settings.HOST_SHARED_LIB_PATH)
         if use_shared_lib == 'true' and shared_lib_path and 'Virt' not in str(self):
-            eal_str = eal_str + ' -d {}'.format(shared_lib_path)
+            eal_str = eal_str + ' -d {} '.format(shared_lib_path)
 
         return eal_str
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] framework/dut:optimize code
  2020-01-22  3:41 [dts] [PATCH V1] framework/dut:optimize code Haiyang Zhao
@ 2020-02-10  8:54 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2020-02-10  8:54 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Wednesday, January 22, 2020 11:41 AM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] framework/dut:optimize code
> 
> *.add a blank for eal_str if
>  need to add shared lib patch.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  framework/dut.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py index 8af5bed..4f376f5
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -224,7 +224,7 @@ class Dut(Crb):
>          use_shared_lib =
> settings.load_global_setting(settings.HOST_SHARED_LIB_SETTING)
>          shared_lib_path =
> settings.load_global_setting(settings.HOST_SHARED_LIB_PATH)
>          if use_shared_lib == 'true' and shared_lib_path and 'Virt' not in str(self):
> -            eal_str = eal_str + ' -d {}'.format(shared_lib_path)
> +            eal_str = eal_str + ' -d {} '.format(shared_lib_path)
> 
>          return eal_str
> 
> --
> 1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V1] framework/dut:optimize code
  2020-02-18  4:22 Haiyang Zhao
@ 2020-02-18  7:09 ` Tu, Lijuan
  0 siblings, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2020-02-18  7:09 UTC (permalink / raw)
  To: Zhao, HaiyangX, dts; +Cc: Zhao, HaiyangX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao
> Sent: Tuesday, February 18, 2020 12:23 PM
> To: dts@dpdk.org
> Cc: Zhao, HaiyangX <haiyangx.zhao@intel.com>
> Subject: [dts] [PATCH V1] framework/dut:optimize code
> 
> *.test performance with trex support two port map methods,
>   add the pci map method.
> 
> Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
> ---
>  framework/dut.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/framework/dut.py b/framework/dut.py index 4f376f5..4b8bd3e
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -1149,7 +1149,8 @@ class Dut(Crb):
>              if peer is not None:
>                  for remotePort in range(len(self.tester.ports_info)):
>                      if self.tester.ports_info[remotePort]['type'].lower() == 'trex':
> -                        if self.tester.ports_info[remotePort]['intf'].lower() ==
> peer.lower():
> +                        if self.tester.ports_info[remotePort]['intf'].lower() ==
> peer.lower() or \
> +                                self.tester.ports_info[remotePort]['pci'].lower() ==
> peer.lower():
>                              hits[remotePort] = True
>                              self.ports_map[dutPort] = remotePort
>                              break
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V1] framework/dut:optimize code
@ 2020-02-18  4:22 Haiyang Zhao
  2020-02-18  7:09 ` Tu, Lijuan
  0 siblings, 1 reply; 4+ messages in thread
From: Haiyang Zhao @ 2020-02-18  4:22 UTC (permalink / raw)
  To: dts; +Cc: Haiyang Zhao

*.test performance with trex support two port map methods, 
  add the pci map method.

Signed-off-by: Haiyang Zhao <haiyangx.zhao@intel.com>
---
 framework/dut.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/framework/dut.py b/framework/dut.py
index 4f376f5..4b8bd3e 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -1149,7 +1149,8 @@ class Dut(Crb):
             if peer is not None:
                 for remotePort in range(len(self.tester.ports_info)):
                     if self.tester.ports_info[remotePort]['type'].lower() == 'trex':
-                        if self.tester.ports_info[remotePort]['intf'].lower() == peer.lower():
+                        if self.tester.ports_info[remotePort]['intf'].lower() == peer.lower() or \
+                                self.tester.ports_info[remotePort]['pci'].lower() == peer.lower():
                             hits[remotePort] = True
                             self.ports_map[dutPort] = remotePort
                             break
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-22  3:41 [dts] [PATCH V1] framework/dut:optimize code Haiyang Zhao
2020-02-10  8:54 ` Tu, Lijuan
2020-02-18  4:22 Haiyang Zhao
2020-02-18  7:09 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox