test suite reviews and discussions
 help / color / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal	parameters
Date: Mon, 10 Feb 2020 09:05:08 +0000
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBC57F0@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1579758237-87003-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, January 23, 2020 1:44 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/pvp_multi_paths_performance: optimize eal
> parameters
> 
> optimize eal parameters
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_pvp_multi_paths_performance.py | 29 +++++++++++----------
> -----
>  1 file changed, 12 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_multi_paths_performance.py
> b/tests/TestSuite_pvp_multi_paths_performance.py
> index 4c91ebe..df24e77 100644
> --- a/tests/TestSuite_pvp_multi_paths_performance.py
> +++ b/tests/TestSuite_pvp_multi_paths_performance.py
> @@ -58,10 +58,6 @@ class TestPVPMultiPathPerformance(TestCase):
>          self.core_list_host = self.core_list[2:4]
>          self.core_mask_user = utils.create_mask(self.core_list_user)
>          self.core_mask_host = utils.create_mask(self.core_list_host)
> -        if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
> -            self.socket_mem = '1024'
> -        else:
> -            self.socket_mem = '1024,1024'
> 
>          self.out_path = '/tmp'
>          out = self.tester.send_expect('ls -d %s' % self.out_path, '# ') @@ -127,12
> +123,11 @@ class TestPVPMultiPathPerformance(TestCase):
>          self.dut.send_expect("rm -rf ./vhost-net*", "#")
>          self.dut.send_expect("killall -s INT testpmd", "#")
>          self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
> -        command_line_client = "./%s/app/testpmd -n %d -c %s --socket-mem "
> + \
> -                              " %s --legacy-mem -w %s --file-prefix=vhost --vdev " + \
> -                              "'net_vhost0,iface=vhost-net,queues=1,client=0' -- -i --nb-
> cores=1 --txd=1024 --rxd=1024"
> -        command_line_client = command_line_client % (self.target,
> -            self.dut.get_memory_channels(), self.core_mask_host,
> -            self.socket_mem, self.dut.ports_info[self.dut_ports[0]]['pci'])
> +        eal_param = self.dut.create_eal_parameters(socket=self.ports_socket,
> prefix='vhost',
> +
> ports=[self.dut.ports_info[self.dut_ports[0]]['pci']],
> +                                                   vdevs=['net_vhost0,iface=vhost-
> net,queues=1,client=0'])
> +        eal_param += " --single-file-segments"
> +        command_line_client = "./%s/app/testpmd " % self.target + eal_param
> + " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
>          self.vhost.send_expect(command_line_client, "testpmd> ", 120)
>          self.vhost.send_expect("set fwd mac", "testpmd> ", 120)
>          self.vhost.send_expect("start", "testpmd> ", 120) @@ -141,13 +136,13
> @@ class TestPVPMultiPathPerformance(TestCase):
>          """
>          start testpmd on virtio
>          """
> -        command_line_user = "./%s/app/testpmd -n %d -c %s " + \
> -                            " --socket-mem %s --legacy-mem --no-pci --file-prefix=virtio "
> + \
> -                            "--
> vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,%s " + \
> -                            "-- -i %s --rss-ip --nb-cores=1 --txd=1024 --rxd=1024"
> -        command_line_user = command_line_user % (self.target,
> -            self.dut.get_memory_channels(), self.core_mask_user,
> -            self.socket_mem, args["version"], args["path"])
> +        eal_param = self.dut.create_eal_parameters(socket=self.ports_socket,
> prefix='virtio',
> +                                                   no_pci=True,
> +
> vdevs=['net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,%s' %
> +                                                          args["version"]])
> +        eal_param += " --single-file-segments"
> +        command_line_user = "./%s/app/testpmd " % self.target + eal_param +
> " -- -i %s --rss-ip --nb-cores=1 --txd=1024 --rxd=1024" % \
> +                            args["path"]
>          self.vhost_user = self.dut.new_session(suite="user")
>          self.vhost_user.send_expect(command_line_user, "testpmd> ", 120)
>          self.vhost_user.send_expect("set fwd mac", "testpmd> ", 120)
> --
> 1.8.3.1


      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-23  5:43 Xiao Qimai
2020-02-10  9:05 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBC57F0@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox