test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zeng, XiaoxiaoX" <xiaoxiaox.zeng@intel.com>
Subject: Re: [dts] [PATCH V1] tests/userspace_ethtool:port_mtu suit	columbiaville_100g
Date: Tue, 18 Feb 2020 08:33:21 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBCB683@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1581931362-191106-1-git-send-email-xiaoxiaox.zeng@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zeng Xiaoxiao
> Sent: Monday, February 17, 2020 5:23 PM
> To: dts@dpdk.org
> Cc: Zeng, XiaoxiaoX <xiaoxiaox.zeng@intel.com>
> Subject: [dts] [PATCH V1] tests/userspace_ethtool:port_mtu suit
> columbiaville_100g
> 
> *.columbiaville_100g need set offset=8.
> 
> Signed-off-by: Zeng Xiaoxiao <xiaoxiaox.zeng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 8f87ac2..08d1514 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -578,7 +578,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>              mtu_threshold = 2026
>              offset = 4
>          # RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE *
> 2
> -        if self.nic in ["columbiaville_25g"]:
> +        if self.nic in ["columbiaville_25g","columbiaville_100g"]:
>              offset = 8
>          for index in range(len(self.ports)):
>              port = self.ports[index]
> @@ -589,7 +589,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>              self.tester.send_expect("ifconfig %s mtu 9000" % (intf), "# ")
>              for mtu in mtus:
>                  # cvl should stop port before set mtu
> -                if self.nic in ["columbiaville_25g"]:
> +                if self.nic in ["columbiaville_25g","columbiaville_100g"]:
>                      self.dut.send_expect("stop %s" % index, "EthApp>")
> 
>                  # The mtu threshold is 2022,When it is greater than 2022, the
> open/stop port is required.
> @@ -601,7 +601,7 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>                      self.dut.send_expect("open %s" % index, "EthApp>")
>                  self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> 
> -                if self.nic in ["columbiaville_25g"]:
> +                if self.nic in ["columbiaville_25g","columbiaville_100g"]:
>                      self.dut.send_expect("open %s" % index, "EthApp>")
> 
>                  time.sleep(5)
> --
> 1.8.3.1


      parent reply	other threads:[~2020-02-18  8:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-17  9:22 Zeng Xiaoxiao
2020-02-17  9:30 ` Zeng, XiaoxiaoX
2020-02-18  8:33 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBCB683@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xiaoxiaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).