test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Ma,  LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V1 1/1] tests/uni_pkt: x722 support
Date: Fri, 21 Feb 2020 01:51:48 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBCC801@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200219070914.25513-2-yufengx.mo@intel.com>

Applied,  thanks

> -----Original Message-----
> From: Mo, YufengX
> Sent: Wednesday, February 19, 2020 3:09 PM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/1] tests/uni_pkt: x722 support
> 
> 
> x722 support.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_uni_pkt.py | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py index
> e32bc2c..fbca8df 100644
> --- a/tests/TestSuite_uni_pkt.py
> +++ b/tests/TestSuite_uni_pkt.py
> @@ -121,11 +121,14 @@ class TestUniPacket(TestCase):
>              else:
>                  raise VerifyFailure("Failed to detect L2 %s" % l2_type)
> 
> +
>      def test_IPv4_L4(self):
>          """
>          checked that whether L3 and L4 packet can be normally detected.
>          """
> -        if "fortville" in self.nic or "fortpark_TLV" in self.nic or "carlsville" in
> self.nic or "columbiaville" in self.nic:
> +        if "fortville" in self.nic or "fortpark_TLV" in self.nic or \
> +           "carlsville" in self.nic or "columbiaville" in self.nic or \
> +           "x722" in self.nic:
>              outerL4Type = "L4_NONFRAG"
>              ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
>          elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower() or
> "cavium" in self.nic.lower() or "twinpond" in self.nic.lower() or "twinville" in
> self.nic.lower() or "sageville" in self.nic.lower() or "sagepond" in
> self.nic.lower() or "springville" in self.nic.lower():
> @@ -143,7 +146,9 @@ class TestUniPacket(TestCase):
>          }
> 
>          # delete the unsupported packet based on nic type
> -        if "fortville" in self.nic or "fortpark_TLV" in self.nic or "carlsville" in
> self.nic or "columbiaville" in self.nic:
> +        if "fortville" in self.nic or "fortpark_TLV" in self.nic or \
> +           "carlsville" in self.nic or "columbiaville" in self.nic or \
> +           "x722" in self.nic:
>              pktType.pop("MAC_IPihl_PKT")
>              pktType.pop("MAC_IPihl_SCTP_PKT")
>          elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower() or
> "cavium" in self.nic.lower() or "twinpond" in self.nic.lower() or "twinville" in
> self.nic.lower() or "sageville" in self.nic.lower() or "sagepond" in
> self.nic.lower() or "springville" in self.nic.lower():
> @@ -156,7 +161,9 @@ class TestUniPacket(TestCase):
>          """
>          checked that whether IPv6 and L4 packet can be normally detected.
>          """
> -        if "fortville" in self.nic or "fortpark_TLV" in self.nic or "carlsville" in
> self.nic or "columbiaville" in self.nic:
> +        if "fortville" in self.nic or "fortpark_TLV" in self.nic or \
> +           "carlsville" in self.nic or "columbiaville" in self.nic or \
> +           "x722" in self.nic:
>              outerL4Type = "L4_NONFRAG"
>              ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
>          elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower() or
> "cavium" in self.nic.lower() or "twinpond" in self.nic.lower() or "twinville" in
> self.nic.lower() or "sageville" in self.nic.lower() or "sagepond" in
> self.nic.lower() or "springville" in self.nic.lower():
> @@ -172,7 +179,9 @@ class TestUniPacket(TestCase):
>          }
> 
>          # delete the unsupported packet based on nic type
> -        if "fortville" in self.nic or "fortpark_TLV" in self.nic or "carlsville" in
> self.nic or "columbiaville" in self.nic:
> +        if "fortville" in self.nic or "fortpark_TLV" in self.nic or \
> +           "carlsville" in self.nic or "columbiaville" in self.nic or \
> +           "x722" in self.nic:
>              pktType.pop("MAC_IPv6FRAG_PKT_N")
>          elif "niantic" in self.nic.lower() or "powerville" in self.nic.lower() or
> "cavium" in self.nic.lower() or "twinpond" in self.nic.lower() or "twinville" in
> self.nic.lower() or "sageville" in self.nic.lower() or "sagepond" in
> self.nic.lower() or "springville" in self.nic.lower():
>              pktType.pop("MAC_IPv6FRAG_PKT_F")
> --
> 2.21.0


      reply	other threads:[~2020-02-21  1:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  7:09 [dts] [PATCH V1 0/1] " yufengmx
2020-02-19  7:09 ` [dts] [PATCH V1 1/1] " yufengmx
2020-02-21  1:51   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBCC801@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).