test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Ma,  LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V1 1/1] optimize packet send and capture
Date: Fri, 21 Feb 2020 01:51:53 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBCC80D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200219070855.25471-2-yufengx.mo@intel.com>

Applied,  thanks

> -----Original Message-----
> From: Mo, YufengX
> Sent: Wednesday, February 19, 2020 3:09 PM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>; Ma, LihongX
> <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts][PATCH V1 1/1] optimize packet send and capture
> 
> 
> optimize packet send and capture for x722.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_ipv4_reassembly.py | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_ipv4_reassembly.py
> b/tests/TestSuite_ipv4_reassembly.py
> index 3f33809..8d69ac6 100644
> --- a/tests/TestSuite_ipv4_reassembly.py
> +++ b/tests/TestSuite_ipv4_reassembly.py
> @@ -209,7 +209,7 @@ class TestIpReassembly(TestCase):
>          self.tester.scapy_append(
>              'pcap = rdpcap("%s")' % self.test_config.pcap_file)
>          self.tester.scapy_append(
> -            'sendp(pcap, iface="%s")' % self.test_config.tester_iface)
> +            'sendp(pcap, iface="%s", verbose=False)' %
> + self.test_config.tester_iface)
>          self.tester.scapy_execute()
>          time.sleep(5)
> 
> @@ -226,6 +226,12 @@ class TestIpReassembly(TestCase):
>          os.remove(self.test_config.pcap_file)
>          time.sleep(5)
> 
> +    @property
> +    def wait_interval_for_tcpdump(self):
> +        interval = 5 if self.nic in ["x722_37d2"] \
> +                   else 0
> +        return interval
> +
>      def tcpdump_start_sniffing(self):
>          """
>          Starts tcpdump in the background to sniff the tester interface where
> @@ -238,12 +244,13 @@ class TestIpReassembly(TestCase):
>                     self.test_config.tester_iface)
>          self.tester.send_expect('rm -f tcpdump.pcap', '#')
>          self.tester.send_expect(command, '#')
> +        time.sleep(self.wait_interval_for_tcpdump)
> 
>      def tcpdump_stop_sniff(self):
>          """
>          Stops the tcpdump process running in the background.
>          """
> -
> +        time.sleep(self.wait_interval_for_tcpdump)
>          self.tester.send_expect('killall tcpdump', '#')
>          # For the [pid]+ Done tcpdump... message after killing the process
>          self.tester.send_expect('cat tcpdump.out', '#')
> --
> 2.21.0


      reply	other threads:[~2020-02-21  1:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-19  7:08 [dts] [PATCH V1 0/1] tests/ipv4_reassembly: " yufengmx
2020-02-19  7:08 ` [dts] [PATCH V1 1/1] " yufengmx
2020-02-21  1:51   ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBCC80D@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).