test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Ma, LihongX" <lihongx.ma@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Ma, LihongX" <lihongx.ma@intel.com>
Subject: Re: [dts] [PATCH V1] framework/crb: fix the issue of kill trex
Date: Wed, 26 Feb 2020 09:14:01 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBCE8D1@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1582671998-31664-1-git-send-email-lihongx.ma@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of lihong
> Sent: Wednesday, February 26, 2020 7:07 AM
> To: dts@dpdk.org
> Cc: Ma, LihongX <lihongx.ma@intel.com>
> Subject: [dts] [PATCH V1] framework/crb: fix the issue of kill trex
> 
> when tester and dut on same server, and the pktgen is trex, skip to kill trex
> when dut call the kill_all.
> 
> Signed-off-by: lihong <lihongx.ma@intel.com>
> ---
>  framework/crb.py | 27 ++++++++++++++++++++++++++-
>  1 file changed, 26 insertions(+), 1 deletion(-)
> 
> diff --git a/framework/crb.py b/framework/crb.py index 2d81550..2ac197e
> 100644
> --- a/framework/crb.py
> +++ b/framework/crb.py
> @@ -35,7 +35,7 @@ import os
>  from settings import TIMEOUT, IXIA
>  from ssh_connection import SSHConnection  from logger import getLogger -
> from config import PortConf, PORTCONF
> +from config import PortConf, PORTCONF, PktgenConf
> 
>  """
>  CRB (customer reference board) basic functions and handlers @@ -60,6
> +60,7 @@ class Crb(object):
>          self.sessions = []
>          self.stage = 'pre-init'
>          self.name = name
> +        self.trex_prefix = None
> 
>          self.logger = getLogger(name)
>          self.session = SSHConnection(self.get_ip_address(), name, @@ -466,10
> +467,34 @@ class Crb(object):
>              f.write(contents)
>          self.session.copy_file_to(fileName, password=self.get_password())
> 
> +    def check_trex_process_existed(self):
> +        """
> +        if the tester and dut on same server
> +        and pktgen is trex, do not kill the process
> +        """
> +        if self.crb['pktgen'].lower() == 'trex':
> +            if self.crb['IP'] == self.crb['tester IP'] and self.trex_prefix is None:
> +                conf_inst = PktgenConf('trex')
> +                conf_info = conf_inst.load_pktgen_config()
> +                if 'config_file' in conf_info:
> +                    config_file = conf_info['config_file']
> +                else:
> +                    config_file = '/etc/trex_cfg.yaml'
> +                fd = open(config_file, 'r')
> +                output = fd.read()
> +                fd.close()
> +                prefix = re.search("prefix\s*:\s*(\S*)", output)
> +                if prefix is not None:
> +                    self.trex_prefix = prefix.group(1)
> +        return self.trex_prefix
> +
>      def get_dpdk_pids(self, prefix_list, alt_session):
>          """
>          get all dpdk applications on CRB.
>          """
> +        trex_prefix = self.check_trex_process_existed()
> +        if trex_prefix is not None and trex_prefix in prefix_list:
> +            prefix_list.remove(trex_prefix)
>          file_directorys = ['/var/run/dpdk/%s/config' % file_prefix for file_prefix
> in prefix_list]
>          pids = []
>          pid_reg = r'p(\d+)'
> --
> 2.7.4


      parent reply	other threads:[~2020-02-26  9:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-25 23:06 lihong
2020-02-26  6:36 ` Ma, LihongX
2020-02-26  9:14 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBCE8D1@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lihongx.ma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).