From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B1F6A0564; Fri, 28 Feb 2020 03:51:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F1B337AF; Fri, 28 Feb 2020 03:51:05 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 24FCC1F1C for ; Fri, 28 Feb 2020 03:51:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2020 18:51:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,493,1574150400"; d="scan'208";a="439086752" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 27 Feb 2020 18:51:01 -0800 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Feb 2020 18:51:00 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 27 Feb 2020 18:51:00 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.43]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.144]) with mapi id 14.03.0439.000; Fri, 28 Feb 2020 10:50:58 +0800 From: "Tu, Lijuan" To: "Xiao, QimaiX" , "Zhao, HaiyangX" , "dts@dpdk.org" CC: "Zhao, HaiyangX" Thread-Topic: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env Thread-Index: AQHV7d/rYBK4vv+lOESlZAnmqjb5T6gv59iw Date: Fri, 28 Feb 2020 02:50:57 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE3B8A@SHSMSX101.ccr.corp.intel.com> References: <1582619670-406390-1-git-send-email-haiyangx.zhao@intel.com> <8CE3E05A3F976642AAB0F4675D0AD20E0BBCDFD2@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/TestSuite_virtio_user_for_container_networking: remove redundant parameter single-file-segments if not 2M env X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" As you said, it was required on 2M env, so it's not reasonable to remove it= without any judgement. > -----Original Message----- > From: Xiao, QimaiX > Sent: Friday, February 28, 2020 10:37 AM > To: Tu, Lijuan ; Zhao, HaiyangX > ; dts@dpdk.org > Cc: Zhao, HaiyangX > Subject: RE: [dts] [PATCH > V1]tests/TestSuite_virtio_user_for_container_networking: remove > redundant parameter single-file-segments if not 2M env >=20 > Hi, Lijuan >=20 > I consulted lihong that single-file-segments parameter only required on v= irtio > side in 2M env, vhost side doesn't need, so it's ok to remove it. >=20 > Regards, > Xiao Qimai >=20 >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Tu, Lijuan > > Sent: Tuesday, February 25, 2020 5:01 PM > > To: Zhao, HaiyangX ; dts@dpdk.org > > Cc: Zhao, HaiyangX > > Subject: Re: [dts] [PATCH > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > redundant parameter single-file-segments if not 2M env > > > > Remove single-file-segments, so what will happen, if 2M env ? > > > > > -----Original Message----- > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Haiyang Zhao > > > Sent: Tuesday, February 25, 2020 4:35 PM > > > To: dts@dpdk.org > > > Cc: Zhao, HaiyangX > > > Subject: [dts] [PATCH > > > V1]tests/TestSuite_virtio_user_for_container_networking: remove > > > redundant parameter single-file-segments if not 2M env > > > > > > remove redundant parameter > > > > > > Signed-off-by: Haiyang Zhao > > > --- > > > tests/TestSuite_virtio_user_for_container_networking.py | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/TestSuite_virtio_user_for_container_networking.py > > > b/tests/TestSuite_virtio_user_for_container_networking.py > > > index ba303b7..1f9a666 100644 > > > --- a/tests/TestSuite_virtio_user_for_container_networking.py > > > +++ b/tests/TestSuite_virtio_user_for_container_networking.py > > > @@ -164,7 +164,7 @@ class TestVirtioUserForContainer(TestCase): > > > command_line_user =3D 'docker run -i -t --privileged -v > > > %s/vhost- net:/tmp/vhost-net ' + \ > > > '-v /mnt/huge:/dev/hugepages ' + \ > > > '-v %s:%s %s .%s/%s/app/testpmd -c %s -n= %d ' + \ > > > - '-m 1024 --no-pci --file-prefix=3Dcontai= ner --single-file- > > > segments ' + \ > > > + '-m 1024 --no-pci > > > + --file-prefix=3Dcontainer ' + \ > > > '-- > > > vdev=3Dvirtio_user0,mac=3D00:11:22:33:44:10,path=3D/tmp/vhost- > > net,queues=3D%d ' > > > + \ > > > '-- -i --rxq=3D%d --txq=3D%d --nb-cores= =3D%d' > > > command_line_user =3D command_line_user % > > > (self.container_base_dir, > > > -- > > > 1.8.3.1