test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhu, ShuaiX" <shuaix.zhu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add	create_eal_parameters function.
Date: Tue, 3 Mar 2020 05:41:29 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE8F64@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1582708737-36706-4-git-send-email-shuaix.zhu@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Wednesday, February 26, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX
> <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add
> create_eal_parameters function.
> 
> 
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_pvp_vhost_user_reconnect.py | 26 +++++++--------------
>  1 file changed, 9 insertions(+), 17 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_vhost_user_reconnect.py
> b/tests/TestSuite_pvp_vhost_user_reconnect.py
> index 7b201a0..f361373 100644
> --- a/tests/TestSuite_pvp_vhost_user_reconnect.py
> +++ b/tests/TestSuite_pvp_vhost_user_reconnect.py
> @@ -56,10 +56,9 @@ class TestPVPVhostUserReconnect(TestCase):
>          # Get the port's socket
>          self.pf = self.dut_ports[0]
>          netdev = self.dut.ports_info[self.pf]['port']
> +        self.pci_info = self.dut.ports_info[0]['pci']
>          self.socket = netdev.get_nic_socket()
>          self.cores = self.dut.get_core_list("1S/2C/1T", socket=self.socket)
> -        self.coremask = utils.create_mask(self.cores)
> -        self.memory_channel = self.dut.get_memory_channels()
>          self.dst_mac = self.dut.get_mac_address(self.dut_ports[0])
>          # set diff arg about mem_socket base on socket number
>          if len(set([int(core['socket']) for core in self.dut.cores])) == 1:
> @@ -101,14 +100,10 @@ class TestPVPVhostUserReconnect(TestCase):
>          vdev_info = ""
>          for i in range(self.vm_num):
>              vdev_info += "--vdev 'net_vhost%d,iface=vhost-
> net%d,client=1,queues=1' " % (i, i)
> -        self.vhostapp_testcmd = self.dut.base_dir + \
> -                    "/%s/app/testpmd -c %s -n %d --socket-mem %s --legacy-mem" +
> \
> -                    " --file-prefix=vhost %s" + \
> -                    " -- -i --port-topology=chained --nb-cores=1" + \
> -                    " --txd=1024 --rxd=1024"
> -        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
> -                                self.coremask, self.memory_channel,
> -                                self.socket_mem, vdev_info)
> +        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
> +        eal_params = self.dut.create_eal_parameters(cores=self.cores,
> prefix='vhost', ports=[self.pci_info])
> +        para = " -- -i --port-topology=chained --nb-cores=1 --txd=1024 --
> rxd=1024"
> +        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
>          self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ", 40)
>          self.vhost_user.send_expect("set fwd mac", "testpmd> ", 40)
>          self.vhost_user.send_expect("start", "testpmd> ", 40) @@ -120,13
> +115,10 @@ class TestPVPVhostUserReconnect(TestCase):
>          vdev_info = ""
>          for i in range(self.vm_num):
>              vdev_info += "--vdev 'net_vhost%d,iface=vhost-
> net%d,client=1,queues=1' " % (i, i)
> -        self.vhostapp_testcmd = self.dut.base_dir + \
> -                    "/%s/app/testpmd -c %s -n %d --socket-mem %s --legacy-mem" +
> \
> -                    " --no-pci --file-prefix=vhost %s" + \
> -                    " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> -        self.vhostapp_testcmd = self.vhostapp_testcmd % (self.target,
> -                                self.coremask, self.memory_channel,
> -                                self.socket_mem, vdev_info)
> +        testcmd = self.dut.base_dir + "/%s/app/testpmd " % self.target
> +        eal_params = self.dut.create_eal_parameters(cores=self.cores,
> no_pci=True, prefix='vhost', ports=[self.pci_info])
> +        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> +        self.vhostapp_testcmd = testcmd + eal_params + vdev_info + para
>          self.vhost_user.send_expect(self.vhostapp_testcmd, "testpmd> ", 40)
>          self.vhost_user.send_expect("start", "testpmd> ", 40)
> 
> --
> 2.17.2


  parent reply	other threads:[~2020-03-03  5:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-26  9:18 [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_diff_qemu_version:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_qemu_multi_paths_port_restart:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_vhost_user_reconnect:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan [this message]
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_bonding:add " zhu,shuai
2020-02-27  9:52   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_2M_hugepages:add " zhu,shuai
2020-02-26  9:18 ` [dts] [PATCH V1] tests/pvp_virtio_user_4k_pages:add " zhu,shuai
2020-02-27  9:54   ` Zhu, ShuaiX
2020-03-03  5:41   ` Tu, Lijuan
2020-02-26  9:18 ` [dts] [PATCH V1] tests/virtio_pvp_regression:add " zhu,shuai
2020-02-27  9:51 ` [dts] [PATCH V1] tests/perf_virtio_user_pvp:add " Zhu, ShuaiX
2020-03-03  5:29 ` Tu, Lijuan
2020-03-03  5:50   ` Zhu, ShuaiX
2020-03-03  7:42     ` Tu, Lijuan
2020-03-16  3:36       ` Wang, Yinan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBE8F64@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=shuaix.zhu@intel.com \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).