test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Peng, Yuan" <yuan.peng@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dts] [PATCH]test_plans: add mark/rss to cvl_fdir_test_plan.rst
Date: Tue, 3 Mar 2020 07:37:20 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBE9383@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1583206135-15306-1-git-send-email-yuan.peng@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Yuan
> Sent: Tuesday, March 3, 2020 11:29 AM
> To: dts@dpdk.org
> Cc: Peng, Yuan <yuan.peng@intel.com>
> Subject: [dts] [PATCH]test_plans: add mark/rss to cvl_fdir_test_plan.rst
> 
> Add mark/rss action to cvl_fdir_test_plan.rst
> 
> Signed-off-by: Peng Yuan <yuan.peng@intel.com>
> 
> diff --git a/test_plans/cvl_fdir_test_plan.rst
> b/test_plans/cvl_fdir_test_plan.rst
> index 0b0f4de..12467f7 100644
> --- a/test_plans/cvl_fdir_test_plan.rst
> +++ b/test_plans/cvl_fdir_test_plan.rst
> @@ -96,6 +96,7 @@ Action type
>      passthru
>      count identifier 0x1234 shared on|off
>      mark id
> +    mark/rss
> 
> 
>  Prerequisites
> @@ -920,10 +921,10 @@ Test case: MAC_IPV4_UDP passthru/mark
> 
>  1. create filter rules::
> 
> -    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4 src is
> 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / udp src is 22 dst is 23 / end
> actions passthru / mark / end
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / udp src is
> + 22 dst is 23 / end actions passthru / end
> 
> -2. send matched packets, check the packets are redirected by RSS with FDIR
> ID.
> -   send mismatched packets, check the packets are redirected by RSS without
> FDIR ID.
> +2. send matched packets, check the packets are redirected by RSS.
> +   send mismatched packets, check the packets are redirected by RSS.
> 
>  3. verify rules can be listed and destroyed::
> 
> @@ -934,7 +935,7 @@ Test case: MAC_IPV4_UDP passthru/mark
> 
>      testpmd> flow destroy 0 rule 0
> 
> -   verify matched packet is redirected to the same queue without FDIR ID.
> +   verify matched packet is redirected to the same queue.
>     check there is no rule listed.
> 
>  Test case: MAC_IPV4_TCP passthru/mark
> @@ -1245,6 +1246,373 @@ Test case: MAC_IPV4_TUN_MAC_IPV4_SCTP
> passthru/mark
>     verify matched packet is redirected to the same queue without FDIR ID.
>     check there is no rule listed.
> 
> +Test case: MAC_IPV4_PAY mark/rss
> +================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 proto is 255 ttl is 2 tos is 4
> + / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packets are redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_UDP mark/rss
> +================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / udp src is
> + 22 dst is 23 / end actions mark / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 0.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 0.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TCP mark/rss
> +================================
> +
> +1. create filter rules::
> +
> +   flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / tcp src is
> + 22 dst is 23 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_SCTP mark/rss
> +=================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / sctp src
> + is 22 dst is 23 tag is 1 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV6_PAY mark/rss
> +================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6
> + dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 proto is
> + 1 hop is 2 tc is 1 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV6_UDP mark/rss
> +================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6
> + dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 hop is 2
> + tc is 1 / udp src is 22 dst is 23 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV6_TCP mark/rss
> +================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6
> + dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 hop is 2
> + tc is 1 / tcp src is 22 dst is 23 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV6_SCTP mark/rss
> +=================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv6
> + dst is CDCD:910A:2222:5498:8475:1111:3900:2020 src is 2001::2 hop is 2
> + tc is 1 / sctp src is 22 dst is 23 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_IPV4_PAY mark/rss
> +=========================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / ipv4 src
> + is 192.168.0.20 dst is 192.168.0.21 / end actions mark / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 0.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 0.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_IPV4_UDP mark/rss
> +=========================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / ipv4 src
> + is 192.168.0.20 dst is 192.168.0.21 / udp src is 22 dst is 23 / end
> + actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_IPV4_TCP mark/rss
> +=========================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / ipv4 src
> + is 192.168.0.20 dst is 192.168.0.21 / tcp src is 22 dst is 23 / end
> + actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_IPV4_SCTP mark/rss
> +==========================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / ipv4 src
> + is 192.168.0.20 dst is 192.168.0.21 / sctp src is 22 dst is 23 / end
> + actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_MAC_IPV4_PAY mark/rss
> +=============================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 / end actions mark id 1 / rss
> + / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_MAC_IPV4_UDP mark/rss
> +=============================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 / udp src is 22 dst is 23 /
> + end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_MAC_IPV4_TCP mark/rss
> +=============================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 / tcp src is 22 dst is 23 /
> + end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: MAC_IPV4_TUN_MAC_IPV4_SCTP mark/rss
> +==============================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / vxlan / eth / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 / sctp src is 22 dst is 23 /
> + end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packet is redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
> +Test case: mark/rss wrong parameters
> +====================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth dst is 00:11:22:33:44:55 / ipv4
> + src is 192.168.0.20 dst is 192.168.0.21 ttl is 2 tos is 4 / udp src is
> + 22 dst is 23 / end actions rss / end
> +
> +2. The rule failed to be created, report proper error message.
> +
> +3. list the flow::
> +
> +    testpmd> flow list 0
> +
> +   there is no flow listed.
> +
>  Test case: MAC_IPV4_PAY drop
>  ============================
> 
> @@ -2022,6 +2390,28 @@ Test case: MAC_IPV4_GTPU_EH passthru/mark
>     verify matched packets are redirected to the same queue without FDIR ID.
>     check there is no rule listed.
> 
> +Test case: MAC_IPV4_GTPU_EH mark/rss
> +====================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is
> + 0x12345678 / gtp_psc qfi is 0x34 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packets are redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
>  Test case: MAC_IPV4_GTPU_EH drop
>  ================================
> 
> @@ -2110,6 +2500,28 @@ Test case: MAC_IPV4_GTPU passthru/mark
>     verify matched packets are redirected to the same queue without FDIR ID.
>     check there is no rule listed.
> 
> +Test case: MAC_IPV4_GTPU mark/rss
> +=================================
> +
> +1. create filter rules::
> +
> +    flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is
> + 0x12345678 / end actions mark id 1 / rss / end
> +
> +2. send matched packets, check the packets are redirected by RSS with FDIR
> ID 1.
> +   send mismatched packets, check the packets are redirected by RSS
> without FDIR ID 1.
> +
> +3. verify rules can be listed and destroyed::
> +
> +    testpmd> flow list 0
> +
> +   check the existing rule.
> +   destroy the rule::
> +
> +    testpmd> flow destroy 0 rule 0
> +
> +   verify matched packets are redirected to the same queue without FDIR ID.
> +   check there is no rule listed.
> +
>  Test case: MAC_IPV4_GTPU drop
>  =============================
> 
> @@ -2405,7 +2817,7 @@ Test case: MAC_IPV4_GTPU_EH wrong parameters
>      flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x12345678 /
> gtp_psc qfi is 0x100 / end actions queue index 1 / end
>      flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x100000000 /
> gtp_psc qfi is 0x5 / end actions queue index 2 / end
> 
> -   the two flows can not be created successfully.
> +   the two flows can not be created successfully, report proper error
> message.
> 
>  2. list the flow::
> 
> --
> 2.7.4


      reply	other threads:[~2020-03-03  7:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-03  3:28 Peng Yuan
2020-03-03  7:37 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBE9383@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).