test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Han, YingyaX" <yingyax.han@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Mo, YufengX" <yufengx.mo@intel.com>
Subject: Re: [dts] [PATCH V1 1/2]framework: fix the error of getting vlan value
Date: Wed, 11 Mar 2020 01:31:59 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBEB7CB@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1583831065-152238-1-git-send-email-yingyax.han@intel.com>



> -----Original Message-----
> From: Han, YingyaX
> Sent: Tuesday, March 10, 2020 5:04 PM
> To: dts@dpdk.org; Tu, Lijuan <lijuan.tu@intel.com>
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts][PATCH V1 1/2]framework: fix the error of getting vlan value
> 
> Signed-off-by: hanyingya <yingyax.han@intel.com>
> ---
>  framework/pktgen.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/framework/pktgen.py b/framework/pktgen.py index
> 889e94a..404f171 100644
> --- a/framework/pktgen.py
> +++ b/framework/pktgen.py
> @@ -167,7 +167,7 @@ class PacketGeneratorHelper(object):
>                  action = config.get('action') or 'default'
>                  range = config.get('range') or 64
>                  # ignore 'L' suffix
> -                start_vlan = int(pcap_fields.get(layer_name)[:-1])
> +                start_vlan = int(pcap_fields.get(layer_name))
[Lijuan] need consider more, how to deal with w/ or w/o "L" suffix . some scapy version may have "L" suffix, and the other may not have. 
>                  end_vlan = start_vlan + range - 1
>                  fields_config[layer_name][name] = {}
>                  fields_config[layer_name][name]['start'] = start_vlan @@ -212,4
> +212,4 @@ def getPacketGenerator(tester, pktgen_type=PKTGEN_IXIA):
>          return CLS(tester)
>      else:
>          msg = "not support <{0}> packet generator".format(pktgen_type)
> -        raise Exception(msg)
> \ No newline at end of file
> +        raise Exception(msg)
> --
> 2.17.2


      reply	other threads:[~2020-03-11  1:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-10  9:04 hanyingya
2020-03-11  1:31 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBEB7CB@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yingyax.han@intel.com \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).