test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V3 0/1] metrics: add prefix for new frame work
@ 2020-03-04  8:25 yufengmx
  2020-03-04  8:25 ` [dts] [PATCH V3 1/1] " yufengmx
  0 siblings, 1 reply; 4+ messages in thread
From: yufengmx @ 2020-03-04  8:25 UTC (permalink / raw)
  To: dts, yinan.wang, weix.xie; +Cc: yufengmx

 add prefix for new frame work. 

v2: 
 - add missing prefix option. 
 -  

v1: 
 - move option. 

yufengmx (1):
  metrics: add prefix for new frame work.

 tests/TestSuite_metrics.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH V3 1/1] metrics: add prefix for new frame work.
  2020-03-04  8:25 [dts] [PATCH V3 0/1] metrics: add prefix for new frame work yufengmx
@ 2020-03-04  8:25 ` " yufengmx
  2020-03-04  9:13   ` Xie, WeiX
  2020-03-11  4:39   ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: yufengmx @ 2020-03-04  8:25 UTC (permalink / raw)
  To: dts, yinan.wang, weix.xie; +Cc: yufengmx


add prefix for new frame work.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_metrics.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_metrics.py b/tests/TestSuite_metrics.py
index 148365c..7fef17d 100644
--- a/tests/TestSuite_metrics.py
+++ b/tests/TestSuite_metrics.py
@@ -187,7 +187,7 @@ class TestMetrics(TestCase):
         self.is_pmd_on = False
 
     def init_proc_info_tool(self):
-        option = ' -v -- --metrics'
+        option = f' -v --file-prefix={self.prefix} -- --metrics'
         self.dpdk_proc = os.path.join(
             self.target_dir, self.target, "app", "dpdk-procinfo" + option)
         self.metrics_stat = []
@@ -785,6 +785,7 @@ class TestMetrics(TestCase):
     def set_up_all(self):
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 2, "Not enough ports")
+        self.prefix = "dpdk_" + self.dut.prefix_subfix
         # prepare testing environment
         self.preset_test_environment()
 
-- 
2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V3 1/1] metrics: add prefix for new frame work.
  2020-03-04  8:25 ` [dts] [PATCH V3 1/1] " yufengmx
@ 2020-03-04  9:13   ` Xie, WeiX
  2020-03-11  4:39   ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Xie, WeiX @ 2020-03-04  9:13 UTC (permalink / raw)
  To: Mo, YufengX, dts, Wang, Yinan

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


-----Original Message-----
From: Mo, YufengX 
Sent: Wednesday, March 4, 2020 4:26 PM
To: dts@dpdk.org; Wang, Yinan <yinan.wang@intel.com>; Xie, WeiX <weix.xie@intel.com>
Cc: Mo, YufengX <yufengx.mo@intel.com>
Subject: [dts][PATCH V3 1/1] metrics: add prefix for new frame work.


add prefix for new frame work.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 tests/TestSuite_metrics.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_metrics.py b/tests/TestSuite_metrics.py index 148365c..7fef17d 100644
--- a/tests/TestSuite_metrics.py
+++ b/tests/TestSuite_metrics.py
@@ -187,7 +187,7 @@ class TestMetrics(TestCase):
         self.is_pmd_on = False
 
     def init_proc_info_tool(self):
-        option = ' -v -- --metrics'
+        option = f' -v --file-prefix={self.prefix} -- --metrics'
         self.dpdk_proc = os.path.join(
             self.target_dir, self.target, "app", "dpdk-procinfo" + option)
         self.metrics_stat = []
@@ -785,6 +785,7 @@ class TestMetrics(TestCase):
     def set_up_all(self):
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 2, "Not enough ports")
+        self.prefix = "dpdk_" + self.dut.prefix_subfix
         # prepare testing environment
         self.preset_test_environment()
 
--
2.21.0


[-- Attachment #2: TestMetrics.log --]
[-- Type: application/octet-stream, Size: 461340 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH V3 1/1] metrics: add prefix for new frame work.
  2020-03-04  8:25 ` [dts] [PATCH V3 1/1] " yufengmx
  2020-03-04  9:13   ` Xie, WeiX
@ 2020-03-11  4:39   ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2020-03-11  4:39 UTC (permalink / raw)
  To: Mo, YufengX, dts, Wang, Yinan, Xie, WeiX; +Cc: Mo, YufengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of yufengmx
> Sent: Wednesday, March 4, 2020 4:26 PM
> To: dts@dpdk.org; Wang, Yinan <yinan.wang@intel.com>; Xie, WeiX
> <weix.xie@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: [dts] [PATCH V3 1/1] metrics: add prefix for new frame work.
> 
> 
> add prefix for new frame work.
> 
> Signed-off-by: yufengmx <yufengx.mo@intel.com>
> ---
>  tests/TestSuite_metrics.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_metrics.py b/tests/TestSuite_metrics.py index
> 148365c..7fef17d 100644
> --- a/tests/TestSuite_metrics.py
> +++ b/tests/TestSuite_metrics.py
> @@ -187,7 +187,7 @@ class TestMetrics(TestCase):
>          self.is_pmd_on = False
> 
>      def init_proc_info_tool(self):
> -        option = ' -v -- --metrics'
> +        option = f' -v --file-prefix={self.prefix} -- --metrics'
>          self.dpdk_proc = os.path.join(
>              self.target_dir, self.target, "app", "dpdk-procinfo" + option)
>          self.metrics_stat = []
> @@ -785,6 +785,7 @@ class TestMetrics(TestCase):
>      def set_up_all(self):
>          self.dut_ports = self.dut.get_ports(self.nic)
>          self.verify(len(self.dut_ports) >= 2, "Not enough ports")
> +        self.prefix = "dpdk_" + self.dut.prefix_subfix
>          # prepare testing environment
>          self.preset_test_environment()
> 
> --
> 2.21.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-04  8:25 [dts] [PATCH V3 0/1] metrics: add prefix for new frame work yufengmx
2020-03-04  8:25 ` [dts] [PATCH V3 1/1] " yufengmx
2020-03-04  9:13   ` Xie, WeiX
2020-03-11  4:39   ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox