test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>,
	"Wang, Yinan" <yinan.wang@intel.com>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_vm2vm_virtio_net_perf: add two	cases and reduce runtime
Date: Wed, 11 Mar 2020 07:21:42 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBEBB74@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1583397516-362964-1-git-send-email-qimaix.xiao@intel.com>

Could you please review it?

thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Thursday, March 5, 2020 4:39 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_vm2vm_virtio_net_perf: add two
> cases and reduce runtime
> 
> *. add two cases and reduce runtime
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_vm2vm_virtio_net_perf.py | 31
> +++++++++++++++++++++++++------
>  1 file changed, 25 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_vm2vm_virtio_net_perf.py
> b/tests/TestSuite_vm2vm_virtio_net_perf.py
> index cc48905..5b7f3e9 100644
> --- a/tests/TestSuite_vm2vm_virtio_net_perf.py
> +++ b/tests/TestSuite_vm2vm_virtio_net_perf.py
> @@ -88,7 +88,7 @@ class TestVM2VMVirtioNetPerf(TestCase):
>          vdev1 = "--vdev 'net_vhost0,iface=%s/vhost-net0,queues=1%s' " %
> (self.base_dir, zerocopy_arg)
>          vdev2 = "--vdev 'net_vhost1,iface=%s/vhost-net1,queues=1%s' " %
> (self.base_dir, zerocopy_arg)
>          eal_params = self.dut.create_eal_parameters(cores=self.cores_list,
> prefix='vhost', no_pci=True)
> -        para = " -- -i --nb-cores=1 --txd=1024 --rxd=1024"
> +        para = " -- -i --nb-cores=2 --txd=1024 --rxd=1024"
>          self.command_line = testcmd + eal_params + vdev1 + vdev2 + para
>          self.pmd_vhost.execute_cmd(self.command_line, timeout=30)
>          self.pmd_vhost.execute_cmd('start', timeout=30) @@ -118,7 +118,7
> @@ class TestVM2VMVirtioNetPerf(TestCase):
>              vm_info.set_vm_device(**vm_params)
>              time.sleep(3)
>              try:
> -                vm_dut = vm_info.start()
> +                vm_dut = vm_info.start(set_target=False)
>                  if vm_dut is None:
>                      raise Exception("Set up VM ENV failed")
>              except Exception as e:
> @@ -155,12 +155,12 @@ class TestVM2VMVirtioNetPerf(TestCase):
>          # clear the port xstats before iperf
>          self.vhost.send_expect("clear port xstats all", "testpmd> ", 10)
> 
> -        if mode == "tso":
> -            iperf_server = "iperf -s -i 1"
> -            iperf_client = "iperf -c 1.1.1.2 -i 1 -t 30"
> -        elif mode == "ufo":
> +        if mode == "ufo":
>              iperf_server = "iperf -s -u -i 1"
>              iperf_client = "iperf -c 1.1.1.2 -i 1 -t 30 -P 4 -u -b 1G -l 9000"
> +        else:
> +            iperf_server = "iperf -s -i 1"
> +            iperf_client = "iperf -c 1.1.1.2 -i 1 -t 30"
>          self.vm_dut[0].send_expect("%s > iperf_server.log &" % iperf_server, "",
> 10)
>          self.vm_dut[1].send_expect("%s > iperf_client.log &" % iperf_client, "",
> 60)
>          time.sleep(90)
> @@ -273,6 +273,15 @@ class TestVM2VMVirtioNetPerf(TestCase):
>          self.prepare_test_env(zerocopy, path_mode)
>          self.start_iperf_and_verify_vhost_xstats_info(mode="tso")
> 
> +    def test_vm2vm_split_ring_dequeue_zero_copy_with_tso(self):
> +        """
> +        VM2VM split ring vhost-user/virtio-net zero copy test with tcp traffic
> +        """
> +        zerocopy = True
> +        path_mode = "tso"
> +        self.prepare_test_env(zerocopy, path_mode)
> +        self.start_iperf_and_verify_vhost_xstats_info(mode="tso")
> +
>      def test_vm2vm_packed_ring_iperf_with_tso(self):
>          """
>          VM2VM packed ring vhost-user/virtio-net test with tcp traffic @@ -
> 283,6 +292,16 @@ class TestVM2VMVirtioNetPerf(TestCase):
>          self.prepare_test_env(zerocopy, path_mode, packed_mode)
>          self.start_iperf_and_verify_vhost_xstats_info(mode="tso")
> 
> +    def test_vm2vm_packed_ring_dequeue_zero_copy_with_tso(self):
> +        """
> +        VM2VM packed ring vhost-user/virtio-net zero copy test with tcp traffic
> +        """
> +        zerocopy = True
> +        path_mode = "tso"
> +        packed_mode = True
> +        self.prepare_test_env(zerocopy, path_mode, packed_mode)
> +        self.start_iperf_and_verify_vhost_xstats_info(mode="tso")
> +
>      def test_vm2vm_split_ring_iperf_with_ufo(self):
>          """
>          VM2VM split ring vhost-user/virtio-net test with udp traffic
> --
> 1.8.3.1


  parent reply	other threads:[~2020-03-11  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  8:38 Xiao Qimai
2020-03-05  9:12 ` Xiao, QimaiX
2020-03-11  7:21 ` Tu, Lijuan [this message]
2020-03-13 11:05   ` Wang, Yinan
2020-03-17  5:16 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBEBB74@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).