test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Han, YingyaX" <yingyax.han@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Han, YingyaX" <yingyax.han@intel.com>
Subject: Re: [dts] [PATCH V2]tests/nic_single_core: fix tests failed without	saving result
Date: Fri, 13 Mar 2020 06:29:48 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBEC70D@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1583396764-57662-1-git-send-email-yingyax.han@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of hanyingya
> Sent: Thursday, March 5, 2020 4:26 PM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V2]tests/nic_single_core: fix tests failed without saving
> result
> 
> Signed-off-by: hanyingya <yingyax.han@intel.com>
> ---
>  tests/TestSuite_nic_single_core_perf.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_nic_single_core_perf.py
> b/tests/TestSuite_nic_single_core_perf.py
> index 5fafe5f..48a0d8a 100644
> --- a/tests/TestSuite_nic_single_core_perf.py
> +++ b/tests/TestSuite_nic_single_core_perf.py
> @@ -196,8 +196,8 @@ class TestNicSingleCorePerf(TestCase):
>          self.nb_ports = len(self.dut_ports)
>          self.verify(self.nb_ports >= 1, "At least 1 port is required to test")
>          self.perf_test(self.nb_ports)
> -        self.handle_results()
>          self.handle_expected()
> +        self.handle_results()
> 
>      def handle_expected(self):
>          """
> @@ -252,7 +252,7 @@ class TestNicSingleCorePerf(TestCase):
>                  # run packet generator
>                  streams =
> self.pktgen_helper.prepare_stream_from_tginput(tgenInput, 100, vm_config,
> self.tester.pktgen)
>                  # set traffic option
> -                traffic_opt = {'delay': 30}
> +                traffic_opt = {'duration': self.test_duration}
>                  # _, pps = self.tester.traffic_generator_throughput(tgenInput,
> rate_percent=100, delay=30)
>                  _, packets_received =
> self.tester.pktgen.measure_throughput(stream_ids=streams,
> options=traffic_opt)
>                  self.verify(packets_received > 0, "No traffic detected") @@ -348,11
> +348,11 @@ class TestNicSingleCorePerf(TestCase):
>                  row_dict0['parameters'].append(row_dict3)
>                  json_obj[case_name].append(row_dict0)
>                  status_result.append(row_dict0['status'])
> -        self.verify("FAIL" not in status_result, "Excessive gap between test
> results and expectations")
>          with open(os.path.join(rst.path2Result,
>                                 '{0:s}_single_core_perf.json'.format(
>                                     self.nic)), 'w') as fp:
>              json.dump(json_obj, fp)
> +        self.verify("FAIL" not in status_result, "Excessive gap between
> + test results and expectations")
> 
>      def set_fields(self):
>          """
> --
> 2.17.2


      parent reply	other threads:[~2020-03-13  6:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-05  8:26 hanyingya
2020-03-12  8:51 ` Han, YingyaX
2020-03-13  6:29 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBEC70D@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yingyax.han@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).