test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xiao, QimaiX" <qimaix.xiao@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xiao, QimaiX" <qimaix.xiao@intel.com>
Subject: Re: [dts] [PATCH V1]tests/TestSuite_pvp_vhost_user_reconnect: fix	teardown to avoid interfere next case
Date: Fri, 13 Mar 2020 06:52:09 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBEC8D4@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1583907288-75854-1-git-send-email-qimaix.xiao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xiao Qimai
> Sent: Wednesday, March 11, 2020 2:15 PM
> To: dts@dpdk.org
> Cc: Xiao, QimaiX <qimaix.xiao@intel.com>
> Subject: [dts] [PATCH V1]tests/TestSuite_pvp_vhost_user_reconnect: fix
> teardown to avoid interfere next case
> 
> *. fix failed case interferes other cases
> 
> Signed-off-by: Xiao Qimai <qimaix.xiao@intel.com>
> ---
>  tests/TestSuite_pvp_vhost_user_reconnect.py | 14 ++++++++------
>  1 file changed, 8 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/TestSuite_pvp_vhost_user_reconnect.py
> b/tests/TestSuite_pvp_vhost_user_reconnect.py
> index f361373..96ce734 100644
> --- a/tests/TestSuite_pvp_vhost_user_reconnect.py
> +++ b/tests/TestSuite_pvp_vhost_user_reconnect.py
> @@ -320,7 +320,6 @@ class TestPVPVhostUserReconnect(TestCase):
>              self.vm_testpmd_start()
>              self.send_and_verify(vm_cycle, "reconnet from VM")
>          self.result_table_print()
> -        self.stop_all_apps()
> 
>      def test_perf_split_ring_reconnet_two_vms(self):
>          """
> @@ -352,7 +351,6 @@ class TestPVPVhostUserReconnect(TestCase):
>              self.vm_testpmd_start()
>              self.send_and_verify(vm_cycle, "reconnet from VM")
>          self.result_table_print()
> -        self.stop_all_apps()
> 
>      def test_perf_split_ring_vm2vm_virtio_net_reconnet_two_vms(self):
>          """
> @@ -419,7 +417,6 @@ class TestPVPVhostUserReconnect(TestCase):
>              self.vm_testpmd_start()
>              self.send_and_verify(vm_cycle, "reconnet from VM")
>          self.result_table_print()
> -        self.stop_all_apps()
> 
>      def test_perf_packed_ring_reconnet_two_vms(self):
>          """
> @@ -451,7 +448,6 @@ class TestPVPVhostUserReconnect(TestCase):
>              self.vm_testpmd_start()
>              self.send_and_verify(vm_cycle, "reconnet from VM")
>          self.result_table_print()
> -        self.stop_all_apps()
> 
>      def test_perf_packed_ring_virtio_net_reconnet_two_vms(self):
>          """
> @@ -492,12 +488,18 @@ class TestPVPVhostUserReconnect(TestCase):
>          #
>          # Run after each test case.
>          #
> -        self.dut.send_expect("killall -s INT testpmd", "# ")
> -        self.dut.send_expect("killall -s INT qemu-system-x86_64", "# ")
> +        try:
> +            self.stop_all_apps()
> +        except Exception as e:
> +            self.logger.warning(e)
> +        finally:
> +            self.dut.kill_all()
> +            self.dut.send_expect("killall -s INT qemu-system-x86_64", "# ")
>          time.sleep(2)
> 
>      def tear_down_all(self):
>          """
>          Run after each test suite.
>          """
> +        self.dut.kill_all()
>          pass
> --
> 1.8.3.1


      parent reply	other threads:[~2020-03-13  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-11  6:14 Xiao Qimai
2020-03-11  6:23 ` Xiao, QimaiX
2020-03-13  6:52 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBEC8D4@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=qimaix.xiao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).