test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, XinfengX" <xinfengx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, XinfengX" <xinfengx.zhao@intel.com>
Subject: Re: [dts] [PATCH 1/2] framework: modify the method get_session_before
Date: Fri, 20 Mar 2020 08:23:38 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BBEFBB9@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200308152309.46637-1-xinfengx.zhao@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xinfengx
> Sent: Sunday, March 8, 2020 11:23 PM
> To: dts@dpdk.org
> Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
> Subject: [dts] [PATCH 1/2] framework: modify the method
> get_session_before
> 
> Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
> ---
>  framework/ssh_pexpect.py | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py index
> 8889016..e851cbf 100644
> --- a/framework/ssh_pexpect.py
> +++ b/framework/ssh_pexpect.py
> @@ -109,16 +109,11 @@ class SSHPexpect:
>          """
>          ignore_keyintr()
>          self.session.PROMPT = self.magic_prompt
> -        try:
> -            self.session.prompt(timeout)
> -        except Exception as e:
> -            pass
> -
> +        output = self.session.try_read_prompt(timeout)
>          aware_keyintr()
> -        before = self.get_output_all()
>          self.__flush()
> 
> -        return before
> +        return output
> 
>      def __flush(self):
>          """
> --
> 2.17.1


      parent reply	other threads:[~2020-03-20  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-08 15:23 xinfengx
2020-03-08 15:23 ` [dts] [PATCH 2/2] framework: replace unnecessary send_command with send_expect xinfengx
2020-03-11  7:36   ` Zhao, XinfengX
2020-03-20  5:07 ` [dts] [PATCH 1/2] framework: modify the method get_session_before Xiao, QimaiX
2020-03-20  8:23 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BBEFBB9@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=xinfengx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).