test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Jiang, YuX" <yux.jiang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Jiang, YuX" <yux.jiang@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_generic_filter: add sagepond nic
Date: Tue, 21 Apr 2020 03:31:51 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC0DB44@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1587374360-120870-1-git-send-email-yux.jiang@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Jiang, YuX
> Sent: Monday, April 20, 2020 5:19 PM
> To: dts@dpdk.org
> Cc: Jiang, YuX <yux.jiang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_generic_filter: add sagepond nic
> 
> From: "Jiang,yu" <yux.jiang@intel.com>
> 
> Add support sagepond nic, and sagepond does not support test_128_queues
> 
> Signed-off-by: Jiang,yu <yux.jiang@intel.com>
> ---
>  conf/test_case_checklist.json     |  1 +
>  tests/TestSuite_generic_filter.py | 26 +++++++++++++-------------
>  2 files changed, 14 insertions(+), 13 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 44bf8af..f1c3ac0 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -15,6 +15,7 @@
>                  "ironpond",
>                  "springfountain",
>                  "twinpond",
> +                "sagepond",
>                  "kawela_4",
>                  "cavium_a034",
>                  "cavium_a011",
> diff --git a/tests/TestSuite_generic_filter.py
> b/tests/TestSuite_generic_filter.py
> index ddc5eb8..59d7372 100644
> --- a/tests/TestSuite_generic_filter.py
> +++ b/tests/TestSuite_generic_filter.py
> @@ -204,7 +204,7 @@ class TestGeneric_filter(TestCase):
>          """
>          Enable receipt of SYN packets
>          """
> -        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills", "powerville"],
> "%s nic not support syn filter" % self.nic)
> +        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills",
> + "powerville", "sagepond"], "%s nic not support syn filter" % self.nic)
>          self.pmdout.start_testpmd(
>              "%s" % self.cores, "--disable-rss --rxq=4 --txq=4 --portmask=%s --nb-
> cores=4 --nb-ports=1" % portMask)
>          self.port_config()
> @@ -247,7 +247,7 @@ class TestGeneric_filter(TestCase):
>              "%s" % self.cores, "--disable-rss --rxq=4 --txq=4 --portmask=%s --nb-
> cores=4 --nb-ports=1" % portMask)
>          self.port_config()
> 
> -        if self.nic == "niantic":
> +        if self.nic in ["niantic", "sagepond"]:
>              cmd = "5tuple_filter %s add dst_ip 2.2.2.5 src_ip 2.2.2.4 dst_port 1
> src_port 1 protocol 0x06 mask 0x1f tcp_flags 0x0 priority 3 queue 3 " % (
>                  valports[0])
>              self.dut.send_expect("%s" % cmd, "testpmd> ") @@ -307,7 +307,7
> @@ class TestGeneric_filter(TestCase):
>          """
>          five tuple filter
>          """
> -        if self.nic in ["niantic", "kawela_4"]:
> +        if self.nic in ["niantic", "kawela_4", "sagepond"]:
>              self.pmdout.start_testpmd(
>                  "%s" % self.cores, "--disable-rss --rxq=4 --txq=4 --portmask=%s --
> nb-cores=4 --nb-ports=1" % portMask)
>              self.port_config()
> @@ -315,14 +315,14 @@ class TestGeneric_filter(TestCase):
>              mask = ['0x1f', '0x0']
>              for case in mask:
>                  if case == "0x1f":
> -                    if self.nic == "niantic":
> +                    if self.nic in ["niantic", "sagepond"]:
>                          cmd = "5tuple_filter %s add dst_ip 2.2.2.5 src_ip 2.2.2.4
> dst_port 1 src_port 1 protocol 0x06 mask %s tcp_flags 0x0 priority 3 queue
> 3" % (
>                              valports[0], case)
>                      if self.nic == "kawela_4":
>                          cmd = "5tuple_filter %s add dst_ip 2.2.2.5 src_ip 2.2.2.4
> dst_port 1 src_port 1 protocol 0x06 mask %s tcp_flags 0x02 priority 3 queue
> 3" % (
>                              valports[0], case)
>                  else:
> -                    if self.nic == "niantic":
> +                    if self.nic in ["niantic", "sagepond"]:
>                          cmd = "5tuple_filter %s add dst_ip 2.2.2.5 src_ip 2.2.2.4
> dst_port 1 src_port 1 protocol 0x06 mask %s tcp_flags 0x0 priority 3 queue
> 3" % (
>                              valports[0], case)
>                      if self.nic == "kawela_4":
> @@ -345,14 +345,14 @@ class TestGeneric_filter(TestCase):
>                  out = self.dut.send_expect("stop", "testpmd> ")
>                  self.verify_result(out, tx_pkts="1", expect_queue="0")
>                  if case == "0x1f":
> -                    if self.nic == "niantic":
> +                    if self.nic in ["niantic", "sagepond"]:
>                          cmd = "5tuple_filter %s del dst_ip 2.2.2.5 src_ip 2.2.2.4
> dst_port 1 src_port 1 protocol 0x06 mask %s tcp_flags 0x0 priority 3 queue
> 3" % (
>                              valports[0], case)
>                      if self.nic == "kawela_4":
>                          cmd = "5tuple_filter %s del dst_ip 2.2.2.5 src_ip 2.2.2.4
> dst_port 1 src_port 1 protocol 0x06 mask %s tcp_flags 0x02 priority 3 queue
> 3" % (
>                              valports[0], case)
>                  else:
> -                    if self.nic == "niantic":
> +                    if self.nic in ["niantic", "sagepond"]:
>                          cmd = "5tuple_filter %s del dst_ip 2.2.2.5 src_ip 2.2.2.4
> dst_port 1 src_port 1 protocol 0x06 mask %s tcp_flags 0x0 priority 3 queue
> 3" % (
>                              valports[0], case)
>                      if self.nic == "kawela_4":
> @@ -370,7 +370,7 @@ class TestGeneric_filter(TestCase):
> 
>      def test_ethertype_filter(self):
> 
> -        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills",
> +        self.verify(self.nic in ["niantic", "kawela_4", "bartonhills",
> + "sagepond",
>                             "powerville", "fortville_eagle", "fortville_spirit",
>                             "fortville_spirit_single", "fortpark_TLV","fortpark_BASE-T",
> "fortville_25g","cavium_a063", "carlsville"], "%s nic not support syn filter" %
> self.nic)
>          self.pmdout.start_testpmd(
> @@ -395,7 +395,7 @@ class TestGeneric_filter(TestCase):
>          self.dut.send_expect("clear port stats all", "testpmd> ")
> 
>          self.verify_result(out, tx_pkts="1", expect_queue="2")
> -        if self.nic == "niantic":
> +        if self.nic in ["niantic", "sagepond"]:
>              self.dut.send_expect("start", "testpmd> ")
>              self.filter_send_packet("arp_prio")
>              time.sleep(2)
> @@ -417,7 +417,7 @@ class TestGeneric_filter(TestCase):
>          self.verify_result(out, tx_pkts="1", expect_queue="0")
> 
>      def test_multiple_filters_10GB(self):
> -        if self.nic == "niantic":
> +        if self.nic in ["niantic", "sagepond"]:
>              self.pmdout.start_testpmd(
>                  "%s" % self.cores, "--disable-rss --rxq=4 --txq=4 --portmask=%s --
> nb-cores=4 --nb-ports=1" % portMask)
>              self.port_config()
> @@ -501,7 +501,7 @@ class TestGeneric_filter(TestCase):
> 
>      def test_twotuple_filter(self):
> 
> -        if self.nic in ["powerville", "bartonhills", "cavium_a063"]:
> +        if self.nic in ["powerville", "bartonhills", "cavium_a063", "sagepond"]:
>              self.pmdout.start_testpmd(
>                  "%s" % self.cores, "--disable-rss --rxq=4 --txq=4 --portmask=%s --
> nb-cores=4 --nb-ports=1" % portMask)
>              self.port_config()
> @@ -534,7 +534,7 @@ class TestGeneric_filter(TestCase):
>              self.verify(False, "%s nic not support two tuple filter" % self.nic)
> 
>      def test_flex_filter(self):
> -        self.verify(self.nic in ["powerville", "bartonhills", "cavium_a063"], '%s
> not support flex filter' % self.nic)
> +        self.verify(self.nic in ["powerville", "bartonhills",
> + "cavium_a063", "sagepond"], '%s not support flex filter' % self.nic)
> 
>          masks = ['000C', '000C']
>          self.pmdout.start_testpmd(
> @@ -589,7 +589,7 @@ class TestGeneric_filter(TestCase):
> 
>      def test_multiple_filters_1GB(self):
> 
> -        if self.nic in ["powerville", "kawela_4", "bartonhills"]:
> +        if self.nic in ["powerville", "kawela_4", "bartonhills", "sagepond"]:
>              self.pmdout.start_testpmd(
>                  "%s" % self.cores, "--disable-rss --rxq=4 --txq=4 --portmask=%s --
> nb-cores=4 --nb-ports=1" % portMask)
>              self.port_config()
> --
> 2.17.2


      reply	other threads:[~2020-04-21  3:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-20  9:19 Jiang, YuX
2020-04-21  3:31 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC0DB44@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yux.jiang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).