From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F426A00C2; Thu, 23 Apr 2020 10:11:41 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 222BF1D41B; Thu, 23 Apr 2020 10:11:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 79CEC1D419 for ; Thu, 23 Apr 2020 10:11:39 +0200 (CEST) IronPort-SDR: cEUESAfYY1uQRDxsOSmRq93eKuo/FuFNQM6olbvBHd1Ho9714NKPRs9JbNkmQhu+1tRsnwjf0J dmh/0BnOTNkQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2020 01:11:37 -0700 IronPort-SDR: lfGzLS7Jv/AvlAv23JlZ5LPvrJM+/wpfw5O4zGJjIijVhDFevACX846wgKRyM18MbfvYH714Eq kLuAkdbp+1GQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,306,1583222400"; d="scan'208";a="334892810" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 23 Apr 2020 01:11:37 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 01:11:19 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Apr 2020 01:11:19 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.209]) with mapi id 14.03.0439.000; Thu, 23 Apr 2020 16:11:17 +0800 From: "Tu, Lijuan" To: "Zhou, JunX W" , "dts@dpdk.org" CC: "Zhou, JunX W" Thread-Topic: [dts] [PATCH V4] DTS adapts to foxville network card Thread-Index: AQHWGUBNyDEVafga3EqH6zIPVj4BxKiGWv7g Date: Thu, 23 Apr 2020 08:11:16 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC0F3CD@SHSMSX101.ccr.corp.intel.com> References: <1587626291-56898-1-git-send-email-junx.w.zhou@intel.com> In-Reply-To: <1587626291-56898-1-git-send-email-junx.w.zhou@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V4] DTS adapts to foxville network card X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied thanks > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Zhou Jun > Sent: Thursday, April 23, 2020 3:18 PM > To: dts@dpdk.org > Cc: Zhou, JunX W > Subject: [dts] [PATCH V4] DTS adapts to foxville network card >=20 > From: Zhou jun >=20 > Fixed errors caused by patch V2 > 1.pmdrssreta/test_pmdrss_reta testQueues not define > 2.tests/TestSuite_rss_to_rte_flow.py Code format error >=20 > Signed-off-by: Zhou jun > --- > tests/TestSuite_pmdrssreta.py | 1 + > tests/TestSuite_rss_to_rte_flow.py | 32 ++++++++++++++++---------------- > 2 files changed, 17 insertions(+), 16 deletions(-) >=20 > diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.p= y > index 7f77ca9..3595ac5 100644 > --- a/tests/TestSuite_pmdrssreta.py > +++ b/tests/TestSuite_pmdrssreta.py > @@ -212,6 +212,7 @@ class TestPmdrssreta(TestCase): > } >=20 > self.dut.kill_all() > + global testQueues > if self.nic =3D=3D 'foxville': > testQueues =3D [2] > # test with different rss queues diff --git > a/tests/TestSuite_rss_to_rte_flow.py b/tests/TestSuite_rss_to_rte_flow.py > index a6375d0..b345a84 100644 > --- a/tests/TestSuite_rss_to_rte_flow.py > +++ b/tests/TestSuite_rss_to_rte_flow.py > @@ -190,7 +190,7 @@ class TestRSS_to_Rteflow(TestCase): > # Disable RSS hash function > self.dut.send_expect( > "flow create 0 ingress pattern end actions rss types none en= d / end", > "created") > - if self.nic =3D=3D 'foxville': > + if self.nic =3D=3D 'foxville': > self.dut.send_expect("flow flush 0", "testpmd> ") > self.dut.send_expect( > "show port 0 rss-hash", "RSS disabled") @@ -299,7 +299,7 @@ = class > TestRSS_to_Rteflow(TestCase): > self.send_and_check(self.pkt7, rss_queue) > else: > if self.nic =3D=3D 'foxville': > - rss_queue =3D ["1", "2", "3"] > + rss_queue =3D ["1", "2", "3"] > self.send_and_check(self.pkt1, rss_queue) > self.send_and_check(self.pkt2, rss_queue) > self.send_and_check(self.pkt3, rss_queue) @@ -391,7 +391,7 @= @ > class TestRSS_to_Rteflow(TestCase): > self.send_and_check(self.pkt2, rss_queue) > self.send_and_check(self.pkt3, rss_queue) > self.send_and_check(self.pkt6, rss_queue) > - elif(self.nic in ["foxville"]): > + elif(self.nic in ["foxville"]): > rss_queue =3D ["1", "2", "3"] > self.send_and_check(self.pkt2, rss_queue) > self.send_and_check(self.pkt3, rss_queue) @@ -514,14 +514,14= @@ > class TestRSS_to_Rteflow(TestCase): > self.dut.send_expect("start", "testpmd> ", 120) > time.sleep(2) > # Create a rss queue rule > - if self.nic =3D=3D 'foxville': > - self.dut.send_expect( > + if self.nic =3D=3D 'foxville': > + self.dut.send_expect( > "flow create 0 ingress pattern end actions rss types ipv= 6-tcp ipv4- > udp sctp ipv6-other end queues 1 2 3 end / end", "created") > - else: > - self.dut.send_expect( > - "flow create 0 ingress pattern end actions rss types ipv6-t= cp > ipv4-udp sctp ipv6-other end queues 5 6 7 end / end", "created") > + else: > + self.dut.send_expect( > + "flow create 0 ingress pattern end actions rss types > + ipv6-tcp ipv4-udp sctp ipv6-other end queues 5 6 7 end / end", > + "created") > # send the packets and verify the results > - rss_queue =3D ["5", "6", "7"] > + rss_queue =3D ["5", "6", "7"] > if (self.nic in ["fortville_eagle", "fortville_spirit", "carlsvi= lle", > "fortville_spirit_single", "fortpark_TLV","fort= park_BASE-T", > "fortville_25g"]): > self.send_and_check(self.pkt1, rss_queue) @@ -534,8 +534,8 @= @ > class TestRSS_to_Rteflow(TestCase): > self.send_and_check(self.pkt4, rss_queue) > self.send_and_check(self.pkt6, rss_queue) > else: > - if self.nic =3D=3D 'foxville': > - rss_queue =3D ["1", "2", "3"] > + if self.nic =3D=3D 'foxville': > + rss_queue =3D ["1", "2", "3"] > self.send_and_check(self.pkt2, rss_queue) > self.send_and_check(self.pkt7, rss_queue) > rss_queue =3D ["0"] > @@ -570,12 +570,12 @@ class TestRSS_to_Rteflow(TestCase): > time.sleep(2) >=20 > # Create a rss queue rule > - if self.nic =3D=3D 'foxville': > - self.dut.send_expect( > + if self.nic =3D=3D 'foxville': > + self.dut.send_expect( > "flow create 0 ingress pattern end actions rss types udp= end queues > 1 2 3 end / end", "created") > - else: > - self.dut.send_expect( > - "flow create 0 ingress pattern end actions rss types udp en= d > queues 3 4 5 end / end", "created") > + else: > + self.dut.send_expect( > + "flow create 0 ingress pattern end actions rss types > + udp end queues 3 4 5 end / end", "created") > # send the packets and verify the results > rss_queue =3D ["1", "2", "3"] if self.nic =3D=3D 'foxville' else= ["3", "4", "5"] > self.send_and_check(self.pkt2, rss_queue) > -- > 1.8.3.1