test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Wang, Yinan" <yinan.wang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Wang, Yinan" <yinan.wang@intel.com>
Subject: Re: [dts] [PATCH v1] test_plans: add packed ring vectorized cases in	pvp_multi_paths_performance_test_plan
Date: Mon, 27 Apr 2020 07:50:58 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC12A66@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200425212500.23175-1-yinan.wang@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yinan
> Sent: Sunday, April 26, 2020 5:25 AM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: [dts] [PATCH v1] test_plans: add packed ring vectorized cases in
> pvp_multi_paths_performance_test_plan
> 
> From: Wang Yinan <yinan.wang@intel.com>
> 
> Signed-off-by: Wang Yinan <yinan.wang@intel.com>
> ---
>  .../pvp_multi_paths_performance_test_plan.rst | 72 +++++++++----------
>  1 file changed, 34 insertions(+), 38 deletions(-)
> 
> diff --git a/test_plans/pvp_multi_paths_performance_test_plan.rst
> b/test_plans/pvp_multi_paths_performance_test_plan.rst
> index bbb7d0e..c326a20 100644
> --- a/test_plans/pvp_multi_paths_performance_test_plan.rst
> +++ b/test_plans/pvp_multi_paths_performance_test_plan.rst
> @@ -36,13 +36,18 @@ vhost/virtio pvp multi-paths performance test plan
> 
>  Benchmark PVP multi-paths performance with 10 tx/rx paths. Includes
> mergeable, non-mergeable, vectorized_rx,  inorder mergeable, inorder non-
> mergeable, virtio 1.1 mergeable, virtio 1.1 non-mergeable,virtio 1.1 inorder
> -mergeable, virtio 1.1 inorder non-mergeable, virtio1.1 vectorized path.
> -Give 1 core for vhost and virtio respectively.
> -Note: Virtio 1.1 vectorized path need below three initial requirements:
> -    1. AVX512 is allowed in config file and supported by compiler
> -    2. Host cpu support AVX512F
> -    3. ring size is power of two
> -
> +mergeable, virtio 1.1 inorder non-mergeable, virtio1.1 vectorized path. Give
> 1 core for vhost and virtio respectively.
> +
> +Packed ring vectorized path will be selected when:
> +    vectorized option is enabled
> +    AVX512F and required extensions are supported by compiler and host
> +    virtio VERSION_1 and IN_ORDER features are negotiated
> +    virtio mergeable feature is not negotiated
> +    LRO offloading is disabled
> +Split ring vectorized rx path will be selected when:
> +    vectorized option is enabled
> +    virtio mergeable and IN_ORDER features are not negotiated
> +    LRO, chksum and vlan strip offloading are disabled
> 
>  Test flow
>  =========
> @@ -55,7 +60,7 @@ Test Case 1: pvp test with virtio 1.1 mergeable path  1.
> Bind one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-3  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-3 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -63,8 +68,7 @@ Test Case 1: pvp test with virtio 1.1 mergeable path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
>      --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=1,in_order=0 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
> @@ -80,7 +84,7 @@ Test Case 2: pvp test with virtio 1.1 non-mergeable path
> 1. Bind one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-3  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-3 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -88,8 +92,7 @@ Test Case 2: pvp test with virtio 1.1 non-mergeable path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
>      --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=0,in_order=0 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
> @@ -105,7 +108,7 @@ Test Case 3: pvp test with inorder mergeable path  1.
> Bind one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-3  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-3 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -113,9 +116,8 @@ Test Case 3: pvp test with inorder mergeable path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=1 \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,mrg_rxb
> + uf=1,in_order=1 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
>      >start
> @@ -130,7 +132,7 @@ Test Case 4: pvp test with inorder non-mergeable
> path  1. Bind one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-4 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -138,8 +140,7 @@ Test Case 4: pvp test with inorder non-mergeable
> path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
>      --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=1,mrg_rxbuf=0 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
> @@ -155,7 +156,7 @@ Test Case 5: pvp test with mergeable path  1. Bind
> one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-4 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -163,8 +164,7 @@ Test Case 5: pvp test with mergeable path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
>      --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=1 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
> @@ -180,7 +180,7 @@ Test Case 6: pvp test with non-mergeable path  1.
> Bind one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-4 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -188,9 +188,8 @@ Test Case 6: pvp test with non-mergeable path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0 \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_orde
> + r=0,mrg_rxbuf=0,vectorized=1 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
>      >start
> @@ -205,7 +204,7 @@ Test Case 7: pvp test with vectorized_rx path  1. Bind
> one port to igb_uio, then launch vhost by below command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-4  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-4 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -213,9 +212,8 @@ Test Case 7: pvp test with vectorized_rx path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,in_order=0,mrg_rxbuf=0 \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,in_orde
> + r=0,mrg_rxbuf=0,vectorized=1 \
>      -- -i --tx-offloads=0x0 --nb-cores=1 --txd=1024 --rxd=1024
>      >set fwd mac
>      >start
> @@ -230,7 +228,7 @@ Test Case 8: pvp test with virtio 1.1 inorder
> mergeable path  1. Bind one port to igb_uio, then launch vhost by below
> command::
> 
>      rm -rf vhost-net*
> -    ./testpmd -n 4 -l 2-3  --socket-mem 1024,1024 --legacy-mem \
> +    ./testpmd -n 4 -l 2-3 \
>      --file-prefix=vhost --vdev 'net_vhost0,iface=vhost-net,queues=1,client=0' \
>      -- -i --nb-cores=1 --txd=1024 --rxd=1024
>      testpmd>set fwd mac
> @@ -238,8 +236,7 @@ Test Case 8: pvp test with virtio 1.1 inorder
> mergeable path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
>      --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=1,in_order=1 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
> @@ -264,7 +261,7 @@ Test Case 9: pvp test with virtio 1.1 inorder non-
> mergeable path  2. Launch virtio-user by below command::
> 
>      ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=0,in_order=1,packed_vec=1 \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_
> + vq=1,mrg_rxbuf=0,in_order=1,vectorized=1 \
>      -- -i --rx-offloads=0x10 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
>      >start
> @@ -286,9 +283,8 @@ Test Case 10: pvp test with virtio 1.1 vectorized path
> 
>  2. Launch virtio-user by below command::
> 
> -    ./testpmd -n 4 -l 5-6 --socket-mem 1024,1024 \
> -    --legacy-mem --no-pci --file-prefix=virtio \
> -    --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-
> net,packed_vq=1,mrg_rxbuf=0,in_order=1,packed_vec=1 \
> +    ./testpmd -n 4 -l 5-6 --no-pci --file-prefix=virtio \
> +
> + --vdev=net_virtio_user0,mac=00:01:02:03:04:05,path=./vhost-net,packed_
> + vq=1,mrg_rxbuf=0,in_order=1,vectorized=1 \
>      -- -i --tx-offloads=0x0 --enable-hw-vlan-strip --nb-cores=1 --txd=1024 --
> rxd=1024
>      >set fwd mac
>      >start
> --
> 2.17.1


      reply	other threads:[~2020-04-27  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-25 21:25 Yinan
2020-04-27  7:50 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC12A66@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yinan.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).