test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH v1] tests: add performance check in TestSuite_virtio_user_as_exceptional_path.py
@ 2020-05-12 18:03 Yinan
  2020-05-19  1:56 ` Tu, Lijuan
  0 siblings, 1 reply; 2+ messages in thread
From: Yinan @ 2020-05-12 18:03 UTC (permalink / raw)
  To: dts; +Cc: Wang Yinan

From: Wang Yinan <yinan.wang@intel.com>

Signed-off-by: Wang Yinan <yinan.wang@intel.com>
---
 .../TestSuite_virtio_user_as_exceptional_path.py | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/tests/TestSuite_virtio_user_as_exceptional_path.py b/tests/TestSuite_virtio_user_as_exceptional_path.py
index faf8c49..262db75 100644
--- a/tests/TestSuite_virtio_user_as_exceptional_path.py
+++ b/tests/TestSuite_virtio_user_as_exceptional_path.py
@@ -197,7 +197,7 @@ class TestVirtioUserAsExceptionalPath(TestCase):
         self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
         self.dut.build_install_dpdk(self.dut.target)
 
-    def iperf_result_verify(self, vm_client):
+    def iperf_result_verify(self, vm_client, direction):
         '''
         Get the iperf test result
         '''
@@ -205,7 +205,15 @@ class TestVirtioUserAsExceptionalPath(TestCase):
         print(fmsg)
         iperfdata = re.compile('[\d+]*.[\d+]* [M|G]bits/sec').findall(fmsg)
         print(iperfdata)
-        self.verify(iperfdata, 'There no data about this case')
+        data_str = iperfdata[-1].split()
+        data=iperfdata[-1].split()[0]
+        unit=iperfdata[-1].split()[1]
+        if direction == "direction_TAP_original":
+            self.verify(unit =="Gbits/sec", 'The unit of throughput is not Gbits/sec')
+            self.verify(float(data) > 4.0, 'No data or bandwith not achieve target value 3Gbits/sec about this case')
+        elif direction == "direction_NIC_original":
+            self.verify(unit =="Gbits/sec", 'The unit of throughput is not Gbits/sec')
+            self.verify(float(data) > 2.0, 'No data or bandwith not achieve target value 3Gbits/sec about this case')
         self.result_table_create(['Data', 'Unit'])
         results_row = ['exception path']
         results_row.append(iperfdata[-1])
@@ -258,7 +266,7 @@ class TestVirtioUserAsExceptionalPath(TestCase):
         self.iperf.send_expect('iperf -c 1.1.1.8 -i 1 -t 10 > /root/iperf_client.log &', '', 180)
         time.sleep(30)
         self.dut.send_expect('^C', '#', 10)
-        self.iperf_result_verify(self.iperf)
+        self.iperf_result_verify(self.iperf, "direction_TAP_original")
         self.logger.info("TAP->virtio-user->Kernel_NIC %s " % (self.output_result))
         self.iperf.send_expect('rm /root/iperf_client.log', '#', 10)
         self.vhost_user.send_expect("quit", "#", 120)
@@ -280,7 +288,7 @@ class TestVirtioUserAsExceptionalPath(TestCase):
         self.dut.send_expect('ip netns exec ns1 iperf -c 1.1.1.2 -i 1 -t 10 > /root/iperf_client.log &', '', 10)
         time.sleep(30)
         self.iperf.send_expect('^C', '#', 10)
-        self.iperf_result_verify(self.dut)
+        self.iperf_result_verify(self.dut, "direction_NIC_original")
         self.dut.get_session_output(timeout=2)
         self.logger.info("Kernel_NIC<-virtio-user<-TAP %s " % (self.output_result))
         self.dut.send_expect('rm /root/iperf_client.log', '#', 10)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dts] [PATCH v1] tests: add performance check in TestSuite_virtio_user_as_exceptional_path.py
  2020-05-12 18:03 [dts] [PATCH v1] tests: add performance check in TestSuite_virtio_user_as_exceptional_path.py Yinan
@ 2020-05-19  1:56 ` Tu, Lijuan
  0 siblings, 0 replies; 2+ messages in thread
From: Tu, Lijuan @ 2020-05-19  1:56 UTC (permalink / raw)
  To: Wang, Yinan, dts; +Cc: Wang, Yinan

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yinan
> Sent: Wednesday, May 13, 2020 2:04 AM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>
> Subject: [dts] [PATCH v1] tests: add performance check in
> TestSuite_virtio_user_as_exceptional_path.py
> 
> From: Wang Yinan <yinan.wang@intel.com>
> 
> Signed-off-by: Wang Yinan <yinan.wang@intel.com>
> ---
>  .../TestSuite_virtio_user_as_exceptional_path.py | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/TestSuite_virtio_user_as_exceptional_path.py
> b/tests/TestSuite_virtio_user_as_exceptional_path.py
> index faf8c49..262db75 100644
> --- a/tests/TestSuite_virtio_user_as_exceptional_path.py
> +++ b/tests/TestSuite_virtio_user_as_exceptional_path.py
> @@ -197,7 +197,7 @@ class TestVirtioUserAsExceptionalPath(TestCase):
>          self.dut.send_expect("rm -rf ./app/test-pmd/csumonly_backup.c", "#")
>          self.dut.build_install_dpdk(self.dut.target)
> 
> -    def iperf_result_verify(self, vm_client):
> +    def iperf_result_verify(self, vm_client, direction):
>          '''
>          Get the iperf test result
>          '''
> @@ -205,7 +205,15 @@ class TestVirtioUserAsExceptionalPath(TestCase):
>          print(fmsg)
>          iperfdata = re.compile('[\d+]*.[\d+]* [M|G]bits/sec').findall(fmsg)
>          print(iperfdata)
> -        self.verify(iperfdata, 'There no data about this case')
> +        data_str = iperfdata[-1].split()
> +        data=iperfdata[-1].split()[0]
> +        unit=iperfdata[-1].split()[1]
> +        if direction == "direction_TAP_original":
> +            self.verify(unit =="Gbits/sec", 'The unit of throughput is not
> Gbits/sec')
> +            self.verify(float(data) > 4.0, 'No data or bandwith not achieve target
> value 3Gbits/sec about this case')
> +        elif direction == "direction_NIC_original":
> +            self.verify(unit =="Gbits/sec", 'The unit of throughput is not
> Gbits/sec')
> +            self.verify(float(data) > 2.0, 'No data or bandwith not
> + achieve target value 3Gbits/sec about this case')
>          self.result_table_create(['Data', 'Unit'])
>          results_row = ['exception path']
>          results_row.append(iperfdata[-1]) @@ -258,7 +266,7 @@ class
> TestVirtioUserAsExceptionalPath(TestCase):
>          self.iperf.send_expect('iperf -c 1.1.1.8 -i 1 -t 10 > /root/iperf_client.log
> &', '', 180)
>          time.sleep(30)
>          self.dut.send_expect('^C', '#', 10)
> -        self.iperf_result_verify(self.iperf)
> +        self.iperf_result_verify(self.iperf, "direction_TAP_original")
>          self.logger.info("TAP->virtio-user->Kernel_NIC %s " %
> (self.output_result))
>          self.iperf.send_expect('rm /root/iperf_client.log', '#', 10)
>          self.vhost_user.send_expect("quit", "#", 120) @@ -280,7 +288,7 @@
> class TestVirtioUserAsExceptionalPath(TestCase):
>          self.dut.send_expect('ip netns exec ns1 iperf -c 1.1.1.2 -i 1 -t 10 >
> /root/iperf_client.log &', '', 10)
>          time.sleep(30)
>          self.iperf.send_expect('^C', '#', 10)
> -        self.iperf_result_verify(self.dut)
> +        self.iperf_result_verify(self.dut, "direction_NIC_original")
>          self.dut.get_session_output(timeout=2)
>          self.logger.info("Kernel_NIC<-virtio-user<-TAP %s " %
> (self.output_result))
>          self.dut.send_expect('rm /root/iperf_client.log', '#', 10)
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 18:03 [dts] [PATCH v1] tests: add performance check in TestSuite_virtio_user_as_exceptional_path.py Yinan
2020-05-19  1:56 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox