test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop
@ 2020-05-14 18:37 xinfengx
  2020-05-15  2:11 ` Zhao, XinfengX
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: xinfengx @ 2020-05-14 18:37 UTC (permalink / raw)
  To: dts; +Cc: xinfengx

Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
---
 tests/TestSuite_crypto_perf_cryptodev_perf.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py b/tests/TestSuite_crypto_perf_cryptodev_perf.py
index defb7c2..910c81a 100644
--- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
+++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
@@ -71,6 +71,11 @@ class PerfTestsCryptodev(TestCase):
         }
         self._app_path = "./x86_64-native-linuxapp-gcc/build/app/test-crypto-perf/dpdk-test-crypto-perf"
 
+        page_size = self.dut.send_expect("awk '/Hugepagesize/ {print $2}' /proc/meminfo", "# ")
+        if int(page_size) == 1024 * 1024:
+            self.dut.send_expect('echo 0 > /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), '# ', 5)
+            self.dut.send_expect('echo 16 > /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), '# ', 5)
+
         if not cc.is_build_skip(self):
             cc.build_dpdk_with_cryptodev(self)
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop
  2020-05-14 18:37 [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop xinfengx
@ 2020-05-15  2:11 ` Zhao, XinfengX
  2020-05-19  1:53 ` Tu, Lijuan
  2020-05-19  2:36 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Zhao, XinfengX @ 2020-05-15  2:11 UTC (permalink / raw)
  To: dts

Tested-by:  Zhao, Xinfeng<xinfengx.zhao@intel.com>

-----Original Message-----
From: Zhao, XinfengX 
Sent: Friday, May 15, 2020 2:38 AM
To: dts@dpdk.org
Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
Subject: [dts][PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop

Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
---
 tests/TestSuite_crypto_perf_cryptodev_perf.py | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py b/tests/TestSuite_crypto_perf_cryptodev_perf.py
index defb7c2..910c81a 100644
--- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
+++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
@@ -71,6 +71,11 @@ class PerfTestsCryptodev(TestCase):
         }
         self._app_path = "./x86_64-native-linuxapp-gcc/build/app/test-crypto-perf/dpdk-test-crypto-perf"
 
+        page_size = self.dut.send_expect("awk '/Hugepagesize/ {print $2}' /proc/meminfo", "# ")
+        if int(page_size) == 1024 * 1024:
+            self.dut.send_expect('echo 0 > /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), '# ', 5)
+            self.dut.send_expect('echo 16 > /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), '# ', 5)
+
         if not cc.is_build_skip(self):
             cc.build_dpdk_with_cryptodev(self)
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop
  2020-05-14 18:37 [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop xinfengx
  2020-05-15  2:11 ` Zhao, XinfengX
@ 2020-05-19  1:53 ` Tu, Lijuan
  2020-05-19  2:20   ` Zhao, XinfengX
  2020-05-19  2:36 ` Tu, Lijuan
  2 siblings, 1 reply; 5+ messages in thread
From: Tu, Lijuan @ 2020-05-19  1:53 UTC (permalink / raw)
  To: Zhao, XinfengX, dts; +Cc: Zhao, XinfengX

Why do you add this? Is there anyone occupied many hugepages and don't release them?

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xinfengx
> Sent: Friday, May 15, 2020 2:38 AM
> To: dts@dpdk.org
> Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
> Subject: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev
> perf drop
> 
> Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
> ---
>  tests/TestSuite_crypto_perf_cryptodev_perf.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py
> b/tests/TestSuite_crypto_perf_cryptodev_perf.py
> index defb7c2..910c81a 100644
> --- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
> +++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
> @@ -71,6 +71,11 @@ class PerfTestsCryptodev(TestCase):
>          }
>          self._app_path = "./x86_64-native-linuxapp-gcc/build/app/test-crypto-
> perf/dpdk-test-crypto-perf"
> 
> +        page_size = self.dut.send_expect("awk '/Hugepagesize/ {print $2}'
> /proc/meminfo", "# ")
> +        if int(page_size) == 1024 * 1024:
> +            self.dut.send_expect('echo 0 >
> /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size),
> '# ', 5)
> +            self.dut.send_expect('echo 16 >
> /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size),
> '# ', 5)
> +
>          if not cc.is_build_skip(self):
>              cc.build_dpdk_with_cryptodev(self)
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop
  2020-05-19  1:53 ` Tu, Lijuan
@ 2020-05-19  2:20   ` Zhao, XinfengX
  0 siblings, 0 replies; 5+ messages in thread
From: Zhao, XinfengX @ 2020-05-19  2:20 UTC (permalink / raw)
  To: Tu, Lijuan, dts

There is enough hugepage left, but the perf of scheduler+qat dropped.

and add this action, the issue disappeared.

-----Original Message-----
From: Tu, Lijuan 
Sent: Tuesday, May 19, 2020 9:53 AM
To: Zhao, XinfengX <xinfengx.zhao@intel.com>; dts@dpdk.org
Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
Subject: RE: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop

Why do you add this? Is there anyone occupied many hugepages and don't release them?

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xinfengx
> Sent: Friday, May 15, 2020 2:38 AM
> To: dts@dpdk.org
> Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
> Subject: [dts] [PATCH] tests: clean and reset the hugepages to fix 
> cryptodev perf drop
> 
> Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
> ---
>  tests/TestSuite_crypto_perf_cryptodev_perf.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py
> b/tests/TestSuite_crypto_perf_cryptodev_perf.py
> index defb7c2..910c81a 100644
> --- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
> +++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
> @@ -71,6 +71,11 @@ class PerfTestsCryptodev(TestCase):
>          }
>          self._app_path = 
> "./x86_64-native-linuxapp-gcc/build/app/test-crypto-
> perf/dpdk-test-crypto-perf"
> 
> +        page_size = self.dut.send_expect("awk '/Hugepagesize/ {print $2}'
> /proc/meminfo", "# ")
> +        if int(page_size) == 1024 * 1024:
> +            self.dut.send_expect('echo 0 >
> /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), 
> '# ', 5)
> +            self.dut.send_expect('echo 16 >
> /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size), 
> '# ', 5)
> +
>          if not cc.is_build_skip(self):
>              cc.build_dpdk_with_cryptodev(self)
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop
  2020-05-14 18:37 [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop xinfengx
  2020-05-15  2:11 ` Zhao, XinfengX
  2020-05-19  1:53 ` Tu, Lijuan
@ 2020-05-19  2:36 ` Tu, Lijuan
  2 siblings, 0 replies; 5+ messages in thread
From: Tu, Lijuan @ 2020-05-19  2:36 UTC (permalink / raw)
  To: Zhao, XinfengX, dts; +Cc: Zhao, XinfengX

Applied, thanks

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xinfengx
> Sent: Friday, May 15, 2020 2:38 AM
> To: dts@dpdk.org
> Cc: Zhao, XinfengX <xinfengx.zhao@intel.com>
> Subject: [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev
> perf drop
> 
> Signed-off-by: xinfengx <xinfengx.zhao@intel.com>
> ---
>  tests/TestSuite_crypto_perf_cryptodev_perf.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py
> b/tests/TestSuite_crypto_perf_cryptodev_perf.py
> index defb7c2..910c81a 100644
> --- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
> +++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
> @@ -71,6 +71,11 @@ class PerfTestsCryptodev(TestCase):
>          }
>          self._app_path = "./x86_64-native-linuxapp-gcc/build/app/test-crypto-
> perf/dpdk-test-crypto-perf"
> 
> +        page_size = self.dut.send_expect("awk '/Hugepagesize/ {print $2}'
> /proc/meminfo", "# ")
> +        if int(page_size) == 1024 * 1024:
> +            self.dut.send_expect('echo 0 >
> /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size),
> '# ', 5)
> +            self.dut.send_expect('echo 16 >
> /sys/kernel/mm/hugepages/hugepages-%skB/nr_hugepages' % (page_size),
> '# ', 5)
> +
>          if not cc.is_build_skip(self):
>              cc.build_dpdk_with_cryptodev(self)
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, back to index

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-14 18:37 [dts] [PATCH] tests: clean and reset the hugepages to fix cryptodev perf drop xinfengx
2020-05-15  2:11 ` Zhao, XinfengX
2020-05-19  1:53 ` Tu, Lijuan
2020-05-19  2:20   ` Zhao, XinfengX
2020-05-19  2:36 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox