test suite reviews and discussions
 help / color / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1] tests/port_control:change vm dpdk driver from	igb_uio to vfio-pci
Date: Wed, 1 Jul 2020 06:05:07 +0000
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC68068@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200629073031.7689-1-weix.xie@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: 2020^[$BG/^[(B6^[$B7n^[(B29^[$BF|^[(B 15:31
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/port_control:change vm dpdk driver from
> igb_uio to vfio-pci
> 
> Change driver to vfio-pci on vm. Add param '--vfio-intr=legacy' to fix port link
> status still down issue, add some time to wait link status up.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_port_control.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_port_control.py b/tests/TestSuite_port_control.py
> index 1a588d3..147dc80 100644
> --- a/tests/TestSuite_port_control.py
> +++ b/tests/TestSuite_port_control.py
> @@ -157,8 +157,8 @@ class TestPortControl(TestCase):
>          terminal.send_expect("ifconfig %s hw ether %s" % (vf_if[1], self.vf_mac),
> "#")
>          terminal.send_expect("ifconfig %s up" % vf_if[1], "#")
>          terminal.send_expect("ip addr flush %s " % vf_if[1], "#")
> -        terminal.send_expect("./usertools/dpdk-devbind.py -b igb_uio --force %s" %
> vf_pci[1], "#")
> -        cmd = "./%s/app/testpmd -n 1 -w %s -- -i" % (self.target, vf_pci[1])
> +        terminal.send_expect("./usertools/dpdk-devbind.py -b vfio-pci --force %s" %
> vf_pci[1], "#")
> +        cmd = "./%s/app/testpmd -n 1 -w %s --vfio-intr=legacy -- -i" %
> + (self.target, vf_pci[1])
>          terminal.send_expect(cmd, "testpmd>", 10)
> 
>      def start_testpmd(self, terminal):
> @@ -171,6 +171,7 @@ class TestPortControl(TestCase):
>      def start_pmd_port(self, terminal):
>          terminal.execute_cmd("port start all")
>          terminal.execute_cmd("start")
> +        time.sleep(5)
>          terminal.wait_link_status_up('all', timeout=5)
>          ret = terminal.get_port_link_status(self.port_id_0)
>          self.verify(ret == "up", "port not up!")
> --
> 2.17.1


      parent reply index

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-29  7:30 Xie wei
2020-06-29  7:55 ` Xie, WeiX
2020-06-30 12:15   ` [dts] [PATCH] " lihong
2020-06-30 12:19 ` lihong
2020-07-01  6:05 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC68068@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox