test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1] tests/kernelpf_iavf: destory env need remove to	run after this case
Date: Thu, 2 Jul 2020 07:17:45 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC68DAA@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200701093040.3820-1-weix.xie@intel.com>

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: 2020年7月1日 17:31
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/kernelpf_iavf: destory env need remove to run
> after this case
> 
> If vf_rx_interrupt verified failed, it can't restore env and influence after cases.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_kernelpf_iavf.py | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
> index fd48fa2..6fb1bae 100644
> --- a/tests/TestSuite_kernelpf_iavf.py
> +++ b/tests/TestSuite_kernelpf_iavf.py
> @@ -891,9 +891,6 @@ class TestKernelpfIavf(TestCase):
>          self.verify('L3FWD_POWER: lcore 6 is waked up from rx interrupt' in out,
> 'lcore 6 is not waked up')
>          self.verify('L3FWD_POWER: lcore 7 is waked up from rx interrupt' in out,
> 'lcore 7 is not waked up')
>          self.dut.send_expect("killall l3fwd-power", "# ", 60, alt_session=True)
> -        self.interrupt_flag = True
> -        time.sleep(1)
> -        self.destroy_2vf_in_2pf()
> 
>      def test_vf_unicast(self):
>          self.vm_testpmd.start_testpmd("all")
> @@ -984,8 +981,9 @@ class TestKernelpfIavf(TestCase):
>          """
>          Run after each test case.
>          """
> -        if self.interrupt_flag is True:
> -            self.interrupt_flag = False
> +        if self.running_case == "test_vf_rx_interrupt"::
> +            self.dut.send_expect("killall l3fwd-power", "# ", 60, alt_session=True)
> +            self.destroy_2vf_in_2pf()
>          else:
>              self.vm_testpmd.execute_cmd("quit", "#")
>              time.sleep(1)
> --
> 2.17.1


      reply	other threads:[~2020-07-02  7:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  9:30 Xie wei
2020-07-02  7:17 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20E0BC68DAA@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).