test suite reviews and discussions
 help / color / Atom feed
* [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card
@ 2020-07-02  3:35 ChenBo
  2020-07-02  7:19 ` Chen, BoX C
  2020-07-02  7:19 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: ChenBo @ 2020-07-02  3:35 UTC (permalink / raw)
  To: dts; +Cc: ChenBo

Update unsupported NIC, and delete code that will not be executed.

Signed-off-by: ChenBo <box.c.chen@intel.com>
---
 conf/test_case_checklist.json | 1 +
 tests/TestSuite_dual_vlan.py  | 8 --------
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index 493f403..d475229 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -288,6 +288,7 @@
                 "fortville_eagle",
                 "fortville_spirit",
                 "fortville_spirit_single",
+                "foxville",
                 "powerville",
                 "kawela_4",
                 "springville",
diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index daa23d3..855769c 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -342,14 +342,10 @@ class TestDualVlan(TestCase):
         """
         Enable/Disable VLAN packets strip on queue
         """
-        self.verify(self.nic not in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV","fortpark_BASE-T", "cavium_a063", "cavium_a064", "carlsville"], "%s NIC not support queue vlan strip " % self.nic)
-
         self.mode_config(filter="off")
         self.mode_config(extend="off")
         self.mode_config(strip="off")
         self.mode_config(stripq="off")
-        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]:
-            self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId), "testpmd> ") 
         self.vlan_send_packet(outvlan)
         out = self.get_tcpdump_package()
         self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " + out)
@@ -361,13 +357,9 @@ class TestDualVlan(TestCase):
         self.verify("vlan %s" % outvlan not in out, "vlan strip enable error: " + out)
 
         self.mode_config(stripq="off")
-        if self.nic == 'foxville':
-            self.mode_config(strip="off")
         self.vlan_send_packet(outvlan)
         out = self.get_tcpdump_package()
         self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " + out)
-        if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "fortpark_TLV","fortpark_BASE-T" "carlsville"]:
-            self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId), "testpmd> ")
 
     def test_vlan_insert_config(self):
         """
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card
  2020-07-02  3:35 [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card ChenBo
  2020-07-02  7:19 ` Chen, BoX C
@ 2020-07-02  7:19 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-07-02  7:19 UTC (permalink / raw)
  To: Chen, BoX C, dts; +Cc: Chen, BoX C

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of ChenBo
> Sent: 2020^[$BG/^[(B7^[$B7n^[(B2^[$BF|^[(B 11:36
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card
> 
> Update unsupported NIC, and delete code that will not be executed.
> 
> Signed-off-by: ChenBo <box.c.chen@intel.com>
> ---
>  conf/test_case_checklist.json | 1 +
>  tests/TestSuite_dual_vlan.py  | 8 --------
>  2 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json index
> 493f403..d475229 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -288,6 +288,7 @@
>                  "fortville_eagle",
>                  "fortville_spirit",
>                  "fortville_spirit_single",
> +                "foxville",
>                  "powerville",
>                  "kawela_4",
>                  "springville",
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py index
> daa23d3..855769c 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -342,14 +342,10 @@ class TestDualVlan(TestCase):
>          """
>          Enable/Disable VLAN packets strip on queue
>          """
> -        self.verify(self.nic not in ["columbiaville_25g", "columbiaville_100g",
> "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV","fortpark_BASE-T", "cavium_a063", "cavium_a064", "carlsville"],
> "%s NIC not support queue vlan strip " % self.nic)
> -
>          self.mode_config(filter="off")
>          self.mode_config(extend="off")
>          self.mode_config(strip="off")
>          self.mode_config(stripq="off")
> -        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]:
> -            self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " +
> out) @@ -361,13 +357,9 @@ class TestDualVlan(TestCase):
>          self.verify("vlan %s" % outvlan not in out, "vlan strip enable error: " + out)
> 
>          self.mode_config(stripq="off")
> -        if self.nic == 'foxville':
> -            self.mode_config(strip="off")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " + out)
> -        if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV","fortpark_BASE-T" "carlsville"]:
> -            self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
> 
>      def test_vlan_insert_config(self):
>          """
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card
  2020-07-02  3:35 [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card ChenBo
@ 2020-07-02  7:19 ` Chen, BoX C
  2020-07-02  7:19 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Chen, BoX C @ 2020-07-02  7:19 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 3162 bytes --]

Tested-by:  Chen, BoX C <BoX.C.Chen@intel.com>

Regards,
Chen Bo

> -----Original Message-----
> From: Chen, BoX C <box.c.chen@intel.com>
> Sent: July 2, 2020 11:36
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts][PATCH V2] tests/dual_vlan: Update unsupported network card
> 
> Update unsupported NIC, and delete code that will not be executed.
> 
> Signed-off-by: ChenBo <box.c.chen@intel.com>
> ---
>  conf/test_case_checklist.json | 1 +
>  tests/TestSuite_dual_vlan.py  | 8 --------
>  2 files changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
> index 493f403..d475229 100644
> --- a/conf/test_case_checklist.json
> +++ b/conf/test_case_checklist.json
> @@ -288,6 +288,7 @@
>                  "fortville_eagle",
>                  "fortville_spirit",
>                  "fortville_spirit_single",
> +                "foxville",
>                  "powerville",
>                  "kawela_4",
>                  "springville",
> diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
> index daa23d3..855769c 100644
> --- a/tests/TestSuite_dual_vlan.py
> +++ b/tests/TestSuite_dual_vlan.py
> @@ -342,14 +342,10 @@ class TestDualVlan(TestCase):
>          """
>          Enable/Disable VLAN packets strip on queue
>          """
> -        self.verify(self.nic not in ["columbiaville_25g", "columbiaville_100g",
> "fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV","fortpark_BASE-T", "cavium_a063", "cavium_a064",
> "carlsville"], "%s NIC not support queue vlan strip " % self.nic)
> -
>          self.mode_config(filter="off")
>          self.mode_config(extend="off")
>          self.mode_config(strip="off")
>          self.mode_config(stripq="off")
> -        if self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single",
> "fortville_25g", "fortpark_TLV", "fortpark_BASE-T","carlsville"]:
> -            self.dut.send_expect('rx_vlan add %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error : " +
> out) @@ -361,13 +357,9 @@ class TestDualVlan(TestCase):
>          self.verify("vlan %s" % outvlan not in out, "vlan strip enable error: " + out)
> 
>          self.mode_config(stripq="off")
> -        if self.nic == 'foxville':
> -            self.mode_config(strip="off")
>          self.vlan_send_packet(outvlan)
>          out = self.get_tcpdump_package()
>          self.verify("vlan %s" % outvlan in out, "vlan strip queue disable error: " +
> out)
> -        if self.nic in ["columbiaville_25g", "columbiaville_100g", "fortville_eagle",
> "fortville_spirit", "fortville_spirit_single", "fortville_25g",
> "fortpark_TLV","fortpark_BASE-T" "carlsville"]:
> -            self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId),
> "testpmd> ")
> 
>      def test_vlan_insert_config(self):
>          """
> --
> 2.17.1


[-- Attachment #2: TestDualVlan.log --]
[-- Type: application/octet-stream, Size: 915543 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-02  3:35 [dts] [PATCH V2] tests/dual_vlan: Update unsupported network card ChenBo
2020-07-02  7:19 ` Chen, BoX C
2020-07-02  7:19 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox