From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32339A0540; Mon, 20 Jul 2020 08:55:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 25D711BEE3; Mon, 20 Jul 2020 08:55:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B4BB31BEBF for ; Mon, 20 Jul 2020 08:55:30 +0200 (CEST) IronPort-SDR: u151gjNV+yN7p8XLfRpjR8WLxPbBsoDCGaQmaM8GrysrrKGUuu0NTjNjZd1Fpihdlc18OwHzYf Ku4byupjEdOA== X-IronPort-AV: E=McAfee;i="6000,8403,9687"; a="151207509" X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="151207509" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2020 23:55:29 -0700 IronPort-SDR: uHP4MWLBo160wbTJ4SWfnCH9uiC7VqeYi0CUiGTkJrcinjvE2zM8JwAzTitLFsetsJLHJA477n uq9WKbwZin8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,374,1589266800"; d="scan'208";a="301187395" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga002.jf.intel.com with ESMTP; 19 Jul 2020 23:55:29 -0700 Received: from fmsmsx104.amr.corp.intel.com (10.18.124.202) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 19 Jul 2020 23:55:29 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 19 Jul 2020 23:55:28 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.22]) by shsmsx102.ccr.corp.intel.com ([169.254.2.43]) with mapi id 14.03.0439.000; Mon, 20 Jul 2020 14:55:25 +0800 From: "Tu, Lijuan" To: "Zhang, XiX" , "dts@dpdk.org" CC: "Zhang, XiX" Thread-Topic: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment Thread-Index: AQHWUOc4VeqfwHbANkmnK7UEdI8gkqkQI6sg Date: Mon, 20 Jul 2020 06:55:24 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20E0BC8213D@SHSMSX101.ccr.corp.intel.com> References: <1593745659-29077-1-git-send-email-xix.zhang@intel.com> In-Reply-To: <1593745659-29077-1-git-send-email-xix.zhang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the execution order of shutting down the VM environment X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" Applied, thanks > -----Original Message----- > From: dts On Behalf Of xizhan4x > Sent: 2020=1B$BG/=1B(B7=1B$B7n=1B(B3=1B$BF|=1B(B 11:08 > To: dts@dpdk.org > Cc: Zhang, XiX > Subject: [dts] [PATCH V1] tests/TestSuite_shutdown_api:Modify the executi= on > order of shutting down the VM environment >=20 > Modify the execution order of shutting down the VM environment, The corre= ct > step should be to shut down the VM environment before unbind Vf >=20 >=20 > Signed-off-by: xizhan4x > --- > tests/TestSuite_shutdown_api.py | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_a= pi.py > index 650ccfc..9fc3e3a 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -296,6 +296,16 @@ class TestShutdownApi(TestCase): >=20 >=20 > def destroy_vm_env(self): > + if getattr(self, 'self.vm0_testpmd', None): > + self.vm0_testpmd.quit() > + > + if getattr(self, 'vm0', None): > + if getattr(self, 'vm0_dut', None): > + self.vm0_dut.kill_all() > + self.vm0_testpmd =3D None > + self.vm0_dut_ports =3D None > + # destroy vm0 > + self.vm0.stop() > if getattr(self, 'used_dut_port', None) is not None: > self.dut.destroy_sriov_vfs_by_port(self.used_dut_port) > self.used_dut_port =3D None > @@ -308,18 +318,11 @@ class TestShutdownApi(TestCase): > if not self.vm_env_done: > return >=20 > - if getattr(self, 'self.vm0_testpmd', None): > - self.vm0_testpmd.quit() > - > - if getattr(self, 'vm0', None): > - if getattr(self, 'vm0_dut', None): > - self.vm0_dut.kill_all() > - self.vm0_testpmd =3D None > - self.vm0_dut_ports =3D None > - # destroy vm0 > - self.vm0.stop() > self.vm_env_done =3D False >=20 > + > + > + > def test_stop_restart(self): > """ > Stop and Restar. > -- > 1.8.3.1