test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0
@ 2020-07-20 17:23 lingwei
  2020-07-21  6:39 ` Han, YingyaX
  2020-07-24  2:30 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: lingwei @ 2020-07-20 17:23 UTC (permalink / raw)
  To: dts; +Cc: lingwei

Fix test_perf_distributor case result is 0.

Signed-off-by: lingwei <weix.ling@intel.com>
---
 tests/TestSuite_distributor.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_distributor.py b/tests/TestSuite_distributor.py
index aaad6c7..9ccc761 100644
--- a/tests/TestSuite_distributor.py
+++ b/tests/TestSuite_distributor.py
@@ -138,8 +138,6 @@ class TestDistributor(TestCase):
 
             self.dut.send_expect(cmd, "doing packet RX", timeout=30)
 
-            self.app_output = self.dut.session.get_session_before(timeout=2)
-
             # clear streams before add new streams
             self.tester.pktgen.clear_streams()
             # run packet generator
@@ -147,6 +145,9 @@ class TestDistributor(TestCase):
                                     None, self.tester.pktgen)
             _, pps = self.tester.pktgen.measure_throughput(stream_ids=streams)
 
+            # get aap output after sending packet
+            self.app_output = self.dut.session.get_session_before(timeout=2)
+
             self.dut.send_expect("^C", "#")
 
             pps /= 1000000.0
@@ -240,6 +241,8 @@ class TestDistributor(TestCase):
         """
         # skip the last one, we use the next one
         output = output[:output.rfind("RX Thread")]
+        # skip the last two, we use the next one
+        output = output[:output.rfind("RX Thread")]
         output = output[output.rfind("RX Thread"):]
         rec_rate = 0.0
         enq_rate = 0.0
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0
  2020-07-20 17:23 [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0 lingwei
@ 2020-07-21  6:39 ` Han, YingyaX
  2020-07-24  2:30 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Han, YingyaX @ 2020-07-21  6:39 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Tested-by:  Han,YingyaX < yingyax.han@intel.com>

Regards,
Yingya

-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of lingwei
Sent: Tuesday, July 21, 2020 1:24 AM
To: dts@dpdk.org
Cc: Ling, WeiX <weix.ling@intel.com>
Subject: [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0

Fix test_perf_distributor case result is 0.

Signed-off-by: lingwei <weix.ling@intel.com>
---
 tests/TestSuite_distributor.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/TestSuite_distributor.py b/tests/TestSuite_distributor.py index aaad6c7..9ccc761 100644
--- a/tests/TestSuite_distributor.py
+++ b/tests/TestSuite_distributor.py
@@ -138,8 +138,6 @@ class TestDistributor(TestCase):
 
             self.dut.send_expect(cmd, "doing packet RX", timeout=30)
 
-            self.app_output = self.dut.session.get_session_before(timeout=2)
-
             # clear streams before add new streams
             self.tester.pktgen.clear_streams()
             # run packet generator
@@ -147,6 +145,9 @@ class TestDistributor(TestCase):
                                     None, self.tester.pktgen)
             _, pps = self.tester.pktgen.measure_throughput(stream_ids=streams)
 
+            # get aap output after sending packet
+            self.app_output = 
+ self.dut.session.get_session_before(timeout=2)
+
             self.dut.send_expect("^C", "#")
 
             pps /= 1000000.0
@@ -240,6 +241,8 @@ class TestDistributor(TestCase):
         """
         # skip the last one, we use the next one
         output = output[:output.rfind("RX Thread")]
+        # skip the last two, we use the next one
+        output = output[:output.rfind("RX Thread")]
         output = output[output.rfind("RX Thread"):]
         rec_rate = 0.0
         enq_rate = 0.0
--
2.17.1


[-- Attachment #2: TestDistributor.log --]
[-- Type: application/octet-stream, Size: 200851 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0
  2020-07-20 17:23 [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0 lingwei
  2020-07-21  6:39 ` Han, YingyaX
@ 2020-07-24  2:30 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-07-24  2:30 UTC (permalink / raw)
  To: Ling, WeiX, dts; +Cc: Ling, WeiX

Applied, thanks

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of lingwei
> Sent: 2020年7月21日 1:24
> To: dts@dpdk.org
> Cc: Ling, WeiX <weix.ling@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor
> case result is 0
> 
> Fix test_perf_distributor case result is 0.
> 
> Signed-off-by: lingwei <weix.ling@intel.com>
> ---
>  tests/TestSuite_distributor.py | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_distributor.py b/tests/TestSuite_distributor.py index
> aaad6c7..9ccc761 100644
> --- a/tests/TestSuite_distributor.py
> +++ b/tests/TestSuite_distributor.py
> @@ -138,8 +138,6 @@ class TestDistributor(TestCase):
> 
>              self.dut.send_expect(cmd, "doing packet RX", timeout=30)
> 
> -            self.app_output = self.dut.session.get_session_before(timeout=2)
> -
>              # clear streams before add new streams
>              self.tester.pktgen.clear_streams()
>              # run packet generator
> @@ -147,6 +145,9 @@ class TestDistributor(TestCase):
>                                      None, self.tester.pktgen)
>              _, pps = self.tester.pktgen.measure_throughput(stream_ids=streams)
> 
> +            # get aap output after sending packet
> +            self.app_output =
> + self.dut.session.get_session_before(timeout=2)
> +
>              self.dut.send_expect("^C", "#")
> 
>              pps /= 1000000.0
> @@ -240,6 +241,8 @@ class TestDistributor(TestCase):
>          """
>          # skip the last one, we use the next one
>          output = output[:output.rfind("RX Thread")]
> +        # skip the last two, we use the next one
> +        output = output[:output.rfind("RX Thread")]
>          output = output[output.rfind("RX Thread"):]
>          rec_rate = 0.0
>          enq_rate = 0.0
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-07-24  2:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 17:23 [dts] [PATCH V1] tests/TestSuite_distributor: Fix test_perf_distributor case result is 0 lingwei
2020-07-21  6:39 ` Han, YingyaX
2020-07-24  2:30 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).