test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>
Subject: Re: [dts] [PATCH V1] tests/vf daemon : add vlan filter
Date: Tue, 29 May 2018 09:30:32 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20EE65756@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1527578148-30451-1-git-send-email-meijuanx.zhao@intel.com>

Hi meijuan,
	Ethdev layer and PMD don't have the same status of vlan filter. I think it isn't make sense.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
Sent: Tuesday, May 29, 2018 3:16 PM
To: dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: [dts] [PATCH V1] tests/vf daemon : add vlan filter

Ethdev layer doesn't know  ixgbe PF PMD enable VLAN filter when it hosts any VF.
The first "vlan set filter off 0" on PF doesn't take effect as ethdev layer think  vlan filter isn't enabled on PMD. Adding "vlan set filter on 0" to align the VLAN  filter switch in ethdev layer with that in PMD, and also make the first "vlan set filter off 0" effective on PF.

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py index 56fc4be..4ad4098 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -576,6 +576,7 @@ class Testvf_daemon(TestCase):
         if self.kdriver == "i40e":
             self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
         else:
+            self.dut_testpmd.execute_cmd('vlan set filter on 0')
             self.dut_testpmd.execute_cmd('vlan set filter off 0')
             self.dut_testpmd.execute_cmd('vlan set strip off 0')
             self.vm0_testpmd.execute_cmd('vlan set strip off 0')
--
1.9.3

  reply	other threads:[~2018-05-29  9:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29  7:15 zhao,meijuan
2018-05-29  9:30 ` Tu, Lijuan [this message]
2018-06-11  5:07 ` Liu, Yong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20EE65756@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=meijuanx.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).