[dts] [PATCH V1] tests/vf daemon : add vlan filter

[dts] [PATCH V1] tests/vf daemon : add vlan filter

[zhao,meijuan]

Ethdev layer doesn't know  ixgbe PF PMD enable VLAN filter when it hosts any VF.
The first "vlan set filter off 0" on PF doesn't take effect as ethdev layer think
 vlan filter isn't enabled on PMD. Adding "vlan set filter on 0" to align the VLAN
 filter switch in ethdev layer with that in PMD, and also make the first 
"vlan set filter off 0" effective on PF.

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
index 56fc4be..4ad4098 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -576,6 +576,7 @@ class Testvf_daemon(TestCase):
         if self.kdriver == "i40e":
             self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
         else:
+            self.dut_testpmd.execute_cmd('vlan set filter on 0')
             self.dut_testpmd.execute_cmd('vlan set filter off 0')
             self.dut_testpmd.execute_cmd('vlan set strip off 0')
             self.vm0_testpmd.execute_cmd('vlan set strip off 0')
-- 
1.9.3

Re: [dts] [PATCH V1] tests/vf daemon : add vlan filter

[Tu, Lijuan]

Hi meijuan,
	Ethdev layer and PMD don't have the same status of vlan filter. I think it isn't make sense.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
Sent: Tuesday, May 29, 2018 3:16 PM
To: dts@dpdk.org
Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
Subject: [dts] [PATCH V1] tests/vf daemon : add vlan filter

Ethdev layer doesn't know  ixgbe PF PMD enable VLAN filter when it hosts any VF.
The first "vlan set filter off 0" on PF doesn't take effect as ethdev layer think  vlan filter isn't enabled on PMD. Adding "vlan set filter on 0" to align the VLAN  filter switch in ethdev layer with that in PMD, and also make the first "vlan set filter off 0" effective on PF.

Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
---
 tests/TestSuite_vf_daemon.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py index 56fc4be..4ad4098 100644
--- a/tests/TestSuite_vf_daemon.py
+++ b/tests/TestSuite_vf_daemon.py
@@ -576,6 +576,7 @@ class Testvf_daemon(TestCase):
         if self.kdriver == "i40e":
             self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
         else:
+            self.dut_testpmd.execute_cmd('vlan set filter on 0')
             self.dut_testpmd.execute_cmd('vlan set filter off 0')
             self.dut_testpmd.execute_cmd('vlan set strip off 0')
             self.vm0_testpmd.execute_cmd('vlan set strip off 0')
--
1.9.3

Re: [dts] [PATCH V1] tests/vf daemon : add vlan filter

[Liu, Yong]

Meijuan, I known that maybe some issue in the driver. Could you please also add some notes in the code?  As enabling something before disabling look weird.

Thanks,
Marvin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Tuesday, May 29, 2018 3:16 PM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vf daemon : add vlan filter
> 
> Ethdev layer doesn't know  ixgbe PF PMD enable VLAN filter when it hosts
> any VF.
> The first "vlan set filter off 0" on PF doesn't take effect as ethdev
> layer think
>  vlan filter isn't enabled on PMD. Adding "vlan set filter on 0" to align
> the VLAN
>  filter switch in ethdev layer with that in PMD, and also make the first
> "vlan set filter off 0" effective on PF.
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vf_daemon.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/TestSuite_vf_daemon.py b/tests/TestSuite_vf_daemon.py
> index 56fc4be..4ad4098 100644
> --- a/tests/TestSuite_vf_daemon.py
> +++ b/tests/TestSuite_vf_daemon.py
> @@ -576,6 +576,7 @@ class Testvf_daemon(TestCase):
>          if self.kdriver == "i40e":
>              self.dut_testpmd.execute_cmd('set vf vlan stripq 0 0 off')
>          else:
> +            self.dut_testpmd.execute_cmd('vlan set filter on 0')
>              self.dut_testpmd.execute_cmd('vlan set filter off 0')
>              self.dut_testpmd.execute_cmd('vlan set strip off 0')
>              self.vm0_testpmd.execute_cmd('vlan set strip off 0')
> --
> 1.9.3