Re: [dts] [PATCH V1] tests/vm power: change guest vm power mgr option

["Tu, Lijuan" <lijuan.tu@intel.com>]

Comments inline.

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan
> Sent: Friday, July 27, 2018 9:25 AM
> To: dts@dpdk.org
> Cc: Zhao, MeijuanX <meijuanx.zhao@intel.com>
> Subject: [dts] [PATCH V1] tests/vm power: change guest vm power mgr
> option
> 
> host core number is three at least,guest option have vm-name and vcpu-list
> at least, you chan refer to dpdk 59287933
[Lijuan] can or could instead of chan
> 
> Signed-off-by: zhao,meijuan <meijuanx.zhao@intel.com>
> ---
>  tests/TestSuite_vm_power_manager.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/tests/TestSuite_vm_power_manager.py
> b/tests/TestSuite_vm_power_manager.py
> index 5e273f4..1e72b19 100644
> --- a/tests/TestSuite_vm_power_manager.py
> +++ b/tests/TestSuite_vm_power_manager.py
> @@ -90,9 +90,8 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>              "examples/vm_power_manager/guest_cli")
>          self.verify("Error" not in out, "Compilation error")
>          self.verify("No such" not in out, "Compilation error")
> -
>          self.vm_power_dir = "./examples/vm_power_manager/"
> -        mgr_cmd = self.vm_power_dir + "build/vm_power_mgr -c 0x3 -n
> 4"
> +        mgr_cmd = self.vm_power_dir + "build/vm_power_mgr -c 0x7 -n
> 4"
>          out = self.dut.send_expect(mgr_cmd, "vmpower>", 120)
>          self.dut.send_expect("add_vm %s" % self.vm_name,
> "vmpower>")
>          self.dut.send_expect("add_channels %s all" % self.vm_name,
> "vmpower>") @@ -115,7 +114,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          """
>          # check Channels and vcpus
>          guest_cmd = self.vm_power_dir + \
> -            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i"
> +            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 --
> --vm-name=vm0 --vcpu-list=0,1,2,3"
[Lijuan] self.vm_name instead of hardcode, some place using " self.vm_name ", and some place using hardcode "vm0", please unify them ,suggest using self.vm_name
>          out = self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>",
> 120)
>          self.vm_dut.send_expect("quit", "# ")
> 
> @@ -134,7 +133,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          Check host cpu frequency can scale down in VM
>          """
>          guest_cmd = self.vm_power_dir + \
> -            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i"
> +            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 --
> --vm-name=vm0 --vcpu-list=0,1,2,3"
[Lijuan] same as previous
>          out = self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>",
> 120)
> 
>          for vcpu in range(self.core_num):
> @@ -164,7 +163,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          Check host cpu frequency can scale up in VM
>          """
>          guest_cmd = self.vm_power_dir + \
> -            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i"
> +            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 --
> --vm-name=vm0 --vcpu-list=0,1,2,3"
[Lijuan] same as previous
>          out = self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>",
> 120)
> 
>          for vcpu in range(self.core_num):
> @@ -191,7 +190,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          Check host cpu frequency can scale to max in VM
>          """
>          guest_cmd = self.vm_power_dir + \
> -            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i"
> +            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 --
> --vm-name=vm0 --vcpu-list=0,1,2,3"
[Lijuan] same as previous
>          out = self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>",
> 120)
> 
>          max_freq_path = "cat /sys/devices/system/cpu/cpu%s/cpufreq/"
> + \ @@ -214,7 +213,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          Check host cpu frequency can scale to min in VM
>          """
>          guest_cmd = self.vm_power_dir + \
> -            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i"
> +            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 --
> --vm-name=vm0 --vcpu-list=0,1,2,3"
[Lijuan] same as previous
>          out = self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>",
> 120)
> 
>          min_freq_path = "cat /sys/devices/system/cpu/cpu%s/cpufreq/"
> + \ @@ -279,7 +278,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          self.verify("No such" not in out, "Compilation error")
> 
>          guest_cmd = self.vm_power_dir + \
> -            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i"
> +            "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 --
> --vm-name=vm0 --vcpu-list=0,1,2,3"
>          out = vm2_dut.send_expect(guest_cmd, "vmpower\(guest\)>",
> 120)
>          vm2_dut.send_expect("quit", "# ")
>          vm2.stop()
> @@ -432,4 +431,5 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          self.dut.send_expect("quit", "# ")
>          self.vm.stop()
>          self.dut.virt_exit()
> +        self.dut.send_expect("kill -9 $(pidof qemu-system-x86_64)", "#
[Lijuan] why kill qemu here? In virt_exit, it will stop hypervisors process. 
> + ")
>          pass
> --
> 1.9.3