From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B037F1DB8 for ; Fri, 27 Jul 2018 05:01:09 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2018 20:01:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,407,1526367600"; d="scan'208";a="248771248" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 26 Jul 2018 20:01:08 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Jul 2018 20:01:08 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 26 Jul 2018 20:01:07 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.57]) by shsmsx102.ccr.corp.intel.com ([169.254.2.124]) with mapi id 14.03.0319.002; Fri, 27 Jul 2018 11:01:05 +0800 From: "Tu, Lijuan" To: "Zhao, MeijuanX" , "dts@dpdk.org" CC: "Zhao, MeijuanX" Thread-Topic: [dts] [PATCH V1] tests/vm power: change guest vm power mgr option Thread-Index: AQHUJUiXweCV89hMO0uDmzyAe0yX0aSiXmTw Date: Fri, 27 Jul 2018 03:01:04 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20EE8ED32@SHSMSX101.ccr.corp.intel.com> References: <1532654715-100434-1-git-send-email-meijuanx.zhao@intel.com> In-Reply-To: <1532654715-100434-1-git-send-email-meijuanx.zhao@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmNlY2JmOTctZTc4ZC00YmFiLTg4OGYtZjU2YTcwZGVmNmM3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiSkRyeTZtSDJVTDJvOHhPSEdcL2ErTVB4TE94MnBHWjBvRDhldFJpRnNVVjhUdSt4NTFGM0xDN2xXakRyZFwvb0RoIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/vm power: change guest vm power mgr option X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 03:01:10 -0000 Comments inline. > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhao,meijuan > Sent: Friday, July 27, 2018 9:25 AM > To: dts@dpdk.org > Cc: Zhao, MeijuanX > Subject: [dts] [PATCH V1] tests/vm power: change guest vm power mgr > option >=20 > host core number is three at least,guest option have vm-name and vcpu-lis= t > at least, you chan refer to dpdk 59287933 [Lijuan] can or could instead of chan >=20 > Signed-off-by: zhao,meijuan > --- > tests/TestSuite_vm_power_manager.py | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) >=20 > diff --git a/tests/TestSuite_vm_power_manager.py > b/tests/TestSuite_vm_power_manager.py > index 5e273f4..1e72b19 100644 > --- a/tests/TestSuite_vm_power_manager.py > +++ b/tests/TestSuite_vm_power_manager.py > @@ -90,9 +90,8 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > "examples/vm_power_manager/guest_cli") > self.verify("Error" not in out, "Compilation error") > self.verify("No such" not in out, "Compilation error") > - > self.vm_power_dir =3D "./examples/vm_power_manager/" > - mgr_cmd =3D self.vm_power_dir + "build/vm_power_mgr -c 0x3 -n > 4" > + mgr_cmd =3D self.vm_power_dir + "build/vm_power_mgr -c 0x7 -n > 4" > out =3D self.dut.send_expect(mgr_cmd, "vmpower>", 120) > self.dut.send_expect("add_vm %s" % self.vm_name, > "vmpower>") > self.dut.send_expect("add_channels %s all" % self.vm_name, > "vmpower>") @@ -115,7 +114,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > """ > # check Channels and vcpus > guest_cmd =3D self.vm_power_dir + \ > - "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i" > + "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- > --vm-name=3Dvm0 --vcpu-list=3D0,1,2,3" [Lijuan] self.vm_name instead of hardcode, some place using " self.vm_name = ", and some place using hardcode "vm0", please unify them ,suggest using se= lf.vm_name > out =3D self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>", > 120) > self.vm_dut.send_expect("quit", "# ") >=20 > @@ -134,7 +133,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > Check host cpu frequency can scale down in VM > """ > guest_cmd =3D self.vm_power_dir + \ > - "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i" > + "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- > --vm-name=3Dvm0 --vcpu-list=3D0,1,2,3" [Lijuan] same as previous > out =3D self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>", > 120) >=20 > for vcpu in range(self.core_num): > @@ -164,7 +163,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > Check host cpu frequency can scale up in VM > """ > guest_cmd =3D self.vm_power_dir + \ > - "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i" > + "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- > --vm-name=3Dvm0 --vcpu-list=3D0,1,2,3" [Lijuan] same as previous > out =3D self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>", > 120) >=20 > for vcpu in range(self.core_num): > @@ -191,7 +190,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > Check host cpu frequency can scale to max in VM > """ > guest_cmd =3D self.vm_power_dir + \ > - "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i" > + "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- > --vm-name=3Dvm0 --vcpu-list=3D0,1,2,3" [Lijuan] same as previous > out =3D self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>", > 120) >=20 > max_freq_path =3D "cat /sys/devices/system/cpu/cpu%s/cpufreq/" > + \ @@ -214,7 +213,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > Check host cpu frequency can scale to min in VM > """ > guest_cmd =3D self.vm_power_dir + \ > - "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i" > + "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- > --vm-name=3Dvm0 --vcpu-list=3D0,1,2,3" [Lijuan] same as previous > out =3D self.vm_dut.send_expect(guest_cmd, "vmpower\(guest\)>", > 120) >=20 > min_freq_path =3D "cat /sys/devices/system/cpu/cpu%s/cpufreq/" > + \ @@ -279,7 +278,7 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > self.verify("No such" not in out, "Compilation error") >=20 > guest_cmd =3D self.vm_power_dir + \ > - "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- -i" > + "guest_cli/build/guest_vm_power_mgr -c 0xf -n 4 -- > --vm-name=3Dvm0 --vcpu-list=3D0,1,2,3" > out =3D vm2_dut.send_expect(guest_cmd, "vmpower\(guest\)>", > 120) > vm2_dut.send_expect("quit", "# ") > vm2.stop() > @@ -432,4 +431,5 @@ class TestVmPowerManager(TestCase, > IxiaPacketGenerator): > self.dut.send_expect("quit", "# ") > self.vm.stop() > self.dut.virt_exit() > + self.dut.send_expect("kill -9 $(pidof qemu-system-x86_64)", "# [Lijuan] why kill qemu here? In virt_exit, it will stop hypervisors process= .=20 > + ") > pass > -- > 1.9.3