test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Han, YingyaX" <yingyax.han@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Han, YingyaX" <yingyax.han@intel.com>
Subject: Re: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of	sending packets and modprobe vfio-pci
Date: Wed, 22 Aug 2018 08:44:36 +0000	[thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20EEAAAF1@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1534919240-127455-1-git-send-email-yingyax.han@intel.com>

Comments inline

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Wednesday, August 22, 2018 2:27 PM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/runtime_queue_number: fix the problem of
> sending packets and modprobe vfio-pci
> 
> 256 exceeded the IP address range.
> 
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
>  tests/TestSuite_runtime_queue_number.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_runtime_queue_number.py
> b/tests/TestSuite_runtime_queue_number.py
> index 44aec06..7d7bc5b 100644
> --- a/tests/TestSuite_runtime_queue_number.py
> +++ b/tests/TestSuite_runtime_queue_number.py
> @@ -90,6 +90,7 @@ class TestRuntime_Queue_Number(TestCase):
>          # assigned number of VFs
>          self.dut.generate_sriov_vfs_by_port(self.dut_ports[0], vfs_num,
> self.drivername)
>          self.sriov_vfs_port =
> self.dut.ports_info[self.dut_ports[0]]['vfs_port']
> +        self.dut.send_expect('modprobe vfio-pci', '#')
[Lijuan] if vf doesn't use vfio, there is no need to insmod vfio-pci
> 
>          try:
>              for port in self.sriov_vfs_port:
> @@ -125,7 +126,7 @@ class TestRuntime_Queue_Number(TestCase):
>          """
>          self.tester.scapy_foreground()
>          time.sleep(2)
> -        for i in range(256):
> +        for i in range(254):
>              packet = r'sendp([Ether(dst="%s",
> src=get_if_hwaddr("%s"))/IP(src="192.168.0.%d", dst="192.168.0.%d")],
> iface="%s")' % (
>                  self.vf_mac, itf, i + 1, i + 2, itf)
>              self.tester.scapy_append(packet) @@ -160,7 +161,7 @@
> class TestRuntime_Queue_Number(TestCase):
>                  m = scanner.search(line)
>                  packet_rec = m.group(1)
> 
> -        self.verify(packet_sumnum == int(packet_rec) == 256, "There are
> some packets lost.")
> +        self.verify(packet_sumnum == int(packet_rec) == 254, "There are
> + some packets lost.")
> 
>      def test_set_valid_vf_max_qn(self):
>          """
> --
> 1.9.3

  reply	other threads:[~2018-08-22  8:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22  6:27 han,yingya
2018-08-22  8:44 ` Tu, Lijuan [this message]
2018-08-22  9:04   ` Han, YingyaX
2018-08-24  6:40   ` Han, YingyaX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20EEAAAF1@SHSMSX101.ccr.corp.intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yingyax.han@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).