From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>
Subject: Re: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp
Date: Sun, 30 Sep 2018 06:49:49 +0000 [thread overview]
Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20EEE6CF8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1537497070-7523-1-git-send-email-wenjiex.a.li@intel.com>
>From your comments, I can't get why the return value changed to 0x0; I wish to get the reason from your comments but not to read the dpdk commit 323e7b6
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli
> Sent: Friday, September 21, 2018 10:31 AM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return
> value after enable crc-strp
>
> Due to DPDK commit 323e7b667f18376c60351282950b28d4d0cc6165, the
> Rx offloads return value is changed from 0x1000 to 0x0, update dts to fit this
> change.
>
> Signed-off-by: wenjieli <wenjiex.a.li@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index 52a8fbf..61a6d6b 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -274,7 +274,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> self.verify(
> - "Rx offloads=0x1000" in out, "CRC stripping not enabled
> properly")
> + "Rx offloads=0x0" in out, "CRC stripping not enabled
> + properly")
[Lijuan] Could you define a name for the crc flag, for example, RX_OFFLOAD_KEEP_CRC = 0x1000, self.verfiy(rx_offload & RX_OFFLOAD_KEEP_CRC, "CRC keep is not enabled properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
>
> --
> 1.9.3
prev parent reply other threads:[~2018-09-30 6:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 2:31 wenjieli
2018-09-30 6:49 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8CE3E05A3F976642AAB0F4675D0AD20EEE6CF8@SHSMSX101.ccr.corp.intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=wenjiex.a.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).