From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id B11902BF4 for ; Sun, 30 Sep 2018 08:52:38 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Sep 2018 23:52:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,323,1534834800"; d="scan'208,223";a="78630602" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga006.jf.intel.com with ESMTP; 29 Sep 2018 23:49:52 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 29 Sep 2018 23:49:52 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.319.2; Sat, 29 Sep 2018 23:49:52 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.220]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0319.002; Sun, 30 Sep 2018 14:49:50 +0800 From: "Tu, Lijuan" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp Thread-Index: AQHUUVLaRSBLy8dyVkm0LSzdQmipX6UIbX6Q Date: Sun, 30 Sep 2018 06:49:49 +0000 Message-ID: <8CE3E05A3F976642AAB0F4675D0AD20EEE6CF8@SHSMSX101.ccr.corp.intel.com> References: <1537497070-7523-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1537497070-7523-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDc0M2I5ZjgtMGNhYy00ODQ4LWFmYmItNGRhNDBkNGUyNjJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiVzRyUGNlejJmNU5KbDJ0MW5jbzRKSDJCSUZHTmlBXC9ia1ZlVW5OTXJ5WkVLcnFWaVk2dFwvQXJrWHhIdVcyWGdYIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return value after enable crc-strp X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Sep 2018 06:52:39 -0000 >>From your comments, I can't get why the return value changed to 0x0; I wish= to get the reason from your comments but not to read the dpdk commit 323e7= b6 > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of wenjieli > Sent: Friday, September 21, 2018 10:31 AM > To: dts@dpdk.org > Cc: Li, WenjieX A > Subject: [dts] [PATCH V1] tests/shutdown_api update Rx offloads return > value after enable crc-strp >=20 > Due to DPDK commit 323e7b667f18376c60351282950b28d4d0cc6165, the > Rx offloads return value is changed from 0x1000 to 0x0, update dts to fit= this > change. >=20 > Signed-off-by: wenjieli > --- > tests/TestSuite_shutdown_api.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py > b/tests/TestSuite_shutdown_api.py index 52a8fbf..61a6d6b 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -274,7 +274,7 @@ class TestShutdownApi(TestCase): > self.dut.send_expect("port start all", "testpmd> ", 100) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > - "Rx offloads=3D0x1000" in out, "CRC stripping not enabled > properly") > + "Rx offloads=3D0x0" in out, "CRC stripping not enabled > + properly") [Lijuan] Could you define a name for the crc flag, for example, RX_OFFLOAD_= KEEP_CRC =3D 0x1000, self.verfiy(rx_offload & RX_OFFLOAD_KEEP_CRC, "CRC kee= p is not enabled properly") > self.dut.send_expect("start", "testpmd> ") > self.check_forwarding() >=20 > -- > 1.9.3