RE: [PATCH v3 2/3] update files depending on tests/util

["Juraj Linkeš" <juraj.linkes@pantheon.tech>]

[-- Attachment #1: Type: text/plain, Size: 2436 bytes --]



From: Owen Hilyard <ohilyard@iol.unh.edu>
Sent: Thursday, April 14, 2022 9:54 PM
To: Juraj Linkeš <juraj.linkes@pantheon.tech>
Cc: dts@dpdk.org; lijuan.tu@intel.com
Subject: Re: [PATCH v3 2/3] update files depending on tests/util

I moved the files over and ran the formatter, which produced a diff large enough that the mailing list rejected it when I bundled it with the first commit. I could split things up more, but that would lead to an extra 2 or 3 patches in this series that contain formatting unrelated to the problem, simply because unformatted patches are getting merged. I hadn't anticipated needing granularity in the formatter because nothing except what you just worked on was supposed to be changing when you ran it, and the tools we're using don't support parts of a file.

[Juraj] Well you could've just changed this one thing manually. The formatting of whole files shouldn't be done here.

I don't want to have to keep submitting "ran the formatter" patches every week or two, since that will lead to a very messy git history.  I could submit one more and rebase this series on top of it, which would let me send it in as two organized commits. Thoughts?

[Juraj] What we should do is have a system that prevents unformatted files from being accepted (I understand we formatted the  and now they're improperly formatted - that shouldn't happen, although that could be because Lijian ran format.sh without pylama config?). A CI check which we're working on is sufficient with maintainers adhering to it (i.e. notifing authors that it's indeed necessary to properly format their submissions). Once we have the CI check, only then it makes sense to reformat everything. After that, we should notify the authors of patches in review to rebase and reformat their patches.

On Thu, Apr 14, 2022 at 1:40 AM Juraj Linkeš <juraj.linkes@pantheon.tech<mailto:juraj.linkes@pantheon.tech>> wrote:

> diff --git a/framework/dut.py b/framework/dut.py index 6a8fc957..83f0d7a2
> 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -46,7 +46,7 @@ from .settings import LOG_NAME_SEP, NICS  from
> .ssh_connection import SSHConnection  from .test_result import ResultTable
> from .utils import RED, remove_old_rsa_key -from .virt_resource import
> VirtResource
> +from framework.virt_resource import VirtResource

And this also didn't get addressed, I guess you just added the commit in v3.

[-- Attachment #2: Type: text/html, Size: 6375 bytes --]