test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Huang, ZhiminX" <zhiminx.huang@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Cc: "Huang, ZhiminX" <zhiminx.huang@intel.com>
Subject: RE: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
Date: Tue, 30 Nov 2021 03:11:34 +0000	[thread overview]
Message-ID: <90713d0c370b4f3ba1851afff735e59c@intel.com> (raw)
In-Reply-To: <20211115143747.15020-1-zhiminx.huang@intel.com>



> -----Original Message-----
> From: Zhimin Huang <zhiminx.huang@intel.com>
> Sent: 2021年11月15日 22:38
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V1] checksum_offload:ignore sctp checksum in check l4 tx
> 
> sync with dev to ignore check sctp in pmd,customers only require udp and tcp.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
> ---
>  test_plans/checksum_offload_test_plan.rst | 2 +-
>  tests/TestSuite_checksum_offload.py       | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test_plans/checksum_offload_test_plan.rst
> b/test_plans/checksum_offload_test_plan.rst
> index db939b45..f4b388c4 100644
> --- a/test_plans/checksum_offload_test_plan.rst
> +++ b/test_plans/checksum_offload_test_plan.rst
> @@ -297,7 +297,7 @@ Test Case: Hardware Checksum Check L4 TX
> ===========================================
>  This test involves testing many different scenarios with a L4 checksum.
>  A variety of tunneling protocols, L3 protocols and L4 protocols are combined -
> to test as many scenarios as possible. Currently, UDP, TCP and SCTP are used
> +to test as many scenarios as possible. Currently, UDP and TCP are used
>  as L4 protocols, with IP and IPv6 being used at level 3. The tested tunneling
> protocols are VXLAN and GRE. This test is used to determine whether the
> hardware offloading of checksums works properly.
> diff --git a/tests/TestSuite_checksum_offload.py
> b/tests/TestSuite_checksum_offload.py
> index 3338e334..bdea6a15 100644
> --- a/tests/TestSuite_checksum_offload.py
> +++ b/tests/TestSuite_checksum_offload.py
> @@ -69,7 +69,7 @@ l3_proto_classes = [
>  l4_proto_classes = [
>      UDP,
>      TCP,
> -    SCTP
> +#    SCTP

It is commented here,  I think it is a know issue and will be fixed in a short time.

If there is no plan to fix it? Why keep them ?

>  ]
> 
>  tunnelling_proto_classes = [
> --
> 2.17.1


  parent reply	other threads:[~2021-11-30  3:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15 14:37 Zhimin Huang
2021-11-15  6:15 ` Huang, ZhiminX
2021-11-30  3:11 ` Tu, Lijuan [this message]
2021-11-30  3:17   ` Huang, ZhiminX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=90713d0c370b4f3ba1851afff735e59c@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=zhiminx.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).