[PATCH 0/3] Changes for IGB

test suite reviews and discussions
 help / color / mirror / Atom feed

* [PATCH 0/3] Changes for IGB_1G-82576
@ 2023-04-14 12:49 Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 1/3] conf/test_case_checklist: Add IGB_1G-82576 Akihiko Odaki
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Akihiko Odaki @ 2023-04-14 12:49 UTC (permalink / raw)
  Cc: dts, Akihiko Odaki

This series includes changes necessary for IGB_1G-82576.

Akihiko Odaki (3):
  conf/test_case_checklist: Add IGB_1G-82576
  tests/pmdrssreta: Add IGB_1G-82576
  tests/uni_pkt: Add IGB_1G-82576

 conf/test_case_checklist.json | 9 +++++++++
 tests/TestSuite_pmdrssreta.py | 4 +++-
 tests/TestSuite_uni_pkt.py    | 3 +++
 3 files changed, 15 insertions(+), 1 deletion(-)

-- 
2.40.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] conf/test_case_checklist: Add IGB_1G-82576
  2023-04-14 12:49 [PATCH 0/3] Changes for IGB_1G-82576 Akihiko Odaki
@ 2023-04-14 12:49 ` Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 2/3] tests/pmdrssreta: " Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 3/3] tests/uni_pkt: " Akihiko Odaki
  2 siblings, 0 replies; 5+ messages in thread
From: Akihiko Odaki @ 2023-04-14 12:49 UTC (permalink / raw)
  Cc: dts, Akihiko Odaki

This lists test cases not supported by IGB_1G-82576.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 conf/test_case_checklist.json | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/conf/test_case_checklist.json b/conf/test_case_checklist.json
index c4eb6951..fcbcf88b 100644
--- a/conf/test_case_checklist.json
+++ b/conf/test_case_checklist.json
@@ -293,6 +293,7 @@
                 "I40E_40G-QSFP_B",
                 "IGC-I225_LM",
                 "IGC-I226_LM",
+                "IGB_1G-82576",
                 "IGB_1G-I350_COPPER",
                 "IGB_1G-82576_QUAD_COPPER_ET2",
                 "IGB_1G-I210_COPPER",
@@ -323,6 +324,7 @@
                 "cavium_a063",
                 "cavium_a064",
                 "I40E_10G-10G_BASE_T_BC",
+                "IGB_1G-82576",
                 "IGB_1G-I350_COPPER",
                 "ICE_25G-E810C_SFP",
 		"ICE_25G-E823C_QSFP",
@@ -421,6 +423,7 @@
             ],
             "NIC": [
                 "IGB_1G-I350_COPPER",
+                "IGB_1G-82576",
                 "IGB_1G-82576_QUAD_COPPER_ET2",
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
@@ -461,6 +464,7 @@
             ],
             "NIC": [
                 "IGB_1G-I350_COPPER",
+                "IGB_1G-82576",
                 "IGB_1G-82576_QUAD_COPPER_ET2",
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
@@ -501,6 +505,7 @@
             ],
             "NIC": [
                 "IGB_1G-I350_COPPER",
+                "IGB_1G-82576",
                 "IGB_1G-82576_QUAD_COPPER_ET2",
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
@@ -541,6 +546,7 @@
             ],
             "NIC": [
                 "IGB_1G-I350_COPPER",
+                "IGB_1G-82576",
                 "IGB_1G-82576_QUAD_COPPER_ET2",
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
@@ -562,6 +568,7 @@
             ],
             "NIC": [
                 "IGB_1G-I350_COPPER",
+                "IGB_1G-82576",
                 "IGB_1G-82576_QUAD_COPPER_ET2",
                 "IGB_1G-I210_COPPER",
                 "cavium_a034",
@@ -2882,6 +2889,7 @@
                 "ALL"
             ],
             "NIC": [
+                "IGB_1G-82576",
                 "IGB_1G-I350_COPPER",
                 "IGB_1G-I210_COPPER",
                 "ICE_25G-E810C_SFP",
@@ -2903,6 +2911,7 @@
                 "ALL"
             ],
             "NIC": [
+                "IGB_1G-82576",
                 "IGB_1G-I350_COPPER",
                 "IGB_1G-I210_COPPER",
 		"ICE_25G-E823C_QSFP",
-- 
2.40.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/3] tests/pmdrssreta: Add IGB_1G-82576
  2023-04-14 12:49 [PATCH 0/3] Changes for IGB_1G-82576 Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 1/3] conf/test_case_checklist: Add IGB_1G-82576 Akihiko Odaki
@ 2023-04-14 12:49 ` Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 3/3] tests/uni_pkt: " Akihiko Odaki
  2 siblings, 0 replies; 5+ messages in thread
From: Akihiko Odaki @ 2023-04-14 12:49 UTC (permalink / raw)
  Cc: dts, Akihiko Odaki

IGB_1G-82576 has 40-entry RETA and 7 effective RSS hash bits.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/TestSuite_pmdrssreta.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_pmdrssreta.py b/tests/TestSuite_pmdrssreta.py
index 1fd20f7a..08767670 100644
--- a/tests/TestSuite_pmdrssreta.py
+++ b/tests/TestSuite_pmdrssreta.py
@@ -155,6 +155,7 @@ class TestPmdrssreta(TestCase):
                 "IGC-I226_LM",
                 "IGC-I225_LM",
                 "IXGBE_10G-X540T",
+                "IGB_1G-82576",
             ]:
                 # compute the hash result of five tuple into the 7 LSBs value.
                 hash_index = int(tmp_reta_line["RSS hash"], 16) % 128
@@ -263,7 +264,7 @@ class TestPmdrssreta(TestCase):
                             "port config 0 rss reta (%d,%d)" % (i, reta_entries[i]),
                             "testpmd> ",
                         )
-                elif self.nic in ["IXGBE_10G-82599_SFP", "IGC-I225_LM", "IGC-I226_LM"]:
+                elif self.nic in ["IXGBE_10G-82599_SFP", "IGC-I225_LM", "IGC-I226_LM", "IGB_1G-82576"]:
                     for i in range(128):
                         reta_entries.insert(i, random.randint(0, queue - 1))
                         self.dut.send_expect(
@@ -304,6 +305,7 @@ class TestPmdrssreta(TestCase):
             "IGC-I225_LM": 40,
             "IGC-I226_LM": 40,
             "IXGBE_10G-X540T": 40,
+            "IGB_1G-82576": 40,
         }
         self.verify(
             self.nic in list(nic_rss_key_size.keys()),
-- 
2.40.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] tests/uni_pkt: Add IGB_1G-82576
  2023-04-14 12:49 [PATCH 0/3] Changes for IGB_1G-82576 Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 1/3] conf/test_case_checklist: Add IGB_1G-82576 Akihiko Odaki
  2023-04-14 12:49 ` [PATCH 2/3] tests/pmdrssreta: " Akihiko Odaki
@ 2023-04-14 12:49 ` Akihiko Odaki
  2023-04-26  2:34   ` lijuan.tu
  2 siblings, 1 reply; 5+ messages in thread
From: Akihiko Odaki @ 2023-04-14 12:49 UTC (permalink / raw)
  Cc: dts, Akihiko Odaki

IGB_1G-82576 uses L3_IPV4 for the default IPv4 packet type, and cannot
detect ICMP.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/TestSuite_uni_pkt.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/TestSuite_uni_pkt.py b/tests/TestSuite_uni_pkt.py
index e883b84d..8aa526f0 100644
--- a/tests/TestSuite_uni_pkt.py
+++ b/tests/TestSuite_uni_pkt.py
@@ -118,6 +118,7 @@ class TestUniPacket(TestCase):
             ipv4_default_packet_type = ["L2_ETHER", "L3_IPV4_EXT_UNKNOWN"]
         elif (
             "IXGBE_10G-82599_SFP" in self.nic
+            or "IGB_1G-82576" in self.nic
             or "IGB_1G-I350_COPPER" in self.nic
             or "cavium" in self.nic
             or "IXGBE_10G-X540T" in self.nic
@@ -153,6 +154,7 @@ class TestUniPacket(TestCase):
             pktType.pop("MAC_IPihl_SCTP_PKT")
         elif (
             "IXGBE_10G-82599_SFP" in self.nic
+            or "IGB_1G-82576" in self.nic
             or "IGB_1G-I350_COPPER" in self.nic
             or "cavium" in self.nic
             or "IXGBE_10G-X540T" in self.nic
@@ -181,6 +183,7 @@ class TestUniPacket(TestCase):
             ipv6_default_packet_type = ["L2_ETHER", "L3_IPV6_EXT_UNKNOWN"]
         elif (
             "IXGBE_10G-82599_SFP" in self.nic
+            or "IGB_1G-82576" in self.nic
             or "IGB_1G-I350_COPPER" in self.nic
             or "cavium" in self.nic
             or "IXGBE_10G-X540T" in self.nic
-- 
2.40.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/3] tests/uni_pkt: Add IGB_1G-82576
  2023-04-14 12:49 ` [PATCH 3/3] tests/uni_pkt: " Akihiko Odaki
@ 2023-04-26  2:34   ` lijuan.tu
  0 siblings, 0 replies; 5+ messages in thread
From: lijuan.tu @ 2023-04-26  2:34 UTC (permalink / raw)
  To: , Akihiko Odaki; +Cc: dts, Akihiko Odaki

On Fri, 14 Apr 2023 21:49:48 +0900, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
> IGB_1G-82576 uses L3_IPV4 for the default IPv4 packet type, and cannot
> detect ICMP.
> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>


Series applied, thanks

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2023-04-26  2:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-14 12:49 [PATCH 0/3] Changes for IGB_1G-82576 Akihiko Odaki
2023-04-14 12:49 ` [PATCH 1/3] conf/test_case_checklist: Add IGB_1G-82576 Akihiko Odaki
2023-04-14 12:49 ` [PATCH 2/3] tests/pmdrssreta: " Akihiko Odaki
2023-04-14 12:49 ` [PATCH 3/3] tests/uni_pkt: " Akihiko Odaki
2023-04-26  2:34   ` lijuan.tu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).