test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue verify method
  2020-11-11 11:37 [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue verify method sunqin
@ 2020-11-11  3:10 ` Sun, QinX
  2020-11-11  6:51 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Sun, QinX @ 2020-11-11  3:10 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

Tested-by: Sun, QinX <qinx.sun@intel.com>
 
Regards,
Sun Qin

> -----Original Message-----
> From: sunqin <qinx.sun@intel.com>
> Sent: Wednesday, November 11, 2020 7:38 PM
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue
> verify method



[-- Attachment #2: TestIAVFFdir.log --]
[-- Type: application/octet-stream, Size: 3258685 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue verify method
  2020-11-11 11:37 [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue verify method sunqin
  2020-11-11  3:10 ` Sun, QinX
@ 2020-11-11  6:51 ` Tu, Lijuan
  1 sibling, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2020-11-11  6:51 UTC (permalink / raw)
  To: Sun, QinX, dts; +Cc: Sun, QinX

> create a fdir rule, send mismatch packet, sometimes queue id may hit the
> defaule value set in the rule,
> 
> so can not just compared the queue value to judgle the case failed.
> 
> Now,use 'verify_iavf_fdir_directed_by_rss' to check queue is correctly or not
> after mark id is verifed.
> 
> 
> Signed-off-by: sunqin <qinx.sun@intel.com>

Applied

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue verify method
@ 2020-11-11 11:37 sunqin
  2020-11-11  3:10 ` Sun, QinX
  2020-11-11  6:51 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: sunqin @ 2020-11-11 11:37 UTC (permalink / raw)
  To: dts; +Cc: sunqin

create a fdir rule, send mismatch packet, sometimes queue id may hit the defaule value set in the rule, 

so can not just compared the queue value to judgle the case failed.

Now,use 'verify_iavf_fdir_directed_by_rss' to check queue is correctly or not after mark id is verifed.


Signed-off-by: sunqin <qinx.sun@intel.com>
---
 tests/rte_flow_common.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/rte_flow_common.py b/tests/rte_flow_common.py
index 43c0eab..e0a378f 100644
--- a/tests/rte_flow_common.py
+++ b/tests/rte_flow_common.py
@@ -454,7 +454,7 @@ def check_iavf_fdir_queue(out, pkt_num, check_param, stats=True):
                 raise Exception("wrong queue value, expect int or list")
         else:
             if isinstance(queue, int):
-                verify(not any(q == queue for q in res_queue), "fail: queue id should not matched, expect queue %s, got %s" % (queue, res_queue))
+                verify_iavf_fdir_directed_by_rss(out, rxq=CVL_TXQ_RXQ_NUMBER, stats=True)
                 print((GREEN("pass: queue id %s not matched" % res_queue)))
             elif isinstance(queue, list):
                 verify_iavf_fdir_directed_by_rss(out, rxq=CVL_TXQ_RXQ_NUMBER, stats=True)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-11 11:37 [dts] [PATCH V1] tests/rte_flow_common modify iavf_fdir queue verify method sunqin
2020-11-11  3:10 ` Sun, QinX
2020-11-11  6:51 ` Tu, Lijuan

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox