From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E526D288C for ; Fri, 25 Jan 2019 08:31:20 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 23:31:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,520,1539673200"; d="scan'208";a="132976618" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga001.jf.intel.com with ESMTP; 24 Jan 2019 23:31:19 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 24 Jan 2019 23:31:19 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 24 Jan 2019 23:31:18 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.207]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.253]) with mapi id 14.03.0415.000; Fri, 25 Jan 2019 15:31:17 +0800 From: "Yao, BingX Y" To: "Li, WenjieX A" , "dts@dpdk.org" CC: "Li, WenjieX A" Thread-Topic: [dts] [PATCH V2] tests/shutdown_api: update enable_disablerss Thread-Index: AQHUtHGZSTK4NV5R+U+4Cii149VZ56W/ltKw Date: Fri, 25 Jan 2019 07:31:16 +0000 Message-ID: <95BCD24840F32441BEA74E0F8A31839E04EEAE51@shsmsx102.ccr.corp.intel.com> References: <1548395505-33406-1-git-send-email-wenjiex.a.li@intel.com> In-Reply-To: <1548395505-33406-1-git-send-email-wenjiex.a.li@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/shutdown_api: update enable_disablerss X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Jan 2019 07:31:21 -0000 Tested-by: yaobing -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li Sent: Friday, January 25, 2019 1:52 PM To: dts@dpdk.org Cc: Li, WenjieX A Subject: [dts] [PATCH V2] tests/shutdown_api: update enable_disablerss Align to the changes of test plan. Signed-off-by: Wenjie Li --- V1: 1. start testpmd with "--txq=3D16 --rxq=3D16". 2. change the command to enable rss. 3. check all forward packets are not in the same queue. 4. add parameter "enable_rss" in check_forwarding() and send_packet() to ge= t the queue id of forward packet. V2: Get the queue id only when rss is enabled. tests/TestSuite_shutdown_api.py | 31 ++++++++++++++++++++++++------- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api= .py index 9f3f03f..2569159 100644 --- a/tests/TestSuite_shutdown_api.py +++ b/tests/TestSuite_shutdown_api.py @@ -40,6 +40,7 @@ import utils import time import re import os +import random from test_case import TestCase from pmd_output import PmdOutput from settings import HEADER_SIZE, PROTOCOL_PACKET_SIZE @@ -83,14 +84,14 @@= class TestShutdownApi(TestCase): stats =3D output.get_pmd_stats(portid) return stats =20 - def check_forwarding(self, ports=3DNone, pktSize=3D68, received=3DTrue= , vlan=3DFalse, promisc=3DFalse, vlan_strip=3DFalse): + def check_forwarding(self, ports=3DNone, pktSize=3D68, received=3DTrue= , vlan=3DFalse, promisc=3DFalse, vlan_strip=3DFalse, enable_rss=3DFalse): if ports is None: ports =3D self.ports if len(ports) =3D=3D 1: - self.send_packet(ports[0], ports[0], pktSize, received, vlan, = promisc, vlan_strip) + self.send_packet(ports[0], ports[0], pktSize, received,=20 + vlan, promisc, vlan_strip, enable_rss) return =20 - def send_packet(self, txPort, rxPort, pktSize=3D68, received=3DTrue, v= lan=3DFalse, promisc=3DFalse, vlan_strip=3DFalse): + def send_packet(self, txPort, rxPort, pktSize=3D68, received=3DTrue, v= lan=3DFalse, promisc=3DFalse, vlan_strip=3DFalse, enable_rss=3DFalse): """ Send packages according to parameters. """ @@ -113,11 +114,19 @@ class TestShutdownApi(TestCase): pkg =3D 'Ether(src=3D"%s", dst=3D"%s")/Dot1Q(vlan=3D1)/IP()/Ra= w(load=3D"P" * %d)' % (smac, dmac, padding) else: padding =3D pktSize - HEADER_SIZE['eth'] - HEADER_SIZE['ip'] - pkg =3D 'Ether(src=3D"%s", dst=3D"%s")/IP()/Raw(load=3D"P" * %= d)' % (smac, dmac, padding) + if enable_rss: + sip =3D "192.168.0.1" + dip =3D "192.168.0.%s" % random.randint(2, 254) + pkg =3D 'Ether(src=3D"%s", dst=3D"%s")/IP(src=3D"%s", dst= =3D"%s")/Raw(load=3D"P" * %d)' % (smac, dmac, sip, dip, padding) + else: + pkg =3D 'Ether(src=3D"%s", dst=3D"%s")/IP()/Raw(load=3D"P"= *=20 + %d)' % (smac, dmac, padding) =20 self.tester.scapy_foreground() self.tester.scapy_append('sendp(%s, iface=3D"%s")' % (pkg, itf)) self.tester.scapy_execute() + if enable_rss: + out =3D self.dut.get_session_output() + self.acutal_queue_id =3D int(re.compile('Receive=20 + queue=3D(.*?)\s+?').findall(out, re.S)[0], 16) time.sleep(3) =20 port0_stats =3D self.get_stats(txPort) @@ -397,14 +406,22 @@ class= TestShutdownApi(TestCase): """ Enable/Disable RSS. """ - self.pmdout.start_testpmd("Default", "--portmask=3D%s --port-topol= ogy=3Dloop" % utils.create_mask(self.ports), socket=3Dself.ports_socket) + self.queue_num =3D 16 + self.pmdout.start_testpmd("Default", "--portmask=3D%s --port-topol= ogy=3Dloop --txq=3D%s --rxq=3D%s"=20 + % (utils.create_mask(self.ports), self.queue_num,=20 + self.queue_num), socket=3Dself.ports_socket) =20 self.dut.send_expect("port stop all", "testpmd> ", 100) - self.dut.send_expect("port config rss ip", "testpmd> ") + self.dut.send_expect("port config all rss ip", "testpmd> ") self.dut.send_expect("set fwd mac", "testpmd>") self.dut.send_expect("port start all", "testpmd> ", 100) self.dut.send_expect("start", "testpmd> ") - self.check_forwarding() + self.dut.send_expect("set verbose 1", "testpmd> ") + queue_list =3D [] + for i in range(0, self.queue_num): + self.check_forwarding(enable_rss=3DTrue) + queue_list.append(self.acutal_queue_id) + print("Forward packets to queues: %s" % queue_list) + self.verify(len(list(set(queue_list))) > 1, "All packets were=20 + send to the same queue %s" %self.acutal_queue_id) =20 def test_change_numberrxdtxd(self): """ -- 2.17.2