From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 750D591 for ; Sat, 2 Feb 2019 07:36:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 22:36:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,551,1539673200"; d="scan'208";a="271943066" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga004.jf.intel.com with ESMTP; 01 Feb 2019 22:36:19 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Feb 2019 22:36:19 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 1 Feb 2019 22:36:18 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.207]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.109]) with mapi id 14.03.0415.000; Sat, 2 Feb 2019 14:36:17 +0800 From: "Yao, BingX Y" To: "Zhu, WenhuiX" , "dts@dpdk.org" CC: "Zhu, WenhuiX" Thread-Topic: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop Thread-Index: AQHUupf0DxTl709OCUuY2aVXBg3ryKXMDc3Q Date: Sat, 2 Feb 2019 06:36:16 +0000 Message-ID: <95BCD24840F32441BEA74E0F8A31839E04EF16A6@shsmsx102.ccr.corp.intel.com> References: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com> In-Reply-To: <1549071693-50577-1-git-send-email-wenhuix.zhu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loop X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Feb 2019 06:36:22 -0000 Tested-by: yaobing -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhuwenhui Sent: Saturday, February 2, 2019 9:42 AM To: dts@dpdk.org Cc: Zhu, WenhuiX Subject: [dts] [PATCH V4] tests/dual_vlan Change the verify outside the loo= p Verification should be outside the loop of the query port Signed-off-by: zhuwenhui --- tests/TestSuite_dual_vlan.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py in= dex d7fba3d..42497ef 100644 --- a/tests/TestSuite_dual_vlan.py +++ b/tests/TestSuite_dual_vlan.py @@ -192,7 +192,7 @@ class TestDualVlan(TestCase): time.sleep(1) out =3D self.dut.send_expect("show port info %s" % port_id= , "testpmd> ") port_time_up +=3D 1 - self.verify("Link status: down" not in out, "Port %s Link = down, please check your link" % port_id) + self.verify("Link status: down" not in out, "Port %s Link=20 + down, please check your link" % port_id) =20 def multimode_test(self, caseIndex): """ -- 2.17.2