test suite reviews and discussions
 help / color / Atom feed
* Re: [dts] [PATCH V1] tests/shutdown_api:change crc-strip command
  2019-09-11 12:00 [dts] [PATCH V1] tests/shutdown_api:change crc-strip command Wenjie Li
@ 2019-09-11  6:17 ` Yao, BingX Y
  0 siblings, 0 replies; 2+ messages in thread
From: Yao, BingX Y @ 2019-09-11  6:17 UTC (permalink / raw)
  To: Li, WenjieX A, dts; +Cc: Li, WenjieX A

[-- Attachment #1: Type: text/plain, Size: 1568 bytes --]

Tested-by: Yao, BingX Y <bingx.y.yao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
Sent: Wednesday, September 11, 2019 8:01 PM
To: dts@dpdk.org
Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api:change crc-strip command

In dpdk commit e5db17a1e54e419419, "port config all crc-strip|scatter|
rx-cksum|rx-timestamp|hw-vlan|hw-vlan-filter|hw-vlan-strip|hw-vlan-extend on|off"
was deleted, use "port config [port_id] rx_offload keep_crc off" instead of "port config all crc-strip on".

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py index f889e1c..32bb765 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -280,7 +280,8 @@ class TestShutdownApi(TestCase):
             crc_keep == RX_OFFLOAD_KEEP_CRC, "CRC keeping not enabled properly")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
-        self.dut.send_expect("port config all crc-strip on", "testpmd> ")
+        for i in range(len(self.dut.get_ports())):
+            self.dut.send_expect("port config %s rx_offload keep_crc 
+ off" % i, "testpmd> ")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
--
2.17.1


[-- Attachment #2: TestShutdownApi.log --]
[-- Type: application/octet-stream, Size: 257525 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [dts] [PATCH V1] tests/shutdown_api:change crc-strip command
@ 2019-09-11 12:00 Wenjie Li
  2019-09-11  6:17 ` Yao, BingX Y
  0 siblings, 1 reply; 2+ messages in thread
From: Wenjie Li @ 2019-09-11 12:00 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

In dpdk commit e5db17a1e54e419419, "port config all crc-strip|scatter|
rx-cksum|rx-timestamp|hw-vlan|hw-vlan-filter|hw-vlan-strip|hw-vlan-extend on|off"
was deleted, use "port config [port_id] rx_offload keep_crc off" instead
of "port config all crc-strip on".

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_shutdown_api.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index f889e1c..32bb765 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -280,7 +280,8 @@ class TestShutdownApi(TestCase):
             crc_keep == RX_OFFLOAD_KEEP_CRC, "CRC keeping not enabled properly")
 
         self.dut.send_expect("port stop all", "testpmd> ", 100)
-        self.dut.send_expect("port config all crc-strip on", "testpmd> ")
+        for i in range(len(self.dut.get_ports())):
+            self.dut.send_expect("port config %s rx_offload keep_crc off" % i, "testpmd> ")
         self.dut.send_expect("set fwd mac", "testpmd>")
         self.dut.send_expect("port start all", "testpmd> ", 100)
         out = self.dut.send_expect("show config rxtx", "testpmd> ")
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-11 12:00 [dts] [PATCH V1] tests/shutdown_api:change crc-strip command Wenjie Li
2019-09-11  6:17 ` Yao, BingX Y

test suite reviews and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ http://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/ public-inbox