From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Sun, QinX" <qinx.sun@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Sun, QinX" <qinx.sun@intel.com>
Subject: Re: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
Date: Wed, 7 Apr 2021 01:41:11 +0000 [thread overview]
Message-ID: <97c5c75fae7341c0a3b966a6d5c2b145@intel.com> (raw)
In-Reply-To: <20210330144631.12328-1-qinx.sun@intel.com>
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of sunqin
> Sent: 2021年3月30日 22:47
> To: dts@dpdk.org
> Cc: Sun, QinX <qinx.sun@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf
>
> Confirm with developer that the design of dpdk is changed for VF, the VLAN ID
> needs to be set before VF receives VLAN packets.
>
> Signed-off-by: sunqin <qinx.sun@intel.com>
> ---
> v1: add vlan id in a common function,will be called by most of cases
> v2: add vlan id only for related cases
>
> tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
> mode change 100755 => 100644
> tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
>
> diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> old mode 100755
> new mode 100644
> index 6490dcbf..3a679178
> --- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> +++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py
> @@ -8678,34 +8678,60 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase):
> # vf rss gtpc gtpu
> def test_mac_ipv4_gtpu(self):
> self.switch_testpmd(symmetric=False)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
> + self.pmd_output.execute_cmd('rx_vlan add 3 0')
> + self.pmd_output.execute_cmd('rx_vlan add 5 0')
Add vlan id in every related test cases, but never remove them, in the following cases the setting is still valid.
For example, add vlan id 1, 3, 5 in test case #1, when running test case #2 the setting is still there.
Could you please consider what's the best way to achieve your target and least impact to other cases.
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_toeplitz)
>
> def test_mac_ipv6_gtpu(self):
> self.switch_testpmd(symmetric=False)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
> + self.pmd_output.execute_cmd('rx_vlan add 5 0')
> + self.pmd_output.execute_cmd('rx_vlan add 7 0')
> +
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_toeplitz)
>
> def test_mac_ipv4_gtpc(self):
> self.switch_testpmd(symmetric=False)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
> + self.pmd_output.execute_cmd('rx_vlan add 3 0')
> + self.pmd_output.execute_cmd('rx_vlan add 5 0')
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_toeplitz)
>
> def test_mac_ipv6_gtpc(self):
> self.switch_testpmd(symmetric=False)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
> + self.pmd_output.execute_cmd('rx_vlan add 5 0')
> + self.pmd_output.execute_cmd('rx_vlan add 3 0')
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_toeplitz)
>
> def test_mac_ipv4_gtpu_symmetric(self):
> self.switch_testpmd(symmetric=True)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpu_symmet
> ric_toeplitz)
>
> def test_mac_ipv6_gtpu_symmetric(self):
> self.switch_testpmd(symmetric=True)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpu_symmet
> ric_toeplitz)
>
> def test_mac_ipv4_gtpc_symmetric(self):
> self.switch_testpmd(symmetric=True)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv4_gtpc_symmet
> ric_toeplitz)
>
> def test_mac_ipv6_gtpc_symmetric(self):
> self.switch_testpmd(symmetric=True)
> + self.pmd_output.execute_cmd('vlan set filter on 0')
> + self.pmd_output.execute_cmd('rx_vlan add 1 0')
> +
>
> self.rssprocess.handle_rss_distribute_cases(cases_info=mac_ipv6_gtpc_symmet
> ric_toeplitz)
>
> def tear_down(self):
> --
> 2.17.1
prev parent reply other threads:[~2021-04-07 1:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 14:46 sunqin
2021-03-30 6:21 ` Sun, QinX
2021-04-07 1:41 ` Tu, Lijuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=97c5c75fae7341c0a3b966a6d5c2b145@intel.com \
--to=lijuan.tu@intel.com \
--cc=dts@dpdk.org \
--cc=qinx.sun@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).