From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AADADA0546; Wed, 7 Apr 2021 03:41:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DA6D141009; Wed, 7 Apr 2021 03:41:17 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2C155407FF for ; Wed, 7 Apr 2021 03:41:15 +0200 (CEST) IronPort-SDR: aGq12rFoHRcx3YOjPXoEHYWAw5AaQ4Wk80VVGU6/PAzoDKqLDAVL8JpD7rKqs5y2VqwjYUDLp+ B8+r1ZXDq4gA== X-IronPort-AV: E=McAfee;i="6000,8403,9946"; a="191030860" X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="191030860" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2021 18:41:14 -0700 IronPort-SDR: aBuwFwYoKifjLF3i6T/cQkK9BttAYqzisDoseqTalSniiAlnqgtD3YfleYFSrTJ9mGCac5ZIu9 Ls5QtlrKEaTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,201,1613462400"; d="scan'208";a="458128017" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 06 Apr 2021 18:41:14 -0700 Received: from shsmsx605.ccr.corp.intel.com (10.109.6.215) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 6 Apr 2021 18:41:13 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX605.ccr.corp.intel.com (10.109.6.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 09:41:11 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Wed, 7 Apr 2021 09:41:11 +0800 From: "Tu, Lijuan" To: "Sun, QinX" , "dts@dpdk.org" CC: "Sun, QinX" Thread-Topic: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf Thread-Index: AQHXJStdedm0dzuSIkywo+lznMQK56qoUgyg Date: Wed, 7 Apr 2021 01:41:11 +0000 Message-ID: <97c5c75fae7341c0a3b966a6d5c2b145@intel.com> References: <20210330144631.12328-1-qinx.sun@intel.com> In-Reply-To: <20210330144631.12328-1-qinx.sun@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id for vf X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" > -----Original Message----- > From: dts On Behalf Of sunqin > Sent: 2021=1B$BG/=1B(B3=1B$B7n=1B(B30=1B$BF|=1B(B 22:47 > To: dts@dpdk.org > Cc: Sun, QinX > Subject: [dts] [PATCH V2] tests/cvl_advanced_iavf_rss_gtpu: set vlan id f= or vf >=20 > Confirm with developer that the design of dpdk is changed for VF, the VLA= N ID > needs to be set before VF receives VLAN packets. >=20 > Signed-off-by: sunqin > --- > v1: add vlan id in a common function,will be called by most of cases > v2: add vlan id only for related cases >=20 > tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > mode change 100755 =3D> 100644 > tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py >=20 > diff --git a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py > b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py > old mode 100755 > new mode 100644 > index 6490dcbf..3a679178 > --- a/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py > +++ b/tests/TestSuite_cvl_advanced_iavf_rss_gtpu.py > @@ -8678,34 +8678,60 @@ class TestCVLAdvancedIAVFRSSGTPU(TestCase): > # vf rss gtpc gtpu > def test_mac_ipv4_gtpu(self): > self.switch_testpmd(symmetric=3DFalse) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') > + self.pmd_output.execute_cmd('rx_vlan add 3 0') > + self.pmd_output.execute_cmd('rx_vlan add 5 0') Add vlan id in every related test cases, but never remove them, in the foll= owing cases the setting is still valid. For example, add vlan id 1, 3, 5 in test case #1, when running test case #2= the setting is still there. Could you please consider what's the best way to achieve your target and le= ast impact to other cases. >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv4_gtpu_to= eplitz) >=20 > def test_mac_ipv6_gtpu(self): > self.switch_testpmd(symmetric=3DFalse) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') > + self.pmd_output.execute_cmd('rx_vlan add 5 0') > + self.pmd_output.execute_cmd('rx_vlan add 7 0') > + >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv6_gtpu_to= eplitz) >=20 > def test_mac_ipv4_gtpc(self): > self.switch_testpmd(symmetric=3DFalse) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') > + self.pmd_output.execute_cmd('rx_vlan add 3 0') > + self.pmd_output.execute_cmd('rx_vlan add 5 0') >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv4_gtpc_to= eplitz) >=20 > def test_mac_ipv6_gtpc(self): > self.switch_testpmd(symmetric=3DFalse) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') > + self.pmd_output.execute_cmd('rx_vlan add 5 0') > + self.pmd_output.execute_cmd('rx_vlan add 3 0') >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv6_gtpc_to= eplitz) >=20 > def test_mac_ipv4_gtpu_symmetric(self): > self.switch_testpmd(symmetric=3DTrue) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv4_gtpu_sy= mmet > ric_toeplitz) >=20 > def test_mac_ipv6_gtpu_symmetric(self): > self.switch_testpmd(symmetric=3DTrue) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv6_gtpu_sy= mmet > ric_toeplitz) >=20 > def test_mac_ipv4_gtpc_symmetric(self): > self.switch_testpmd(symmetric=3DTrue) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv4_gtpc_sy= mmet > ric_toeplitz) >=20 > def test_mac_ipv6_gtpc_symmetric(self): > self.switch_testpmd(symmetric=3DTrue) > + self.pmd_output.execute_cmd('vlan set filter on 0') > + self.pmd_output.execute_cmd('rx_vlan add 1 0') > + >=20 > self.rssprocess.handle_rss_distribute_cases(cases_info=3Dmac_ipv6_gtpc_sy= mmet > ric_toeplitz) >=20 > def tear_down(self): > -- > 2.17.1