test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Zhao, MeijuanX" <meijuanx.zhao@intel.com>
To: "Lin, Xueqin" <xueqin.lin@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Lin, Xueqin" <xueqin.lin@intel.com>,
	"Zhao, MeijuanX" <meijuanx.zhao@intel.com>
Subject: Re: [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues
Date: Fri, 11 Jan 2019 07:30:42 +0000	[thread overview]
Message-ID: <9866F1E5CE768A45B24F6603C6EF54DE05A4CEF1@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1546928165-173890-1-git-send-email-xueqin.lin@intel.com>

Tested-by : Zhao, MeijuanX <meijuanx.zhao@intel.com>

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Xueqin Lin
Sent: Tuesday, January 8, 2019 2:16 PM
To: dts@dpdk.org
Cc: Lin, Xueqin <xueqin.lin@intel.com>
Subject: [dts] [PATCH] tests/ddp_mpls: fix nic support and core reset issues

From: "xueqin.lin" <xueqin.lin@intel.com>

1. DDP MPLs could support FVL nic, not only fortville_25g.
2. Restore original profile instead of core reset to avoid exception.

Signed-off-by: Xueqin Lin <xueqin.lin@intel.com>

---
 tests/TestSuite_ddp_mpls.py | 26 ++++++++++++++++----------
 1 file changed, 16 insertions(+), 10 deletions(-)

diff --git a/tests/TestSuite_ddp_mpls.py b/tests/TestSuite_ddp_mpls.py index 691e958..b002788 100644
--- a/tests/TestSuite_ddp_mpls.py
+++ b/tests/TestSuite_ddp_mpls.py
@@ -18,8 +18,8 @@ VF_MAX_QUEUE = 4
 class Testddp_mpls(TestCase):
 
     def set_up_all(self):
-        self.verify(self.nic in ['fortville_25g'], 
-            'ddp mpls can not support %s nic' % self.nic)
+        self.verify('fortville' in self.nic,
+                    'ddp mpls can not support %s nic' % self.nic)
         self.dut_ports = self.dut.get_ports(self.nic)
         self.verify(len(self.dut_ports) >= 1, "Insufficient ports")
         self.vm0 = None
@@ -123,7 +123,7 @@ class Testddp_mpls(TestCase):
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 0" in out,
             "Failed to get ddp profile info list!!!") 
-        self.dut_testpmd.execute_cmd('ddp add 0 /tmp/mpls.pkgo')
+        self.dut_testpmd.execute_cmd('ddp add 0 
+ /tmp/mpls.pkgo,/tmp/mpls.bak')
         out = self.dut_testpmd.execute_cmd('ddp get list 0')
         self.verify("Profile number is: 1" in out,
             "Failed to load ddp profile!!!") @@ -224,13 +224,19 @@ class Testddp_mpls(TestCase):
     
 
     def tear_down(self):
-        if self.vm0_testpmd:
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 1')
-            self.dut_testpmd.execute_cmd('write reg 0 0xb8190 2')
-            self.vm0_testpmd.quit()
-            self.dut_testpmd.quit()
-        self.vm0_dut.kill_all()
-        pass
+        self.vm0_testpmd.execute_cmd('stop')
+        self.dut_testpmd.execute_cmd('stop')
+        out = self.dut_testpmd.execute_cmd('ddp get list 0')
+        if "Profile number is: 0" not in out:
+            self.dut_testpmd.execute_cmd('port stop all')
+            time.sleep(1)
+            self.dut_testpmd.execute_cmd('ddp del 0 /tmp/mpls.bak')
+            out = self.dut_testpmd.execute_cmd('ddp get list 0')
+            self.verify("Profile number is: 0" in out,
+                        "Failed to delete mpls profile!!!")
+            self.dut_testpmd.execute_cmd('port start all')
+        self.vm0_testpmd.quit()
+        self.dut_testpmd.quit()
 
 
     def tear_down_all(self):
--
2.7.5

  reply	other threads:[~2019-01-11  7:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-08  6:16 Xueqin Lin
2019-01-11  7:30 ` Zhao, MeijuanX [this message]
2019-01-11  8:26 ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9866F1E5CE768A45B24F6603C6EF54DE05A4CEF1@shsmsx102.ccr.corp.intel.com \
    --to=meijuanx.zhao@intel.com \
    --cc=dts@dpdk.org \
    --cc=xueqin.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).