* [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
@ 2018-05-17 2:09 han,yingya
2018-05-17 2:17 ` Liu, Yong
0 siblings, 1 reply; 5+ messages in thread
From: han,yingya @ 2018-05-17 2:09 UTC (permalink / raw)
To: dts; +Cc: han,yingya
the output of CRC stripping changed in 18.05 and 'Rx offloads=0x1000' is
defined as DEV_RX_OFFLOAD_CRC_STRIP.
Signed-off-by: han,yingya <yingyax.han@intel.com>
---
tests/TestSuite_shutdown_api.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index af0b77d..4c7ca09 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -253,8 +253,8 @@ class TestShutdownApi(TestCase):
self.dut.send_expect("set fwd mac", "testpmd>")
self.dut.send_expect("port start all", "testpmd> ", 100)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
- self.verify("RX queues=2" in out, "RX queues not reconfigured properly")
- self.verify("TX queues=2" in out, "TX queues not reconfigured properly")
+ self.verify("RX queue number: 2" in out, "RX queues not reconfigured properly")
+ self.verify("Tx queue number: 2" in out, "TX queues not reconfigured properly")
self.dut.send_expect("start", "testpmd> ")
self.check_forwarding()
self.dut.send_expect("quit", "# ", 30)
@@ -263,7 +263,7 @@ class TestShutdownApi(TestCase):
"""
Reconfigure All Ports With The Same Configurations (CRC)
"""
- self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
+ self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
self.dut.send_expect("port stop all", "testpmd> ", 100)
self.dut.send_expect("port config all crc-strip on", "testpmd> ")
@@ -271,7 +271,7 @@ class TestShutdownApi(TestCase):
self.dut.send_expect("port start all", "testpmd> ", 100)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
self.verify(
- "CRC stripping enabled" in out, "CRC stripping not enabled properly")
+ "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
self.dut.send_expect("start", "testpmd> ")
self.check_forwarding()
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
2018-05-17 2:09 [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue han,yingya
@ 2018-05-17 2:17 ` Liu, Yong
2018-05-17 2:59 ` Han, YingyaX
0 siblings, 1 reply; 5+ messages in thread
From: Liu, Yong @ 2018-05-17 2:17 UTC (permalink / raw)
To: Han, YingyaX, dts; +Cc: Han, YingyaX
Yingya,
One comment below.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Thursday, May 17, 2018 10:10 AM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled
> issue
>
> the output of CRC stripping changed in 18.05 and 'Rx offloads=0x1000' is
> defined as DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py
> index af0b77d..4c7ca09 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -253,8 +253,8 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("set fwd mac", "testpmd>")
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> - self.verify("RX queues=2" in out, "RX queues not reconfigured
> properly")
> - self.verify("TX queues=2" in out, "TX queues not reconfigured
> properly")
> + self.verify("RX queue number: 2" in out, "RX queues not
> reconfigured properly")
> + self.verify("Tx queue number: 2" in out, "TX queues not
> reconfigured properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
> self.dut.send_expect("quit", "# ", 30)
> @@ -263,7 +263,7 @@ class TestShutdownApi(TestCase):
> """
> Reconfigure All Ports With The Same Configurations (CRC)
> """
> - self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
> + self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop --disable-crc-strip" % utils.create_mask(self.ports),
> socket=self.ports_socket)
When starting testpmd, crc-strip has been disabled. But in the verify judgement, still check crc-strip enable.
Could you please explain what cause the confiction?
>
> self.dut.send_expect("port stop all", "testpmd> ", 100)
> self.dut.send_expect("port config all crc-strip on", "testpmd> ")
> @@ -271,7 +271,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> self.verify(
> - "CRC stripping enabled" in out, "CRC stripping not enabled
> properly")
> + "Rx offloads=0x1000" in out, "CRC stripping not enabled
> properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
2018-05-17 2:17 ` Liu, Yong
@ 2018-05-17 2:59 ` Han, YingyaX
0 siblings, 0 replies; 5+ messages in thread
From: Han, YingyaX @ 2018-05-17 2:59 UTC (permalink / raw)
To: Liu, Yong, dts
The CRC strip defaults to enable and the script has the 'port config all CRC -strip on'. so I used the '-disable- CRC -strip' parameter.
I will modify the script to verify it before set CRC strip on .
-----Original Message-----
From: Liu, Yong
Sent: Thursday, May 17, 2018 10:17 AM
To: Han, YingyaX <yingyax.han@intel.com>; dts@dpdk.org
Cc: Han, YingyaX <yingyax.han@intel.com>
Subject: RE: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
Yingya,
One comment below.
Thanks,
Marvin
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya
> Sent: Thursday, May 17, 2018 10:10 AM
> To: dts@dpdk.org
> Cc: Han, YingyaX <yingyax.han@intel.com>
> Subject: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping
> enabled issue
>
> the output of CRC stripping changed in 18.05 and 'Rx offloads=0x1000'
> is defined as DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: han,yingya <yingyax.han@intel.com>
> ---
> tests/TestSuite_shutdown_api.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/tests/TestSuite_shutdown_api.py
> b/tests/TestSuite_shutdown_api.py index af0b77d..4c7ca09 100644
> --- a/tests/TestSuite_shutdown_api.py
> +++ b/tests/TestSuite_shutdown_api.py
> @@ -253,8 +253,8 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("set fwd mac", "testpmd>")
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> - self.verify("RX queues=2" in out, "RX queues not reconfigured
> properly")
> - self.verify("TX queues=2" in out, "TX queues not reconfigured
> properly")
> + self.verify("RX queue number: 2" in out, "RX queues not
> reconfigured properly")
> + self.verify("Tx queue number: 2" in out, "TX queues not
> reconfigured properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
> self.dut.send_expect("quit", "# ", 30) @@ -263,7 +263,7 @@
> class TestShutdownApi(TestCase):
> """
> Reconfigure All Ports With The Same Configurations (CRC)
> """
> - self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop" % utils.create_mask(self.ports),
> socket=self.ports_socket)
> + self.pmdout.start_testpmd("Default", "--portmask=%s --port-
> topology=loop --disable-crc-strip" % utils.create_mask(self.ports),
> socket=self.ports_socket)
When starting testpmd, crc-strip has been disabled. But in the verify judgement, still check crc-strip enable.
Could you please explain what cause the confiction?
>
> self.dut.send_expect("port stop all", "testpmd> ", 100)
> self.dut.send_expect("port config all crc-strip on",
> "testpmd> ") @@ -271,7 +271,7 @@ class TestShutdownApi(TestCase):
> self.dut.send_expect("port start all", "testpmd> ", 100)
> out = self.dut.send_expect("show config rxtx", "testpmd> ")
> self.verify(
> - "CRC stripping enabled" in out, "CRC stripping not enabled
> properly")
> + "Rx offloads=0x1000" in out, "CRC stripping not enabled
> properly")
> self.dut.send_expect("start", "testpmd> ")
> self.check_forwarding()
>
> --
> 1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
2018-05-17 5:15 han,yingya
@ 2018-05-17 15:30 ` Liu, Yong
0 siblings, 0 replies; 5+ messages in thread
From: Liu, Yong @ 2018-05-17 15:30 UTC (permalink / raw)
To: han,yingya, dts
Thanks, Yingya. Applied.
On 05/17/2018 01:15 PM, han,yingya wrote:
> The CRC strip defaults to enable and the output of CRC stripping changed in 18.05.
> 'Rx offloads=0x1000' is defined as DEV_RX_OFFLOAD_CRC_STRIP.
>
> Signed-off-by: han,yingya<yingyax.han@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue
@ 2018-05-17 5:15 han,yingya
2018-05-17 15:30 ` Liu, Yong
0 siblings, 1 reply; 5+ messages in thread
From: han,yingya @ 2018-05-17 5:15 UTC (permalink / raw)
To: dts; +Cc: han,yingya
The CRC strip defaults to enable and the output of CRC stripping changed in 18.05.
'Rx offloads=0x1000' is defined as DEV_RX_OFFLOAD_CRC_STRIP.
Signed-off-by: han,yingya <yingyax.han@intel.com>
---
tests/TestSuite_shutdown_api.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index af0b77d..8b6de18 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -253,8 +253,8 @@ class TestShutdownApi(TestCase):
self.dut.send_expect("set fwd mac", "testpmd>")
self.dut.send_expect("port start all", "testpmd> ", 100)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
- self.verify("RX queues=2" in out, "RX queues not reconfigured properly")
- self.verify("TX queues=2" in out, "TX queues not reconfigured properly")
+ self.verify("RX queue number: 2" in out, "RX queues not reconfigured properly")
+ self.verify("Tx queue number: 2" in out, "TX queues not reconfigured properly")
self.dut.send_expect("start", "testpmd> ")
self.check_forwarding()
self.dut.send_expect("quit", "# ", 30)
@@ -263,7 +263,10 @@ class TestShutdownApi(TestCase):
"""
Reconfigure All Ports With The Same Configurations (CRC)
"""
- self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop" % utils.create_mask(self.ports), socket=self.ports_socket)
+ self.pmdout.start_testpmd("Default", "--portmask=%s --port-topology=loop --disable-crc-strip" % utils.create_mask(self.ports), socket=self.ports_socket)
+ out = self.dut.send_expect("show config rxtx", "testpmd> ")
+ self.verify(
+ "Rx offloads=0x0" in out, "CRC stripping not disabled properly")
self.dut.send_expect("port stop all", "testpmd> ", 100)
self.dut.send_expect("port config all crc-strip on", "testpmd> ")
@@ -271,7 +274,7 @@ class TestShutdownApi(TestCase):
self.dut.send_expect("port start all", "testpmd> ", 100)
out = self.dut.send_expect("show config rxtx", "testpmd> ")
self.verify(
- "CRC stripping enabled" in out, "CRC stripping not enabled properly")
+ "Rx offloads=0x1000" in out, "CRC stripping not enabled properly")
self.dut.send_expect("start", "testpmd> ")
self.check_forwarding()
--
1.9.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-05-17 7:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-17 2:09 [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue han,yingya
2018-05-17 2:17 ` Liu, Yong
2018-05-17 2:59 ` Han, YingyaX
2018-05-17 5:15 han,yingya
2018-05-17 15:30 ` Liu, Yong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).