From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A9C9C5F2E for ; Thu, 17 May 2018 04:59:14 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2018 19:59:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,408,1520924400"; d="scan'208";a="55069269" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 16 May 2018 19:59:13 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 May 2018 19:59:13 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 16 May 2018 19:59:13 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.40]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.240]) with mapi id 14.03.0319.002; Thu, 17 May 2018 10:59:10 +0800 From: "Han, YingyaX" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue Thread-Index: AQHT7YUkoepitbhhEE+PhbR2fHYetaQzN+uw Date: Thu, 17 May 2018 02:59:10 +0000 Message-ID: <9AC1400278453341942179604C2BF126D8DF12@SHSMSX101.ccr.corp.intel.com> References: <1526522974-14883-1-git-send-email-yingyax.han@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E63043D01@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E63043D01@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enabled issue X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2018 02:59:15 -0000 The CRC strip defaults to enable and the script has the 'port config all CR= C -strip on'. so I used the '-disable- CRC -strip' parameter. I will modify the script to verify it before set CRC strip on . -----Original Message----- From: Liu, Yong=20 Sent: Thursday, May 17, 2018 10:17 AM To: Han, YingyaX ; dts@dpdk.org Cc: Han, YingyaX Subject: RE: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping enab= led issue Yingya, One comment below.=20 Thanks, Marvin > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of han,yingya > Sent: Thursday, May 17, 2018 10:10 AM > To: dts@dpdk.org > Cc: Han, YingyaX > Subject: [dts] [PATCH V1]tests/shutdown_api: fix the CRC stripping=20 > enabled issue >=20 > the output of CRC stripping changed in 18.05 and 'Rx offloads=3D0x1000'=20 > is defined as DEV_RX_OFFLOAD_CRC_STRIP. >=20 > Signed-off-by: han,yingya > --- > tests/TestSuite_shutdown_api.py | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/tests/TestSuite_shutdown_api.py=20 > b/tests/TestSuite_shutdown_api.py index af0b77d..4c7ca09 100644 > --- a/tests/TestSuite_shutdown_api.py > +++ b/tests/TestSuite_shutdown_api.py > @@ -253,8 +253,8 @@ class TestShutdownApi(TestCase): > self.dut.send_expect("set fwd mac", "testpmd>") > self.dut.send_expect("port start all", "testpmd> ", 100) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > - self.verify("RX queues=3D2" in out, "RX queues not reconfigured > properly") > - self.verify("TX queues=3D2" in out, "TX queues not reconfigured > properly") > + self.verify("RX queue number: 2" in out, "RX queues not > reconfigured properly") > + self.verify("Tx queue number: 2" in out, "TX queues not > reconfigured properly") > self.dut.send_expect("start", "testpmd> ") > self.check_forwarding() > self.dut.send_expect("quit", "# ", 30) @@ -263,7 +263,7 @@=20 > class TestShutdownApi(TestCase): > """ > Reconfigure All Ports With The Same Configurations (CRC) > """ > - self.pmdout.start_testpmd("Default", "--portmask=3D%s --port- > topology=3Dloop" % utils.create_mask(self.ports),=20 > socket=3Dself.ports_socket) > + self.pmdout.start_testpmd("Default", "--portmask=3D%s --port- > topology=3Dloop --disable-crc-strip" % utils.create_mask(self.ports), > socket=3Dself.ports_socket) When starting testpmd, crc-strip has been disabled. But in the verify judge= ment, still check crc-strip enable. Could you please explain what cause the confiction?=20 >=20 > self.dut.send_expect("port stop all", "testpmd> ", 100) > self.dut.send_expect("port config all crc-strip on",=20 > "testpmd> ") @@ -271,7 +271,7 @@ class TestShutdownApi(TestCase): > self.dut.send_expect("port start all", "testpmd> ", 100) > out =3D self.dut.send_expect("show config rxtx", "testpmd> ") > self.verify( > - "CRC stripping enabled" in out, "CRC stripping not enabled > properly") > + "Rx offloads=3D0x1000" in out, "CRC stripping not enabled > properly") > self.dut.send_expect("start", "testpmd> ") > self.check_forwarding() >=20 > -- > 1.9.3